From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40355: [PATCH] Implement caching for libravatar lookup Date: Sat, 08 Aug 2020 15:03:58 +0200 Message-ID: <87a6z51e81.fsf@gnus.org> References: <20200331180336.2999-1-philip@warpmail.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11271"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40355@debbugs.gnu.org To: Philip K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 08 15:07:48 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4OZf-0002py-Av for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 15:07:47 +0200 Original-Received: from localhost ([::1]:53560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4OZe-0000BD-Co for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 09:07:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4OX0-0003LW-IU for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 09:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4OX0-0000kC-50 for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 09:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4OWz-0007M7-Pe for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 09:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Aug 2020 13:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40355-submit@debbugs.gnu.org id=B40355.159689185028210 (code B ref 40355); Sat, 08 Aug 2020 13:05:01 +0000 Original-Received: (at 40355) by debbugs.gnu.org; 8 Aug 2020 13:04:10 +0000 Original-Received: from localhost ([127.0.0.1]:58484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4OWA-0007Kw-5g for submit@debbugs.gnu.org; Sat, 08 Aug 2020 09:04:10 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4OW7-0007Kj-Rs for 40355@debbugs.gnu.org; Sat, 08 Aug 2020 09:04:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7IYgMyD4WYkP2O1cUVBEThJwAuhHR/5O0NPh7Tk1XUU=; b=VoTL5CJu9SquwkpWk2UhR6cxqj RuS5c4KHs7NNjvVS+7SpgdcuCZ5VMm1qiE6ibVtEl01mVxJDfuHfEIWE+02Mb9GfHKIvc4mcTcaO+ G30kBuSZl2HxA+2PZYH+49aiIXly4Om0b5AFhJeE4hXJlgObtlEs2Li8ueB9lRIUWIew=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4OVz-0004aG-HA; Sat, 08 Aug 2020 15:04:02 +0200 In-Reply-To: <20200331180336.2999-1-philip@warpmail.net> (Philip K.'s message of "Tue, 31 Mar 2020 20:03:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184343 Archived-At: Philip K writes: > Checking if a domain has an avatar server associated with it requires > at most two (synchronous) DNS queries, at least to ultimately default > to "libravatar.org". Caching the results of domain lookups reduced the > evaluation time (on my machine) from ~0.3s to an instantaneous > evaluation. > > * lisp/image/gravatar.el (gravatar--service-libravatar): Check if > domain has already been resolved before staring DNS queries > (gravatar-libravatar-cache): New variable. The code has changed a bit (and become asynchronous), but adding caching would be nice. Can you re-spin the patch on top of the current implementation? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no