From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Glenn Morris <rgm@gnu.org>,
37564@debbugs.gnu.org, stefan@marxist.se, matthew@mattleach.net
Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications
Date: Sat, 15 Aug 2020 14:37:26 +0200 [thread overview]
Message-ID: <87a6ywxeyh.fsf@gnus.org> (raw)
In-Reply-To: <83eevrv6hk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Jan 2020 17:46:47 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> PS for an example of the effect, one can use some of the programs in
>> the ncurses-examples from
>> https://invisible-island.net/ncurses/ncurses-examples.html
>>
>> eg "worm".
>
> I understand that applications based on ncurses are affected, but what
> about those which aren't based on ncurses?
I think the rough consensus here was that adding LINES/COLUMNS is
usually the wrong thing to do, but Eli worries that this might break
something. So I've applied Matthew's patch, but also added a defcustom
to control this.
I've defaulted the variable to "don't add the variables", but if this
leads to problems during the Emacs 28.1 cycle, we can flip it to "on"
later.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-15 12:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 19:59 bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Matthew Leach
2019-10-01 6:01 ` Eli Zaretskii
2019-10-01 15:47 ` Matthew Leach
2019-10-01 16:07 ` Eli Zaretskii
2019-10-01 18:33 ` Matthew Leach
2019-10-01 18:58 ` Eli Zaretskii
2019-10-01 19:14 ` Eli Zaretskii
2019-10-01 19:24 ` Matthew Leach
2019-10-02 2:28 ` Eli Zaretskii
2019-10-03 17:51 ` Glenn Morris
2019-10-04 18:48 ` Matthew Leach
2020-01-20 19:10 ` Stefan Kangas
2020-01-20 19:30 ` Eli Zaretskii
2020-01-21 0:58 ` Glenn Morris
2020-01-21 17:11 ` Eli Zaretskii
2020-01-21 18:10 ` Matthew Leach
2020-01-22 3:38 ` Glenn Morris
2020-01-22 15:46 ` Eli Zaretskii
2020-06-04 16:01 ` Glenn Morris
2020-08-15 12:37 ` Lars Ingebrigtsen [this message]
2020-01-24 18:08 ` Stefan Kangas
2020-01-21 3:04 ` Stefan Kangas
2019-10-04 18:47 ` Matthew Leach
2019-10-07 4:11 ` Lars Ingebrigtsen
2019-10-07 9:16 ` Andreas Schwab
2019-10-08 16:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6ywxeyh.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=37564@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=matthew@mattleach.net \
--cc=rgm@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.