bug#36414: 27.0.50; svg-clock does not work anymore

bug#36414: 27.0.50; svg-clock does not work anymore

[Dieter Deyke]

Executing (svg-clock) from elpa does not show the clock anymore, but just the
single char '*'.


In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
 of 2019-06-28 built on deyke2
Repository revision: 960eb766e8ead0a81ad31c1f931bb8be9c61c7bd
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Recent messages:
Checking 205 files in /usr/local/emacs/share/emacs/27.0.50/lisp/gnus...
Checking 57 files in /usr/local/emacs/share/emacs/27.0.50/lisp/eshell...
Checking 71 files in /usr/local/emacs/share/emacs/27.0.50/lisp/erc...
Checking 34 files in /usr/local/emacs/share/emacs/27.0.50/lisp/emulation...
Checking 182 files in /usr/local/emacs/share/emacs/27.0.50/lisp/emacs-lisp...
Checking 24 files in /usr/local/emacs/share/emacs/27.0.50/lisp/cedet...
Checking 57 files in /usr/local/emacs/share/emacs/27.0.50/lisp/calendar...
Checking 87 files in /usr/local/emacs/share/emacs/27.0.50/lisp/calc...
Checking 111 files in /usr/local/emacs/share/emacs/27.0.50/lisp/obsolete...
Checking for load-path shadows...done

Configured using:
 'configure --prefix=/usr/local/emacs'

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY
LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD JSON PDUMPER
LCMS2 GMP

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  delete-selection-mode: t
  cua-mode: t
  msb-mode: t
  icomplete-mode: t
  show-paren-mode: t
  which-function-mode: t
  display-time-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(swbuff pp shadow sort gnus-cite mail-extr dabbrev add-log eieio-opt
cl-extra speedbar sb-image ezimage dframe thingatpt help-fns radix-tree
help-mode svg-clock svg dom emacsbug time-stamp copyright gnus-ml
disp-table nndraft nnmh gnus-agent gnus-srvr gnus-score score-mode
nnvirtual nnfolder gnus-cache gnutls network-stream nsm spam-stat
smtpmail sendmail nnrss xml nnml mm-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf url-util
gnus-topic gnus-msg gnus-async nntp elec-pair session infodoc-theme view
solar cal-dst holidays hol-loaddefs vc-fossil org-duration diary-lib
diary-loaddefs cal-iso vc-git diff-mode tempbuf org-rmail org-mhe
org-irc org-info org-gnus nnir org-docview doc-view jka-compr image-mode
org-bibtex bibtex org-bbdb org-w3m generic-x org-contacts ol org-capture
org-agenda gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap
gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail
mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message
rmc puny rfc822 mml mml-sec epa derived epg mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win
gnus nnheader wid-edit gnus-util rmail rmail-loaddefs rfc2047 rfc2045
ietf-drums mail-utils text-property-search org-element avl-tree
generator org org-macro org-footnote org-pcomplete pcomplete org-list
org-faces org-entities noutline outline org-version ob-emacs-lisp ob
ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint comint
ansi-color ob-core ob-eval org-compat org-macs org-loaddefs format-spec
find-func cal-menu calendar cal-loaddefs cl rcirc time-date ring netrc
emms-streams later-do emms-volume easy-mmode emms-volume-amixer
emms-metaplaylist-mode emms-playlist-mode emms-player-vlc advice
emms-player-mpv emms-player-mplayer emms-player-simple
emms-source-playlist emms-source-file locate emms-setup emms emms-compat
bongo lastfm-submit volume allout esh-mode esh-cmd esh-ext esh-opt
esh-proc esh-io esh-arg esh-module esh-groups esh-util server delsel
cua-base msb icomplete mic-paren paren german-holidays dired
dired-loaddefs which-func imenu mm-util mail-prsvr time mule-util info
package easymenu epg-config url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map
url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 344236 70478)
 (symbols 48 59844 88)
 (strings 32 177325 6629)
 (string-bytes 1 5855564)
 (vectors 16 50220)
 (vector-slots 8 775399 28418)
 (floats 8 3721 42256)
 (intervals 56 1195 5)
 (buffers 992 33))

-- 
Dieter Deyke
mailto:dieter.deyke@gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

bug#36414: 27.0.50; svg-clock does not work anymore

[Pip Cet]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

On Fri, Jun 28, 2019 at 5:29 AM Dieter Deyke <dieter.deyke@gmail.com> wrote:
> Executing (svg-clock) from elpa does not show the clock anymore, but just the
> single char '*'.

Sorry for barging in, I thought this might be related to the recent
image.c changes so I had a look.

svg-clock.el uses `svg-def', which is now an internal function,
`svg--def'. I believe Lars is the one working on this.

Can you try the attached patch to see whether that is indeed the problem?

[-- Attachment #2: 0001-Copy-svg-def-to-manipulate-the-DOM-directly-from-svg.patch --]
[-- Type: text/x-patch, Size: 1651 bytes --]

From 7ed2545ee2f182e419abbaf9050f765b98bf8f05 Mon Sep 17 00:00:00 2001
From: Pip Cet <pipcet@gmail.com>
Date: Fri, 28 Jun 2019 06:56:31 +0000
Subject: [PATCH] Copy svg--def to manipulate the DOM directly from
 svg-clock.el

---
 packages/svg-clock/svg-clock.el | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/packages/svg-clock/svg-clock.el b/packages/svg-clock/svg-clock.el
index bf0147cf6..922ebdce8 100644
--- a/packages/svg-clock/svg-clock.el
+++ b/packages/svg-clock/svg-clock.el
@@ -115,6 +115,15 @@ and `hour-hand'.  The clock-face has a size of 1x1."
                                                 'rotate angle .5 .5)))
                               (number-sequence 0 354 6))))))
 
+(defun svg-clock--def (svg def)
+  (dom-append-child
+   (or (dom-by-tag svg 'defs)
+       (let ((node (dom-node 'defs)))
+	 (dom-add-child-before svg node)
+	 node))
+   def)
+  svg)
+
 (defun svg-clock--create-svg (time size foreground background)
   "Return an SVG element displaying an analog clock.
 The clock shows the given TIME, it has a diameter of SIZE, and
@@ -140,8 +149,8 @@ its colors are FOREGROUND and BACKGROUND."
                                 (svg-clock-transform
                                  'rotate
                                  (+ (* hours 30) (/ minutes 2.0))  .5 .5)))))
-    (dolist (def defs) (svg-def svg def))
-    (svg-def svg clock)
+    (dolist (def defs) (svg-clock--def svg def))
+    (svg-clock--def svg clock)
     (dom-append-child svg
                       (svg-clock-use 'clock
                                      (svg-clock-transform 'scale size size)))
-- 
2.20.1

bug#36414: 27.0.50; svg-clock does not work anymore

[Dieter Deyke]

Pip Cet <pipcet@gmail.com> writes:

> On Fri, Jun 28, 2019 at 5:29 AM Dieter Deyke <dieter.deyke@gmail.com> wrote:
>> Executing (svg-clock) from elpa does not show the clock anymore, but just the
>> single char '*'.
>
> Sorry for barging in, I thought this might be related to the recent
> image.c changes so I had a look.
>
> svg-clock.el uses `svg-def', which is now an internal function,
> `svg--def'. I believe Lars is the one working on this.
>
> Can you try the attached patch to see whether that is indeed the problem?

Thanks,

your patch works perfectly.

Thanks again,
-- 
Dieter Deyke
mailto:dieter.deyke@gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

bug#36414: 27.0.50; svg-clock does not work anymore

[Michael Heerdegen]

Pip Cet <pipcet@gmail.com> writes:

> Sorry for barging in, I thought this might be related to the recent
> image.c changes so I had a look.
>
> svg-clock.el uses `svg-def', which is now an internal function,
> `svg--def'. I believe Lars is the one working on this.

BTW, slime-volleyball is also (a bit) broken for me, for quite a time:
the slimes have no bodies, only their eyes are displayed.  If one of you
is able to fix is, that would be great, because slime-volleyball is one
of the very cool things that someone did with Emacs.

Michael.

bug#36414: 27.0.50; svg-clock does not work anymore

[Pip Cet]

On Sun, Jun 30, 2019 at 9:37 PM Michael Heerdegen
<michael_heerdegen@web.de> wrote:
> BTW, slime-volleyball is also (a bit) broken for me, for quite a time:
> the slimes have no bodies, only their eyes are displayed.  If one of you
> is able to fix is, that would be great, because slime-volleyball is one
> of the very cool things that someone did with Emacs.

https://github.com/fitzsim/slime-volleyball/pull/6 fixes it here. Does
that work for you?

bug#36414: 27.0.50; svg-clock does not work anymore

[Michael Heerdegen]

Pip Cet <pipcet@gmail.com> writes:

> https://github.com/fitzsim/slime-volleyball/pull/6 fixes it here. Does
> that work for you?

Yes!  Looking forward for this fix landing in Gnu Elpa.


Thanks,

Michael.

bug#36414: 27.0.50; svg-clock does not work anymore

[Stefan Kangas]

tags 36414 + patch
thanks

Dieter Deyke <dieter.deyke@gmail.com> writes:

> Pip Cet <pipcet@gmail.com> writes:
>
>> On Fri, Jun 28, 2019 at 5:29 AM Dieter Deyke <dieter.deyke@gmail.com> wrote:
>>> Executing (svg-clock) from elpa does not show the clock anymore, but just the
>>> single char '*'.
>>
>> Sorry for barging in, I thought this might be related to the recent
>> image.c changes so I had a look.
>>
>> svg-clock.el uses `svg-def', which is now an internal function,
>> `svg--def'. I believe Lars is the one working on this.
>>
>> Can you try the attached patch to see whether that is indeed the problem?
>
> Thanks,
>
> your patch works perfectly.

This patch seems to have fixed the problem, but AFAICT it was never
installed.

Should it be installed, or is there some reason not to?  Thanks.

Best regards,
Stefan Kangas

bug#36414: 27.0.50; svg-clock does not work anymore

[Dieter Deyke]

Stefan Kangas <stefan@marxist.se> writes:

> tags 36414 + patch
> thanks
>
> Dieter Deyke <dieter.deyke@gmail.com> writes:
>
>> Pip Cet <pipcet@gmail.com> writes:
>>
>>> On Fri, Jun 28, 2019 at 5:29 AM Dieter Deyke <dieter.deyke@gmail.com> wrote:
>>>> Executing (svg-clock) from elpa does not show the clock anymore, but just the
>>>> single char '*'.
>>>
>>> Sorry for barging in, I thought this might be related to the recent
>>> image.c changes so I had a look.
>>>
>>> svg-clock.el uses `svg-def', which is now an internal function,
>>> `svg--def'. I believe Lars is the one working on this.
>>>
>>> Can you try the attached patch to see whether that is indeed the problem?
>>
>> Thanks,
>>
>> your patch works perfectly.
>
> This patch seems to have fixed the problem, but AFAICT it was never
> installed.
>
> Should it be installed, or is there some reason not to?  Thanks.
>
> Best regards,
> Stefan Kangas

I see no reason why it should not be installed.

-- 
Dieter Deyke
mailto:dieter.deyke@gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

bug#36414: 27.0.50; svg-clock does not work anymore

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 18 Aug 2020 11:21:00 +0000
> Cc: larsi@gnus.org, 36414@debbugs.gnu.org, Pip Cet <pipcet@gmail.com>
> 
> This patch seems to have fixed the problem, but AFAICT it was never
> installed.
> 
> Should it be installed, or is there some reason not to?  Thanks.

I see no reason why not to install it.

bug#36414: 27.0.50; svg-clock does not work anymore

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> This patch seems to have fixed the problem, but AFAICT it was never
> installed.
>
> Should it be installed, or is there some reason not to?  Thanks.

Sorry; just slipped out of my queue.  I've now applied the patch.  Oh, I
should bump the version, too...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#36414: 27.0.50; svg-clock does not work anymore

[Stephen Berman]

On Tue, 18 Aug 2020 14:35:59 +0200 Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Stefan Kangas <stefan@marxist.se> writes:
>
>> This patch seems to have fixed the problem, but AFAICT it was never
>> installed.
>>
>> Should it be installed, or is there some reason not to?  Thanks.
>
> Sorry; just slipped out of my queue.  I've now applied the patch.  Oh, I
> should bump the version, too...

Didn't you already fix this in the ELPA repo with commit
a52b4832ccf76b4e4332fefa225f21cc26de25c6:

Author:     Lars Ingebrigtsen <larsi@gnus.org>
AuthorDate: Mon Nov 4 20:02:47 2019 +0100
Commit:     Lars Ingebrigtsen <larsi@gnus.org>
CommitDate: Mon Nov 4 20:02:47 2019 +0100

  There's no longer an svg-def function in svg.el

which add the defun svg-clock-def.  And indeed, version 1.1 does work
here.

Steve Berman

bug#36414: 27.0.50; svg-clock does not work anymore

[Lars Ingebrigtsen]

Stephen Berman <stephen.berman@gmx.net> writes:

> Didn't you already fix this in the ELPA repo with commit
> a52b4832ccf76b4e4332fefa225f21cc26de25c6:
>
> Author:     Lars Ingebrigtsen <larsi@gnus.org>
> AuthorDate: Mon Nov 4 20:02:47 2019 +0100
> Commit:     Lars Ingebrigtsen <larsi@gnus.org>
> CommitDate: Mon Nov 4 20:02:47 2019 +0100
>
>   There's no longer an svg-def function in svg.el
>
> which add the defun svg-clock-def.  And indeed, version 1.1 does work
> here.

D'oh.  Indeed; thanks.  I've now reverted the double-fix patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no