From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#29541: 27.0.50; Use generic function when restoring eieio-persistent, remove validation Date: Fri, 28 Aug 2020 16:18:04 +0200 Message-ID: <87a6yevopv.fsf@gnus.org> References: <87shcsisdc.fsf@ericabrahamsen.net> <875z9q38bz.fsf@gnus.org> <87zh6feed2.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5263"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 29541@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 28 16:19:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBfDj-0001Ht-SY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 16:19:11 +0200 Original-Received: from localhost ([::1]:47226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBfDi-0007Vp-O1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Aug 2020 10:19:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBfDa-0007Ug-Jj for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBfDa-0004x4-9u for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBfDa-000341-5O for bug-gnu-emacs@gnu.org; Fri, 28 Aug 2020 10:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Aug 2020 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29541-submit@debbugs.gnu.org id=B29541.159862429611708 (code B ref 29541); Fri, 28 Aug 2020 14:19:02 +0000 Original-Received: (at 29541) by debbugs.gnu.org; 28 Aug 2020 14:18:16 +0000 Original-Received: from localhost ([127.0.0.1]:47051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBfCq-00032m-Bn for submit@debbugs.gnu.org; Fri, 28 Aug 2020 10:18:16 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBfCo-00032Y-TW for 29541@debbugs.gnu.org; Fri, 28 Aug 2020 10:18:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bBZ1qDULbbUnzdpxNzpQqURMjrQmDihuxl++/IxTNlo=; b=ZebcTErms+0pXZfyP8xSrspCm6 3RJur8Z8Q95m4kPxRmsScjJAPRB3GXPP8juLBK9HD5tZI+s14DFDG9Y60OIHBXitYGOSX3gw4HA/K Z5UBcsXRphyG9g8RAeMQNftaZ8TM3H1hTg3fljdLJ2FI4xbKWRBmzaf87BkoC4l+lcEs=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBfCf-00031u-JF; Fri, 28 Aug 2020 16:18:08 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWpuctxj8g9R1r/ //8QJ8S9AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QIHA4FDBXhxbYAAAFlSURBVCjPTZIxj9swDIUf jVMGTyrQ3JCps38FPWS5yQHMAPXcpf4V7trJGW73kBxs/so+ykXuOAj6RIl8TxIgZh2ecTTkT+jT Z8rMdF8FZNj2hPYc3B/AsG3gWrVB3GfUExNVzIIXQl37HgWqMh19FuA0/Xh118Y7Aw5LSqaHzrXl 0Q0Xa5dqLc3G6Tt+ymkOMVrfRebMbkdodP0l9R2UmxR+0zxqsnBzGe5yWJGo85vZFXmcIcWNzFI5 zb4EJOTmbeqtDRjb6uGPYtfMl8b/3s49bRM+3D8WBWsT3JMvOa4s4I5mTQF6pK00uKgZdw4b+/qk YkyWGKcsccbsbHZaXpACWuKw7tqMj2LXtXk/o8hIlpyuCB21Ghvc+lKg4zj4e1cOMdde3XKBEmz9 nEd8hb2AfMko5Anxruh0h/+fQGjb/c/+C/iABLoG77DyLcBDasbrA2vjzh9w7CAt3mKf6G/WvPwD bX2cIoGJqjYAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDgtMjhUMTQ6MDU6MTIrMDA6MDBCuCXs AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA4LTI4VDE0OjA1OjEyKzAwOjAwM+WdUAAAAABJRU5E rkJggg== X-Now-Playing: Mike Oldfield's _Tubular Bells (1)_: "Tubular Bells Part Two" In-Reply-To: <87zh6feed2.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 27 Aug 2020 18:41:29 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186610 Archived-At: Eric Abrahamsen writes: > This was quite a while ago, and the original patch no longer applies. > I've done up the same changes as two separate patches: one removing > extra validation, and the other creating a generic function for > constructing eieio-persistent objects. All the tests pass. I've just skimmed the code, but it looks good to me. I'd say just apply it and then see whether there is any fallout (but I don't expect there to be). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no