From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21465: [PATCH] CC-modes hierarchy Date: Mon, 07 Sep 2020 18:52:00 +0200 Message-ID: <87a6y15y33.fsf@gnus.org> References: <20150914193349.13729.qmail@mail.muc.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31732"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Alan Mackenzie , 21465@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 18:53:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFKOD-00088L-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 18:53:09 +0200 Original-Received: from localhost ([::1]:40186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFKOC-0003WZ-D4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 12:53:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFKO5-0003WK-Up for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 12:53:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFKO5-0001cC-MQ; Mon, 07 Sep 2020 12:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFKO5-0005oa-Iu; Mon, 07 Sep 2020 12:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Mon, 07 Sep 2020 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21465 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 21465-submit@debbugs.gnu.org id=B21465.159949753122289 (code B ref 21465); Mon, 07 Sep 2020 16:53:01 +0000 Original-Received: (at 21465) by debbugs.gnu.org; 7 Sep 2020 16:52:11 +0000 Original-Received: from localhost ([127.0.0.1]:50642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKNH-0005nR-JK for submit@debbugs.gnu.org; Mon, 07 Sep 2020 12:52:11 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKNG-0005nC-Bp for 21465@debbugs.gnu.org; Mon, 07 Sep 2020 12:52:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XE97nlNU0R6RMQeKMzBdq+KqqLdvSTHUQc4UFb33f8M=; b=b4mOSGoIrGOu2wZWQp5l49FND4 AHnXvHFwCqbTfOzzOipM5EkMRqqvBdj5pcK+LdjiItz7vWTHuDlVcMsa6IgI6AIq7iR7q8o0SRPKT reFU69AoEounwr+6y9T+m39/40JeLfPIbGC5Fgu1PH1jlUsNOzDt12XXhgmpOpkoVtVk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFKN7-0001U9-DA; Mon, 07 Sep 2020 18:52:03 +0200 X-Now-Playing: Coil's _A Prison of Measured Time_: "Wir Clk Wir (A Deeply Disturbed Passing Mix)" In-Reply-To: (Stefan Monnier's message of "Fri, 09 Oct 2015 16:49:19 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187456 Archived-At: Stefan Monnier writes: > You already have this layer, with c-mode-common-hook and > c-mode-base-map. My patch just makes this layering more standard and > then takes advantage of it to share some code. > > Here's another version of the patch with the following changes: > - Got rid of c-derivative-mode (which I still use at other places in my > local patches, but for now, I won't push for it any more). > - Keep c-make-inherited-keymap for backward compatibility. > - Fix the "c-mode-hook is run twice" bug, using the same hack as is used > by define-globalized-minor-mode. > The third point also makes the c-mode-common "extra layer" more useful > since that hack is added in there. > > Any objections to this version? This was four years ago, and there apparently wasn't any response here? Alan? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no