From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode Date: Sun, 04 Oct 2020 22:31:09 +0300 Message-ID: <87a6x4wxbm.fsf@linkov.net> References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7129"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41633@debbugs.gnu.org, joaotavora@gmail.com To: Andrew Schwartzmeyer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 04 21:47:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP9z5-0001lm-2A for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 21:47:51 +0200 Original-Received: from localhost ([::1]:33850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP9z4-0007Sq-0U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 15:47:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP9yJ-0006x7-7S for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 15:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kP9yI-0002rS-T6 for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 15:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kP9yI-0002Mo-SJ for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 15:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Oct 2020 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 41633-submit@debbugs.gnu.org id=B41633.16018407979040 (code B ref 41633); Sun, 04 Oct 2020 19:47:02 +0000 Original-Received: (at 41633) by debbugs.gnu.org; 4 Oct 2020 19:46:37 +0000 Original-Received: from localhost ([127.0.0.1]:46826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP9xs-0002Lj-Rl for submit@debbugs.gnu.org; Sun, 04 Oct 2020 15:46:37 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:46853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP9xq-0002LR-LO; Sun, 04 Oct 2020 15:46:35 -0400 Original-Received: from mail.gandi.net (m91-129-108-13.cust.tele2.ee [91.129.108.13]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id CE6B1100002; Sun, 4 Oct 2020 19:46:25 +0000 (UTC) In-Reply-To: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> (Andrew Schwartzmeyer's message of "Sun, 31 May 2020 12:37:29 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189768 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit reopen 41633 quit > For two, the check for ido-mode is actually broken, but I don’t yet know > how to fix it. It does (eq read-buffer-function #'ido-read-buffer), but > actually nowadays (maybe this was different in the past), ido-mode doesn’t > set read-buffer-function, unless you call ido-everywhere, and then it still > doesn’t set it but overrides it with an advice, so that its value is > #f(advice-wrapper :override nil ido-read-buffer), and this fails the > eq test. > > Anyway, I’d suggest applying this patch for now, and then figuring out > how to fix the check for ido. I confirm it doesn't work with ido-everywhere. Maybe this is a better condition? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=ido-everywhere.patch diff --git a/lisp/replace.el b/lisp/replace.el index 4883ecfc8f..b717a2a25c 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -1588,7 +1588,7 @@ multi-occur--prompt (concat "Next buffer to search " (cond - ((eq read-buffer-function #'ido-read-buffer) + ((bound-and-true-p ido-everywhere) (substitute-command-keys "(\\\\[ido-select-text] to end): ")) ((bound-and-true-p fido-mode) --=-=-=--