From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kevin Foley <kevin@kevinjfoley.me>
Cc: Stefan Kangas <stefan@marxist.se>, 44202@debbugs.gnu.org
Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer
Date: Sun, 25 Oct 2020 17:50:51 +0100 [thread overview]
Message-ID: <87a6wa8d1w.fsf@gnus.org> (raw)
In-Reply-To: <m2h7qil5vr.fsf@Kevins-MBP.home.lan> (Kevin Foley's message of "Sun, 25 Oct 2020 10:47:20 -0400")
Kevin Foley <kevin@kevinjfoley.me> writes:
> I was trying to match the noconfirm argument of the revert function but
> I agree, `help-mode-revert-buffer-confirm' is less confusing.
>
> I've attached an updated patch.
Thanks.
Looking at the code a bit more, I found it a bit odd that there'd be a
need for this since there are other mechanisms to control this in
general -- revert-without-query, in particular:
---
Optional second argument NOCONFIRM means don't ask for confirmation
at all. (The variable `revert-without-query' offers another way to
revert buffers without querying for confirmation.)
---
But the problem is that revert-buffer calls help-mode-revert-buffer,
which doesn't heed that variable.
Now, the documentation for revert-without-query says that it's about
reverting files, so on one level that makes sense since the help buffers
don't visit files.
But... I think it would be helpful if help-mode-revert-buffer (and
other similar functions) did heed that variable -- then there'd be one
simple way to control all this. Or even perhaps have revert-buffer look
at that variable and do the right thing instead of punting to
revert-buffer--default.
That is, it would look at file names for buffers visiting files, and
buffer names for other buffers.
Any opinions?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-10-25 16:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 20:25 bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Kevin Foley
2020-10-24 23:40 ` Drew Adams
2020-10-25 0:01 ` Stefan Kangas
2020-10-25 13:39 ` Kevin Foley
2020-10-25 13:50 ` Lars Ingebrigtsen
2020-10-25 14:47 ` Kevin Foley
2020-10-25 16:50 ` Lars Ingebrigtsen [this message]
2020-10-25 18:42 ` Stefan Kangas
2020-10-25 20:08 ` Kevin Foley
2020-10-26 10:22 ` Lars Ingebrigtsen
2020-10-26 14:59 ` Stefan Kangas
2020-10-26 22:05 ` Kevin Foley
2020-10-27 7:27 ` Lars Ingebrigtsen
2020-11-17 13:04 ` Stefan Kangas
2020-11-24 5:26 ` Lars Ingebrigtsen
2020-11-24 15:57 ` Stefan Kangas
2020-11-25 7:01 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6wa8d1w.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=44202@debbugs.gnu.org \
--cc=kevin@kevinjfoley.me \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.