From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#15667: 24.3.50; ns-win.el -- keymap assignments for isearch-repeat-backward/forward. Date: Wed, 20 Jan 2021 03:42:50 +0100 Message-ID: <87a6t45nx1.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4893"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Alan Third , 15667@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 20 03:44:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l23Te-00019y-EU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Jan 2021 03:44:10 +0100 Original-Received: from localhost ([::1]:50980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l23Td-0005RG-Gj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 21:44:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l23TW-0005PQ-L9 for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 21:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l23TW-0002S0-EL for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 21:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l23TW-000593-Ck for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 21:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jan 2021 02:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15667 X-GNU-PR-Package: emacs Original-Received: via spool by 15667-submit@debbugs.gnu.org id=B15667.161111058219697 (code B ref 15667); Wed, 20 Jan 2021 02:44:02 +0000 Original-Received: (at 15667) by debbugs.gnu.org; 20 Jan 2021 02:43:02 +0000 Original-Received: from localhost ([127.0.0.1]:52308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l23SY-00057T-4T for submit@debbugs.gnu.org; Tue, 19 Jan 2021 21:43:02 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:39254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l23SW-000578-V4 for 15667@debbugs.gnu.org; Tue, 19 Jan 2021 21:43:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qlV5B8VvnJRjuQ883LcTArnhcCf2bJkKjxhfiubC7Ik=; b=cQViuMQ8k8E3BLWD/X9amiiu03 0OFDpe/z2DbnQC43RdT1pdIzUw9llYGhk2QIh2t6fQu35k5efrwni7zryPd6cNEvB9/GJxWCrzlD9 lZt4B+WUf0Zmm8wMISvdo7fE3ADAegHIxHzMHjW9qkhLQVOlHQuJvE7mrwj4qhOW79cM=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l23SN-0008CN-R0; Wed, 20 Jan 2021 03:42:54 +0100 X-Now-Playing: Prince Nico Mbarga And Rocafil Jazz's _Nigeria 70 (No Wahala: Highlife, Afro-Funk & Juju 1973-1987)_: "Sickness" In-Reply-To: (Keith David Bershatsky's message of "Sun, 20 Oct 2013 17:02:02 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198229 Archived-At: Keith David Bershatsky writes: > The global-map key assignments within ns-win.el for > isearch-repeat-backward and isearch-repeat-forward are insufficient to > achieve the behavior contemplated by the source code of isearch.el. > Specifically, the isearch-mode terminates immediately after invoking > the repeat functions and the sticky highlight of searches found does > not automatically cleanup. Invoking these repeat functions should > keep isearch-mode active, and then sticky highlight should > automatically clean up when exiting the isearch (e.g., by pressing the > return key after the search). The problem is corrected by the > following keymap assignments, which mirrors the usage within the > source code of isearch.el > > (define-key global-map [?\s-f] 'isearch-forward) > (define-key esc-map [?\s-f] 'isearch-forward-regexp) > (define-key minibuffer-local-isearch-map [?\s-f] 'isearch-forward-exit-minibuffer) > (define-key isearch-mode-map [?\s-f] 'isearch-repeat-forward) > > (define-key global-map [?\s-F] 'isearch-backward) > (define-key esc-map [?\s-F] 'isearch-backward-regexp) > (define-key minibuffer-local-isearch-map [?\s-F] 'isearch-reverse-exit-minibuffer) > (define-key isearch-mode-map [?\s-F] 'isearch-repeat-backward) (I'm going through old bug reports that unfortunately got no response at the time.) I don't really use the Emacs on Macos much, but perhaps Alan has an opinion here? Added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no