From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46151: 28.0.50; Set revert-buffer-function in shell command output buffers Date: Fri, 29 Jan 2021 08:21:39 +0100 Message-ID: <87a6ssus1o.fsf@gnus.org> References: <87lfcdd1he.fsf@melete.silentflame.com> <87im7gward.fsf@gnus.org> <87wnvwte7y.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19046"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46151@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 29 08:22:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5O6q-0004oX-RS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jan 2021 08:22:24 +0100 Original-Received: from localhost ([::1]:59854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5O6p-0002TJ-Kc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jan 2021 02:22:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5O6U-0002S8-Qr for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 02:22:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39496) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5O6U-0005i2-9u for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 02:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l5O6U-0000gy-3K for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 02:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jan 2021 07:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46151-submit@debbugs.gnu.org id=B46151.16119049152643 (code B ref 46151); Fri, 29 Jan 2021 07:22:02 +0000 Original-Received: (at 46151) by debbugs.gnu.org; 29 Jan 2021 07:21:55 +0000 Original-Received: from localhost ([127.0.0.1]:51042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5O6M-0000gZ-Qb for submit@debbugs.gnu.org; Fri, 29 Jan 2021 02:21:55 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:42528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5O6H-0000gI-QF for 46151@debbugs.gnu.org; Fri, 29 Jan 2021 02:21:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Z52trkCZs3yLLsJDe7KbauCEy28l0a0URMfHgAL33g=; b=E4yU6qvEWS8rX/3l6BwiM8IDfe sPJqlZgVYmfhDv3Y6Dh65aaqWjVIswv7DCCUYOPcaAzvlkF1stmmGaVp/weLxNdrk9FCxpkuOAkLl IPmV+uzYbsd45+8X9kthGEfc7B6Y88EiGYf9qFLNIYk1A2VCkb2R8F6fNYQTvZH+VUes=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5O69-0000YP-06; Fri, 29 Jan 2021 08:21:43 +0100 X-Now-Playing: Black Stereo Faith's _Black Stereo Faith_: "Tears" In-Reply-To: <87wnvwte7y.fsf@melete.silentflame.com> (Sean Whitton's message of "Fri, 29 Jan 2021 00:05:37 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198854 Archived-At: Sean Whitton writes: > I realised that my patch needs to setq-local not just setq. Indeed, my > previous patch breaks revert-buffer once you've run a shell command... > > Attached is a fix. Heh, that explains why my Emacs was behaving so oddly. :-) Fix now pushed. >> Would it make sense to just define a tiny mode that just defines the `g' >> command to revert and use that in these buffers? > > For M-!, yes, that would be useful and simple. > > For M-&, the mode would need to be activated only once the command had > finished running, as otherwise 'g' should be sent to the inferior > process. Not hard to do that either. > > I take it a minor mode is more appropriate than a major mode for this? > If so, I can come up with a patch adding that to simple.el. Since M-! and M-& use different modes (fundamental and shell), a minor mode is probably the best, I guess. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no