From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. Date: Sun, 07 Feb 2021 21:05:12 +0200 Organization: LINKOV.NET Message-ID: <87a6sfu0fi.fsf@mail.linkov.net> References: <871rdv4xog.fsf@gmail.com> <87k0rmnbqs.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38378"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 46299@debbugs.gnu.org To: Bastian Beranek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 07 20:50:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8q4v-0009t4-3R for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Feb 2021 20:50:41 +0100 Original-Received: from localhost ([::1]:59094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8q4u-0001bk-4i for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Feb 2021 14:50:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8q4I-0001am-5N for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 14:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8q4H-0000ep-Mi for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 14:50:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8q4H-0001jm-Ks for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2021 14:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2021 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46299 X-GNU-PR-Package: emacs Original-Received: via spool by 46299-submit@debbugs.gnu.org id=B46299.16127273436584 (code B ref 46299); Sun, 07 Feb 2021 19:50:01 +0000 Original-Received: (at 46299) by debbugs.gnu.org; 7 Feb 2021 19:49:03 +0000 Original-Received: from localhost ([127.0.0.1]:48893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8q3K-0001i3-NQ for submit@debbugs.gnu.org; Sun, 07 Feb 2021 14:49:03 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:49781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8q3H-0001gx-DD for 46299@debbugs.gnu.org; Sun, 07 Feb 2021 14:49:00 -0500 X-Originating-IP: 91.129.108.204 Original-Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 30BE11C0009; Sun, 7 Feb 2021 19:48:52 +0000 (UTC) In-Reply-To: (Bastian Beranek's message of "Sat, 6 Feb 2021 13:16:54 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199557 Archived-At: > I added code to make the frame setting of tab-bar-lines as well as the > default-frame-alist value dependent on tab-bar-show to the > tab-bar-mode function. > I think with this the part to which sets frame parameters in > tab-bar-show :set is not needed because (tab-bar-mode 1) is called > anyway, which already does everything. > > What do you think about the attached patch? I think your earlier idea was better - to have a dynamic function which counts the numbers of tabs and adapts the number of tab-bar-lines according to the value of tab-bar-show. Then such a function could be called from many places: - tab-bar-mode - tab-bar-show :set - from the end of tab-bar-new-tab-to - from the end of tab-bar-close-tab - from the end of tab-bar-close-other-tabs to sync the actual tabs with the value of tab-bar-show.