all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)]
Date: Mon, 26 Apr 2021 14:51:36 +0200	[thread overview]
Message-ID: <87a6plus2v.fsf@gnu.org> (raw)
In-Reply-To: <87y2d5mde2.fsf@gmail.com> (No Wayman's message of "Mon, 26 Apr 2021 08:32:54 -0400")

Hi,

thanks for the patch, we do indeed need to move forward for this.

Could you propose the patch against the master branch (not the maint
branch, since this is not a bugfix) and perhaps fix *all* warnings?

Also, here the preferred format for the commit message:

* lisp/org-table.el (org-table-header-line-mode)
(org-table-follow-field-mode): Migrate minor mode
definitions from positional arguments to keyword args.

* lisp/org-src.el (org-src-mode): Ditto.

* lisp/org-list.el (org-list-checkbox-radio-mode): Ditto.

Don't worry too much about it, I can always rearrange it.

Thanks!


  reply	other threads:[~2021-04-26 12:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 12:32 Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)] No Wayman
2021-04-26 12:51 ` Bastien [this message]
2021-04-26 22:50   ` Kyle Meyer
2021-04-27  5:13     ` Bastien
2021-04-27 12:28     ` No Wayman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6plus2v.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=iarchivedmywholelife@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.