all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Joseph Mingrone <jrm@ftfl.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master e7f6bb3 1/2: Rework gnus-search-indexed-parse-output
Date: Fri, 30 Jul 2021 09:25:32 -0700	[thread overview]
Message-ID: <87a6m3vkeb.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <865ywspq8l.fsf@phe.ftfl.ca> (Joseph Mingrone's message of "Thu,  29 Jul 2021 22:03:38 -0300")

Joseph Mingrone <jrm@ftfl.ca> writes:

> Hello Eric,
>
> After this change, searching for messages with (nnml . notmuch) as part
> of the value of `gnus-search-default-engines' always returns 0 results.
> The search results look good in the previous commit, 0897ade8f9.
>
> Are there any results that I can share to help debug this?

Yes, this is almost certainly a problem that's been reported, with the
below fix. Would you try this and let me know if it solves your situation?

1 file changed, 1 insertion(+), 1 deletion(-)
lisp/gnus/gnus-search.el | 2 +-

modified   lisp/gnus/gnus-search.el
@@ -1384,7 +1384,6 @@ gnus-search-indexed-parse-output
                    nil t)
 	          nil t)
 	         nil t))
-          (setq group (gnus-group-full-name group server))
           (setq article (file-name-nondirectory f-name)
                 article
                 ;; TODO: Provide a cleaner way of producing final
@@ -1394,6 +1393,7 @@ gnus-search-indexed-parse-output
 		  (nnmaildir-base-name-to-article-number
 		   (substring article 0 (string-match ":" article))
 		   group (string-remove-prefix "nnmaildir:" server))))
+          (setq group (gnus-group-full-name group server))
           (when (and (numberp article)
                      (or (null groups)
                          (member group groups)))



  reply	other threads:[~2021-07-30 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210711032250.31847.28300@vcs0.savannah.gnu.org>
     [not found] ` <20210711032252.A2F662112E@vcs0.savannah.gnu.org>
2021-07-30  1:03   ` master e7f6bb3 1/2: Rework gnus-search-indexed-parse-output Joseph Mingrone
2021-07-30 16:25     ` Eric Abrahamsen [this message]
2021-07-30 19:22       ` Joseph Mingrone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6m3vkeb.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    --cc=jrm@ftfl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.