From: Philip Kaludercic <philipk@posteo.net>
To: Juri Linkov <juri@linkov.net>
Cc: 50552@debbugs.gnu.org
Subject: bug#50552: 28.0.50; Add context-menu-occur
Date: Sun, 12 Sep 2021 19:09:25 +0000 [thread overview]
Message-ID: <87a6khd316.fsf@posteo.net> (raw)
In-Reply-To: <87o88xu13p.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 12 Sep 2021 20:59:06 +0300")
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
Juri Linkov <juri@linkov.net> writes:
>> the below patch adds the commands occur-word-at-mouse and
>> occur-symbol-at-mouse, and a function for context-menu-mode to occur
>> words or symbols where the context menu was invoked.
>>
>> Would there be any interest in adding such a functionality?
>
> Thanks. There is a new function 'thing-at-mouse' with a new arg 'click'
> added today that you can use instead of 'thing-at-point'.
> You can see an example in lisp/net/dictionary.el.
I see, but I wonder why dictionary.el directly manipulates
context-menu-functions with add-hook.
>> diff --git a/lisp/mouse.el b/lisp/mouse.el
>> index 7d3ed9a0e4..3590e27e3e 100644
>> --- a/lisp/mouse.el
>> +++ b/lisp/mouse.el
>>[...]
>> +(defun context-menu-occur (menu)
>
> The default set of context menus in mouse.el contains only menus
> created from the existing non-context menus. All new context menus
> should be added to their respective packages. So please move
> context-menu-occur to replace.el.
>
> Another example prog-context-menu in lisp/progmodes/prog-mode.el also
> demonstrates how context menus should belong to the package where they
> are used. And prog-context-menu is similar to context-menu-occur,
> so it should have the name prefix of the package: occur-context-menu.
Ok, no problem. This should do it:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-occur-related-context-menu-operations.patch --]
[-- Type: text/x-diff, Size: 1747 bytes --]
From 77c080476a6e64ab9ae5717e75c2358d3e8d20a7 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Sun, 12 Sep 2021 21:02:46 +0200
Subject: [PATCH] Add occur-related context-menu operations
* replace.el (occur-word-at-mouse): Add new command
(occur-symbol-at-mouse): Add new command
(occur-context-menu): Add new function
---
lisp/replace.el | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/lisp/replace.el b/lisp/replace.el
index 69bdfe1331..e8ca3fac80 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -2367,6 +2367,31 @@ occur-context-lines
;; And the second element is the list of context after-lines.
(if (> nlines 0) after-lines))))
+(defun occur-word-at-mouse (event)
+ "Display an occur buffer for the word at EVENT."
+ (interactive "e")
+ (occur (thing-at-mouse event 'word t)))
+
+(defun occur-symbol-at-mouse (event)
+ "Display an occur buffer for the symbol at EVENT."
+ (interactive "e")
+ (occur (thing-at-mouse event 'symbol t)))
+
+(defun occur-context-menu (menu click)
+ "Populate MENU with occur commands for CLICK.
+To be added to `context-menu-functions'."
+ (let ((word (thing-at-mouse click 'word))
+ (sym (thing-at-mouse click 'symbol)))
+ (when (or word sym)
+ (define-key-after menu [occur-separator] menu-bar-separator)
+ (when word
+ (define-key-after menu [occur-word-at-mouse]
+ '(menu-item "Occur Word" occur-word-at-mouse)))
+ (when sym
+ (define-key-after menu [occur-symbol-at-mouse]
+ '(menu-item "Occur Symbol" occur-symbol-at-mouse)))))
+ menu)
+
\f
;; It would be nice to use \\[...], but there is no reasonable way
;; to make that display both SPC and Y.
--
2.30.2
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
To keep in line with prog-context-menu and context-menu-dictionary, I
also removed the modification of context-menu-functions's :type.
--
Philip Kaludercic
next prev parent reply other threads:[~2021-09-12 19:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 16:54 bug#50552: 28.0.50; Add context-menu-occur Philip Kaludercic
2021-09-12 17:59 ` Juri Linkov
2021-09-12 19:09 ` Philip Kaludercic [this message]
2021-09-13 8:28 ` Juri Linkov
2021-09-14 20:45 ` Philip Kaludercic
2021-09-15 7:14 ` Juri Linkov
2021-09-28 20:00 ` Philip Kaludercic
2021-09-29 7:19 ` Juri Linkov
2021-09-29 10:00 ` Philip Kaludercic
2021-09-29 17:31 ` Juri Linkov
2021-10-02 19:29 ` Juri Linkov
2021-10-01 16:28 ` Philip Kaludercic
2021-10-02 19:25 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6khd316.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=50552@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.