From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] New tab-bar-detach-tab command Date: Wed, 29 Sep 2021 02:43:25 -0500 Message-ID: <87a6jvj082.fsf@alphapapa.net> References: <87h7e4ikkz.fsf@alphapapa.net> <87r1d8p4l5.fsf@mfa.pw> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11050"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 29 09:45:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVUHB-0002fr-8S for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 09:45:13 +0200 Original-Received: from localhost ([::1]:45992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVUH9-0004TQ-Az for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 03:45:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVUFk-0003bl-KD for emacs-devel@gnu.org; Wed, 29 Sep 2021 03:43:45 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:39940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVUFc-00013H-Dr for emacs-devel@gnu.org; Wed, 29 Sep 2021 03:43:44 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mVUFa-0000Vw-8L for emacs-devel@gnu.org; Wed, 29 Sep 2021 09:43:34 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275770 Archived-At: Matt Beshara writes: > Hi Adam (and others), > I missed this functionality from web browsers as well, but the > implementation you posted doesn’t work on my setup. The new tab > it creates in a new frame only contains one of the multiple > windows I had open in the original tab, and it gives me the > message “tab-close: Attempt to delete the sole tab in a frame”. > Below I’ve pasted another implementation I’ve been using for a > little while which I get better results with. > > #+BEGIN_SRC emacs-lisp > (defun tab-bar-move-tab-to-new-frame () > (interactive) > (let* ((from-frame (selected-frame)) > (from-tabs (funcall tab-bar-tabs-function from-frame)) > (from-index (1+ (tab-bar--current-tab-index from-tabs))) > (new-frame (make-frame))) > (tab-bar-move-tab-to-frame nil from-frame from-index new-frame > 1) > (select-frame new-frame) > (tab-bar-close-tab))) > #+END_SRC Hi Matt, Thanks, I should have noticed that. I've updated my patch, which I'll post in reply to Juri's message.