From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#43682: 28.0.50; Clean up nnimap server buffers? Date: Mon, 11 Oct 2021 07:41:47 -0700 Message-ID: <87a6jflj2s.fsf@ericabrahamsen.net> References: <87eemlh3ro.fsf@ericabrahamsen.net> <87d024bpqc.fsf@gnus.org> <87mu18qw3g.fsf@ericabrahamsen.net> <87k0wc9i4k.fsf@gnus.org> <87tuvfc4ur.fsf@ericabrahamsen.net> <87d022wx5y.fsf@gnus.org> <871rii7cso.fsf@ericabrahamsen.net> <87o8lmq6k4.fsf@gnus.org> <87sgax6eqb.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33513"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 43682@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 11 16:43:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZwWN-0008aZ-62 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 16:43:19 +0200 Original-Received: from localhost ([::1]:48308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZwWL-0007Sm-Qc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 10:43:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZwW6-0007SH-AM for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 10:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZwW6-0006G0-2E for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 10:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZwW5-0007Cd-W9 for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 10:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Oct 2021 14:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43682 X-GNU-PR-Package: emacs Original-Received: via spool by 43682-submit@debbugs.gnu.org id=B43682.163396332327615 (code B ref 43682); Mon, 11 Oct 2021 14:43:01 +0000 Original-Received: (at 43682) by debbugs.gnu.org; 11 Oct 2021 14:42:03 +0000 Original-Received: from localhost ([127.0.0.1]:60650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZwV8-0007BK-8A for submit@debbugs.gnu.org; Mon, 11 Oct 2021 10:42:03 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:41834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZwV1-0007Ac-T0 for 43682@debbugs.gnu.org; Mon, 11 Oct 2021 10:42:00 -0400 Original-Received: from localhost (c-71-197-232-156.hsd1.wa.comcast.net [71.197.232.156]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 110F3FA644; Mon, 11 Oct 2021 14:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1633963309; bh=l13G8aQ/H940QdTmplU6E+iqDJhgP7urTCJC7J0/oDg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MvMJb3GkI291APhQ/D4B66ebFoxCudxKxHLJm7isd8APDfm7ZMpBhN0pLuQg6qK00 0Mt2jqwe5boKhOQotXSBZ/nuC0J0unn5uQaukYMZmRTSB8aRf44BsPdK71tHBeBOQA ogt4rIB86353PBdZcwHrKSzqXqCK+v/cnhNJs6zw= In-Reply-To: (Stefan Kangas's message of "Mon, 11 Oct 2021 05:53:26 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216924 Archived-At: Stefan Kangas writes: > Eric Abrahamsen writes: > >> On 10/01/20 18:01 PM, Lars Ingebrigtsen wrote: >>> Eric Abrahamsen writes: >>> >>>> It's possible (I'm not claiming to understand all the code) that all we >>>> would need to do is fix `gnus-async-wait-for-article' to replace its >>>> calls to `nntp-find-connection' and `nntp-accept-process-output' with >>>> something generalized. Those two functions deal with directly with >>>> `nntp-connection-alist', so we'd need something that would do the >>>> equivalent with `nnimap-connection-alist'. >>> >>> Yup. >> >> This is something I wouldn't want to tackle until we have generic >> functions. >> >>>> Anyway, in the interest of completing this far less ambitious patch: if >>>> the nnimap connection has timed out, we should remove this connection >>>> from `nnimap-connection-alist', so this version of the patch does that. >>>> If async has opened a second connection, I guess we should leave that >>>> alone, though I don't have too much confidence that the whole process >>>> will recover gracefully from the main connection dying... >>> >>> Well, the connections are separate, and there's all kinds of reasons for >>> the server to close a connection, so... >>> >>>> + (unless (memq (process-status (get-buffer-process buffer)) >>>> + '(open run)) >>> >>> Aka `process-live-p'. >> >> I forgot we have that! >> >>> Otherwise looks fine to me (but I haven't tested the code). >> >> Okay, I'll run this for a bit, as well. > > Any news here? Should the fix be installed? Hmm, I found a couple of typos in it, then I ran it for a bit, then got distracted and backed it out in favor of something else, and then... I think it should be okay to push. I'll try a bit of explicit testing, then push later today. Thanks for the reminder!