* bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
@ 2021-10-11 21:17 Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11 21:49 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-10-11 21:17 UTC (permalink / raw)
To: 51139; +Cc: Dave Gillespie, Bill Wohler
[-- Attachment #1: Type: text/plain, Size: 1783 bytes --]
Severity: minor
Tags: patch
I see the following byte-compilation warnings in --without-x builds:
--8<---------------cut here---------------start------------->8---
In edmacro-fix-menu-commands:
edmacro.el:622:34: Warning: reference to free variable
‘mouse-wheel-down-event’
edmacro.el:622:57: Warning: reference to free variable ‘mouse-wheel-up-event’
edmacro.el:623:34: Warning: reference to free variable
‘mouse-wheel-right-event’
edmacro.el:624:34: Warning: reference to free variable
‘mouse-wheel-left-event’
In end of data:
mh-e/mh-compat.el:96:5: Warning: the function ‘image-search-load-path’ is not
known to be defined.
mh-e/mh-compat.el:93:5: Warning: the function ‘image-load-path-for-library’ is
not known to be defined.
In mh-logo-display:
mh-e/mh-utils.el:129:40: Warning: Unused lexical variable `image-load-path'
In mh-tool-bar-folder-buttons-init:
mh-e/mh-tool-bar.el:302:1: Warning: Unused lexical variable `image-load-path'
In mh-tool-bar-letter-buttons-init:
mh-e/mh-tool-bar.el:384:3: Warning: Unused lexical variable `image-load-path'
In end of data:
mh-e/mh-utils.el:128:24: Warning: the function ‘image-load-path-for-library’
is not known to be defined.
In end of data:
mh-e/mh-tool-bar.el:302:1: Warning: the function ‘image-load-path-for-library’
is not known to be defined.
--8<---------------cut here---------------end--------------->8---
The MH-E warnings are seen on master, whereas the edmacro ones are also
on emacs-28 (details of both configurations follow my signature).
I assume the warnings are not important enough to install anything on
emacs-28, so I attach a patch against master for both sets of warnings.
WDYT?
Thanks,
--
Basil
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-byte-compilation-warnings-in-nox-builds.patch --]
[-- Type: text/x-diff, Size: 5900 bytes --]
From 3b5b2a942f14d6512a848cf6cafa4d8a7d5610de Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Mon, 11 Oct 2021 19:14:23 +0100
Subject: [PATCH] Fix byte-compilation warnings in nox builds
* lisp/edmacro.el (edmacro-fix-menu-commands): Load mwheel to pacify
undefined variable warnings in without-x builds.
* lisp/mh-e/mh-compat.el: Declare image.el functions that are not
preloaded in without-x builds.
* lisp/mh-e/mh-utils.el (mh--with-image-load-path): New macro.
(mh-logo-display):
* lisp/mh-e/mh-tool-bar.el (mh-tool-bar-folder-buttons-init)
(mh-tool-bar-letter-buttons-init): Use it to pacify byte-compilation
warnings about image.el definitions not preloaded without-x.
---
lisp/edmacro.el | 6 ++++++
lisp/mh-e/mh-compat.el | 4 ++++
lisp/mh-e/mh-tool-bar.el | 12 ++----------
lisp/mh-e/mh-utils.el | 37 ++++++++++++++++++++++++-------------
4 files changed, 36 insertions(+), 23 deletions(-)
diff --git a/lisp/edmacro.el b/lisp/edmacro.el
index e90b3a006e..a4eb574a4c 100644
--- a/lisp/edmacro.el
+++ b/lisp/edmacro.el
@@ -604,6 +604,12 @@ edmacro-sanitize-for-string
(defun edmacro-fix-menu-commands (macro &optional noerror)
(if (vectorp macro)
(let (result)
+ ;; Not preloaded in without-x builds.
+ (require 'mwheel)
+ (defvar mouse-wheel-down-event)
+ (defvar mouse-wheel-left-event)
+ (defvar mouse-wheel-right-event)
+ (defvar mouse-wheel-up-event)
;; Make a list of the elements.
(setq macro (append macro nil))
(dolist (ev macro)
diff --git a/lisp/mh-e/mh-compat.el b/lisp/mh-e/mh-compat.el
index 659c4354b1..37a12de075 100644
--- a/lisp/mh-e/mh-compat.el
+++ b/lisp/mh-e/mh-compat.el
@@ -89,9 +89,13 @@ 'mh-face-background
(define-obsolete-function-alias 'mh-font-lock-add-keywords
#'font-lock-add-keywords "29.1")
+;; Not preloaded in without-x builds.
+(declare-function image-load-path-for-library "image")
(define-obsolete-function-alias 'mh-image-load-path-for-library
#'image-load-path-for-library "29.1")
+;; Not preloaded in without-x builds.
+(declare-function image-search-load-path "image")
(define-obsolete-function-alias 'mh-image-search-load-path
#'image-search-load-path "29.1")
diff --git a/lisp/mh-e/mh-tool-bar.el b/lisp/mh-e/mh-tool-bar.el
index 805408cfc7..d199cdb872 100644
--- a/lisp/mh-e/mh-tool-bar.el
+++ b/lisp/mh-e/mh-tool-bar.el
@@ -213,11 +213,7 @@ mh-tool-bar-define
;; Tool bar initialization functions
(defun mh-tool-bar-folder-buttons-init ()
(when (mh-buffer-exists-p 'mh-folder-mode)
- (let* ((load-path (image-load-path-for-library "mh-e"
- "mh-logo.xpm"))
- (image-load-path (cons (car load-path)
- (when (boundp 'image-load-path)
- image-load-path))))
+ (mh--with-image-load-path
(setq mh-folder-tool-bar-map
(let ((tool-bar-map (make-sparse-keymap)))
,@(nreverse folder-button-setter)
@@ -236,11 +232,7 @@ mh-tool-bar-define
tool-bar-map)))))
(defun mh-tool-bar-letter-buttons-init ()
(when (mh-buffer-exists-p 'mh-letter-mode)
- (let* ((load-path (image-load-path-for-library "mh-e"
- "mh-logo.xpm"))
- (image-load-path (cons (car load-path)
- (when (boundp 'image-load-path)
- image-load-path))))
+ (mh--with-image-load-path
(setq mh-letter-tool-bar-map
(let ((tool-bar-map (make-sparse-keymap)))
,@(nreverse letter-button-setter)
diff --git a/lisp/mh-e/mh-utils.el b/lisp/mh-e/mh-utils.el
index 93bc7f8d39..b64e6e49c1 100644
--- a/lisp/mh-e/mh-utils.el
+++ b/lisp/mh-e/mh-utils.el
@@ -119,24 +119,35 @@ mh-replace-string
;;; Logo Display
+;;;###mh-autoload
+(defmacro mh--with-image-load-path (&rest body)
+ "Load `image' and eval BODY with `image-load-path' set appropriately."
+ (declare (debug t) (indent 0))
+ `(mh-do-in-gnu-emacs
+ ;; Not preloaded in without-x builds.
+ (require 'image)
+ (defvar image-load-path)
+ (declare-function image-load-path-for-library "image")
+ (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm"))
+ (image-load-path (cons (car load-path)
+ (and (boundp 'image-load-path)
+ image-load-path))))
+ ,@body)))
+
(defvar mh-logo-cache nil)
;;;###mh-autoload
(defun mh-logo-display ()
"Modify mode line to display MH-E logo."
- (mh-do-in-gnu-emacs
- (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm"))
- (image-load-path (cons (car load-path)
- (when (boundp 'image-load-path)
- image-load-path))))
- (add-text-properties
- 0 2
- `(display ,(or mh-logo-cache
- (setq mh-logo-cache
- (mh-funcall-if-exists
- find-image '((:type xpm :ascent center
- :file "mh-logo.xpm"))))))
- (car mode-line-buffer-identification)))))
+ (mh--with-image-load-path
+ (add-text-properties
+ 0 2
+ `(display ,(or mh-logo-cache
+ (setq mh-logo-cache
+ (mh-funcall-if-exists
+ find-image '(( :type xpm :ascent center
+ :file "mh-logo.xpm" ))))))
+ (car mode-line-buffer-identification))))
\f
--
2.33.0
[-- Attachment #3: Type: text/plain, Size: 5135 bytes --]
In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
of 2021-10-11 built on tia
Repository revision: 2810fe6bfca182e4376d818b5510507d5ff7e1b5
Repository branch: master
System Description: Debian GNU/Linux bookworm/sid
Configured using:
'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
--prefix=/home/blc/.local --program-suffix=-nox
--enable-checking=structs --with-file-notification=yes
--with-x-toolkit=no --without-x'
Configured features:
ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB
Important settings:
value of $LANG: en_IE.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm gv subr-x
byte-opt bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc
paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese composite
emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 multi-tty make-network-process
emacs)
In GNU Emacs 28.0.60 (build 1, x86_64-pc-linux-gnu)
of 2021-10-11 built on tia
Repository revision: b3d0f53b296a0876ec7a55ae840868e65ed54e14
Repository branch: emacs-28
System Description: Debian GNU/Linux bookworm/sid
Configured using:
'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
--prefix=/home/blc/.local --program-suffix=-28-nox
--enable-checking=structs --with-file-notification=yes
--with-x-toolkit=no --without-x'
Configured features:
ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB
Important settings:
value of $LANG: en_IE.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv
bytecomp byte-compile cconv regexp-opt iso-transl tooltip eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese composite
emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 multi-tty make-network-process
emacs)
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
2021-10-11 21:17 bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-10-11 21:49 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-12 0:21 ` Stefan Kangas
2021-10-12 12:46 ` Lars Ingebrigtsen
2021-10-12 13:06 ` Eli Zaretskii
2 siblings, 1 reply; 9+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-10-11 21:49 UTC (permalink / raw)
To: 51139; +Cc: Dave Gillespie, Bill Wohler
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote:
> I assume the warnings are not important enough to install anything on
> emacs-28, so I attach a patch against master for both sets of warnings.
> WDYT?
Heh, no sooner had I submitted the patch than it already had conflicts
against master after the following change:
Remove redundant calls to 'mh-do-in-gnu-emacs'
76d75df8e7 2021-10-11 22:57:43 +0200
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=76d75df8e7
So I've respun it in the attached.
--
Basil
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-byte-compilation-warnings-in-nox-builds.patch --]
[-- Type: text/x-diff, Size: 5595 bytes --]
From bad4d4ac2abf48ef3c31ba9172c703d1117350cd Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Mon, 11 Oct 2021 19:14:23 +0100
Subject: [PATCH] Fix byte-compilation warnings in nox builds
For discussion, see bug#51139.
* lisp/edmacro.el (edmacro-fix-menu-commands): Load mwheel to pacify
free variable warnings in without-x builds.
* lisp/mh-e/mh-compat.el: Declare image.el functions that are not
preloaded in without-x builds.
* lisp/mh-e/mh-utils.el (mh--with-image-load-path): New macro.
(mh-logo-display):
* lisp/mh-e/mh-tool-bar.el (mh-tool-bar-folder-buttons-init)
(mh-tool-bar-letter-buttons-init): Use it to pacify byte-compilation
warnings about image.el definitions not preloaded without-x.
---
lisp/edmacro.el | 6 ++++++
lisp/mh-e/mh-compat.el | 4 ++++
lisp/mh-e/mh-tool-bar.el | 12 ++----------
lisp/mh-e/mh-utils.el | 24 ++++++++++++++++++------
4 files changed, 30 insertions(+), 16 deletions(-)
diff --git a/lisp/edmacro.el b/lisp/edmacro.el
index e90b3a006e..a4eb574a4c 100644
--- a/lisp/edmacro.el
+++ b/lisp/edmacro.el
@@ -604,6 +604,12 @@ edmacro-sanitize-for-string
(defun edmacro-fix-menu-commands (macro &optional noerror)
(if (vectorp macro)
(let (result)
+ ;; Not preloaded in without-x builds.
+ (require 'mwheel)
+ (defvar mouse-wheel-down-event)
+ (defvar mouse-wheel-left-event)
+ (defvar mouse-wheel-right-event)
+ (defvar mouse-wheel-up-event)
;; Make a list of the elements.
(setq macro (append macro nil))
(dolist (ev macro)
diff --git a/lisp/mh-e/mh-compat.el b/lisp/mh-e/mh-compat.el
index 839379857f..561e2ec7c8 100644
--- a/lisp/mh-e/mh-compat.el
+++ b/lisp/mh-e/mh-compat.el
@@ -87,9 +87,13 @@ 'mh-face-background
(define-obsolete-function-alias 'mh-font-lock-add-keywords
#'font-lock-add-keywords "29.1")
+;; Not preloaded in without-x builds.
+(declare-function image-load-path-for-library "image")
(define-obsolete-function-alias 'mh-image-load-path-for-library
#'image-load-path-for-library "29.1")
+;; Not preloaded in without-x builds.
+(declare-function image-search-load-path "image")
(define-obsolete-function-alias 'mh-image-search-load-path
#'image-search-load-path "29.1")
diff --git a/lisp/mh-e/mh-tool-bar.el b/lisp/mh-e/mh-tool-bar.el
index 06b94b6bf8..88e5c0e7bb 100644
--- a/lisp/mh-e/mh-tool-bar.el
+++ b/lisp/mh-e/mh-tool-bar.el
@@ -213,11 +213,7 @@ mh-tool-bar-define
;; Tool bar initialization functions
(defun mh-tool-bar-folder-buttons-init ()
(when (mh-buffer-exists-p 'mh-folder-mode)
- (let* ((load-path (image-load-path-for-library "mh-e"
- "mh-logo.xpm"))
- (image-load-path (cons (car load-path)
- (when (boundp 'image-load-path)
- image-load-path))))
+ (mh--with-image-load-path
(setq mh-folder-tool-bar-map
(let ((tool-bar-map (make-sparse-keymap)))
,@(nreverse folder-button-setter)
@@ -236,11 +232,7 @@ mh-tool-bar-define
tool-bar-map)))))
(defun mh-tool-bar-letter-buttons-init ()
(when (mh-buffer-exists-p 'mh-letter-mode)
- (let* ((load-path (image-load-path-for-library "mh-e"
- "mh-logo.xpm"))
- (image-load-path (cons (car load-path)
- (when (boundp 'image-load-path)
- image-load-path))))
+ (mh--with-image-load-path
(setq mh-letter-tool-bar-map
(let ((tool-bar-map (make-sparse-keymap)))
,@(nreverse letter-button-setter)
diff --git a/lisp/mh-e/mh-utils.el b/lisp/mh-e/mh-utils.el
index 4f211c1286..3f1bcbdcc0 100644
--- a/lisp/mh-e/mh-utils.el
+++ b/lisp/mh-e/mh-utils.el
@@ -119,22 +119,34 @@ mh-replace-string
;;; Logo Display
+;;;###mh-autoload
+(defmacro mh--with-image-load-path (&rest body)
+ "Load `image' and eval BODY with `image-load-path' set appropriately."
+ (declare (debug t) (indent 0))
+ `(progn
+ ;; Not preloaded in without-x builds.
+ (require 'image)
+ (defvar image-load-path)
+ (declare-function image-load-path-for-library "image")
+ (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm"))
+ (image-load-path (cons (car load-path)
+ (and (boundp 'image-load-path)
+ image-load-path))))
+ ,@body)))
+
(defvar mh-logo-cache nil)
;;;###mh-autoload
(defun mh-logo-display ()
"Modify mode line to display MH-E logo."
- (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm"))
- (image-load-path (cons (car load-path)
- (when (boundp 'image-load-path)
- image-load-path))))
+ (mh--with-image-load-path
(add-text-properties
0 2
`(display ,(or mh-logo-cache
(setq mh-logo-cache
(mh-funcall-if-exists
- find-image '((:type xpm :ascent center
- :file "mh-logo.xpm"))))))
+ find-image '(( :type xpm :ascent center
+ :file "mh-logo.xpm" ))))))
(car mode-line-buffer-identification))))
\f
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
2021-10-11 21:49 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-10-12 0:21 ` Stefan Kangas
2021-10-12 12:41 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-24 22:57 ` Bill Wohler
0 siblings, 2 replies; 9+ messages in thread
From: Stefan Kangas @ 2021-10-12 0:21 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 51139, Dave Gillespie, Bill Wohler
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote:
>
>> I assume the warnings are not important enough to install anything on
>> emacs-28, so I attach a patch against master for both sets of warnings.
>> WDYT?
I guess warnings are indeed not important enough for emacs-28,
especially if they only affect nox builds. But I'll leave that to the
maintainers to decide.
> Heh, no sooner had I submitted the patch than it already had conflicts
> against master after the following change:
I only hope you don't need to re-spin it again after my most recent
push...
> So I've respun it in the attached.
Thanks, LGTM, but maybe someone else wants to take a look as well.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
2021-10-12 0:21 ` Stefan Kangas
@ 2021-10-12 12:41 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-12 15:59 ` Stefan Kangas
2021-10-24 22:57 ` Bill Wohler
1 sibling, 1 reply; 9+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-10-12 12:41 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 51139, Bill Wohler
Stefan Kangas [2021-10-11 17:21 -0700] wrote:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Heh, no sooner had I submitted the patch than it already had conflicts
>> against master after the following change:
>
> I only hope you don't need to re-spin it again after my most recent
> push...
Where would the fun in that be ;). The patch still applies cleanly at
the time of writing.
It looks like your changes have dropped support for old Emacs versions,
though, meaning I can safely incorporate bound-and-true-p in the patch.
>> So I've respun it in the attached.
>
> Thanks, LGTM, but maybe someone else wants to take a look as well.
Thanks, I'll give this a bit more time to ferment (and foment) before
pushing.
--
Basil
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
2021-10-12 0:21 ` Stefan Kangas
2021-10-12 12:41 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-10-24 22:57 ` Bill Wohler
1 sibling, 0 replies; 9+ messages in thread
From: Bill Wohler @ 2021-10-24 22:57 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Basil L. Contovounesios, 51139, Dave Gillespie
Stefan Kangas <stefan@marxist.se> wrote:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
> > Basil L. Contovounesios [2021-10-11 22:17 +0100] wrote:
> >
> >> I assume the warnings are not important enough to install anything on
> >> emacs-28, so I attach a patch against master for both sets of warnings.
> >> WDYT?
>
> I guess warnings are indeed not important enough for emacs-28,
> especially if they only affect nox builds. But I'll leave that to the
> maintainers to decide.
>
> > Heh, no sooner had I submitted the patch than it already had conflicts
> > against master after the following change:
>
> I only hope you don't need to re-spin it again after my most recent
> push...
>
> > So I've respun it in the attached.
>
> Thanks, LGTM, but maybe someone else wants to take a look as well.
LGTM too, and so far MH-E on master is still working... Thanks all!
--
Bill Wohler <wohler@newt.com> aka <Bill.Wohler@nasa.gov>
http://www.newt.com/wohler/, GnuPG ID:610BD9AD
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
2021-10-11 21:17 bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11 21:49 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-10-12 12:46 ` Lars Ingebrigtsen
2021-10-12 21:51 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-12 13:06 ` Eli Zaretskii
2 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-12 12:46 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 51139, Dave Gillespie, Bill Wohler
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> I assume the warnings are not important enough to install anything on
> emacs-28, so I attach a patch against master for both sets of warnings.
> WDYT?
Looks good to me (but in master).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
2021-10-12 12:46 ` Lars Ingebrigtsen
@ 2021-10-12 21:51 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 9+ messages in thread
From: Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-10-12 21:51 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 51139, Dave Gillespie, Bill Wohler
close 51139 29.1
quit
Lars Ingebrigtsen [2021-10-12 14:46 +0200] wrote:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> I assume the warnings are not important enough to install anything on
>> emacs-28, so I attach a patch against master for both sets of warnings.
>> WDYT?
>
> Looks good to me (but in master).
Thanks, done.
Fix byte-compilation warnings in nox builds
bcb43fbc95 2021-10-12 22:32:03 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=bcb43fbc95
--
Basil
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds
2021-10-11 21:17 bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11 21:49 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-12 12:46 ` Lars Ingebrigtsen
@ 2021-10-12 13:06 ` Eli Zaretskii
2 siblings, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2021-10-12 13:06 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: 51139, daveg, wohler
> Cc: Dave Gillespie <daveg@synaptics.com>, Bill Wohler <wohler@newt.com>
> Date: Mon, 11 Oct 2021 22:17:19 +0100
> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I see the following byte-compilation warnings in --without-x builds:
>
> --8<---------------cut here---------------start------------->8---
> In edmacro-fix-menu-commands:
> edmacro.el:622:34: Warning: reference to free variable
> ‘mouse-wheel-down-event’
> edmacro.el:622:57: Warning: reference to free variable ‘mouse-wheel-up-event’
> edmacro.el:623:34: Warning: reference to free variable
> ‘mouse-wheel-right-event’
> edmacro.el:624:34: Warning: reference to free variable
> ‘mouse-wheel-left-event’
>
> In end of data:
> mh-e/mh-compat.el:96:5: Warning: the function ‘image-search-load-path’ is not
> known to be defined.
> mh-e/mh-compat.el:93:5: Warning: the function ‘image-load-path-for-library’ is
> not known to be defined.
> In mh-logo-display:
> mh-e/mh-utils.el:129:40: Warning: Unused lexical variable `image-load-path'
> In mh-tool-bar-folder-buttons-init:
> mh-e/mh-tool-bar.el:302:1: Warning: Unused lexical variable `image-load-path'
> In mh-tool-bar-letter-buttons-init:
> mh-e/mh-tool-bar.el:384:3: Warning: Unused lexical variable `image-load-path'
> In end of data:
> mh-e/mh-utils.el:128:24: Warning: the function ‘image-load-path-for-library’
> is not known to be defined.
> In end of data:
> mh-e/mh-tool-bar.el:302:1: Warning: the function ‘image-load-path-for-library’
> is not known to be defined.
> --8<---------------cut here---------------end--------------->8---
>
> The MH-E warnings are seen on master, whereas the edmacro ones are also
> on emacs-28 (details of both configurations follow my signature).
>
> I assume the warnings are not important enough to install anything on
> emacs-28, so I attach a patch against master for both sets of warnings.
> WDYT?
It's okay to install trivial changes on emacs-28 to shut up those
warnings.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-10-24 22:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-11 21:17 bug#51139: 29.0.50; MH-E and edmacro byte-compile warnings in nox builds Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-11 21:49 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-12 0:21 ` Stefan Kangas
2021-10-12 12:41 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-12 15:59 ` Stefan Kangas
2021-10-24 22:57 ` Bill Wohler
2021-10-12 12:46 ` Lars Ingebrigtsen
2021-10-12 21:51 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-12 13:06 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.