all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: master c1106b2ee7: Make sure native keypresses are received immediately on GTK
       [not found] ` <20220108132907.D302AC0DA1B@vcs2.savannah.gnu.org>
@ 2022-01-08 20:03   ` Ken Brown
  2022-01-09  0:51     ` Po Lu
  0 siblings, 1 reply; 4+ messages in thread
From: Ken Brown @ 2022-01-08 20:03 UTC (permalink / raw)
  To: emacs-devel, Po Lu

On 1/8/2022 8:29 AM, Po Lu via Mailing list for Emacs changes wrote:
> diff --git a/src/gtkutil.c b/src/gtkutil.c
> index aaa2933f86..ff5c0f2751 100644
> --- a/src/gtkutil.c
> +++ b/src/gtkutil.c
> @@ -6250,6 +6250,8 @@ xg_widget_key_press_event_cb (GtkWidget *widget, GdkEvent *event,
>         xg_pending_quit_event.kind = NO_EVENT;
>         kbd_buffer_store_buffered_event (&inev, &xg_pending_quit_event);
>       }
> +
> +  raise (SIGIO);

Should this be guarded by "#ifdef USABLE_SIGIO"?  And I have the same question 
for the call to "raise (SIGIO)" in pgtkterm.c.

Ken



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master c1106b2ee7: Make sure native keypresses are received immediately on GTK
  2022-01-08 20:03   ` master c1106b2ee7: Make sure native keypresses are received immediately on GTK Ken Brown
@ 2022-01-09  0:51     ` Po Lu
  2022-01-09  1:41       ` Ken Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Po Lu @ 2022-01-09  0:51 UTC (permalink / raw)
  To: Ken Brown; +Cc: emacs-devel

Ken Brown <kbrown@cornell.edu> writes:

> Should this be guarded by "#ifdef USABLE_SIGIO"?  And I have the same
> question for the call to "raise (SIGIO)" in pgtkterm.c.

The PGTK build is apparently not supposed to work in systems without
usable SIGIO, but this is.

Good catch, thanks!



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master c1106b2ee7: Make sure native keypresses are received immediately on GTK
  2022-01-09  0:51     ` Po Lu
@ 2022-01-09  1:41       ` Ken Brown
  2022-01-09  1:44         ` Po Lu
  0 siblings, 1 reply; 4+ messages in thread
From: Ken Brown @ 2022-01-09  1:41 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

On 1/8/2022 7:51 PM, Po Lu wrote:
> The PGTK build is apparently not supposed to work in systems without
> usable SIGIO,

So should a test for this be added to configure.ac?  I just checked that a build 
--with-pgtk succeeds on Cygwin, which does not have usable SIGIO.

Ken



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master c1106b2ee7: Make sure native keypresses are received immediately on GTK
  2022-01-09  1:41       ` Ken Brown
@ 2022-01-09  1:44         ` Po Lu
  0 siblings, 0 replies; 4+ messages in thread
From: Po Lu @ 2022-01-09  1:44 UTC (permalink / raw)
  To: Ken Brown; +Cc: emacs-devel

Ken Brown <kbrown@cornell.edu> writes:

> So should a test for this be added to configure.ac?  I just checked
> that a build --with-pgtk succeeds on Cygwin, which does not have
> usable SIGIO.

If SIGIO is defined and raising it works, it should work as well.
I don't know the details -- maybe Yuuki can chime in.

Thanks.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-09  1:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <164164854752.7483.4054434417943327470@vcs2.savannah.gnu.org>
     [not found] ` <20220108132907.D302AC0DA1B@vcs2.savannah.gnu.org>
2022-01-08 20:03   ` master c1106b2ee7: Make sure native keypresses are received immediately on GTK Ken Brown
2022-01-09  0:51     ` Po Lu
2022-01-09  1:41       ` Ken Brown
2022-01-09  1:44         ` Po Lu

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.