From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 79d9f3982f: Add derived-mode test for bug#24176 Date: Tue, 25 Jan 2022 13:16:36 +0100 Message-ID: <87a6fkypqz.fsf@gnus.org> References: <164303371205.13369.5637099354011397679@vcs2.savannah.gnu.org> <20220124141512.66398C0DA30@vcs2.savannah.gnu.org> <87fspd3uwt.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7214"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 25 13:29:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCKwb-0001gu-3F for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jan 2022 13:29:05 +0100 Original-Received: from localhost ([::1]:34980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCKwZ-0005O4-KJ for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jan 2022 07:29:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCKkj-00012y-7S for emacs-devel@gnu.org; Tue, 25 Jan 2022 07:16:51 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=52332 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCKkg-0002wQ-UB for emacs-devel@gnu.org; Tue, 25 Jan 2022 07:16:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8FcKqQbP3Slut6gvkDJN2MN9GeiHLlrN55mjEHHvQp0=; b=chp/KR6m10G0+Bgvsb6CZVzOsu hCCZx/ofZPfiDFhWqwdiz4ITmmHXKun7AtTuSzMRoUs6SCsZFFflMgDab/UNUfDATlfocCPDUVgaD uaQFG69fSYqxXV6BHirCfCCrkLzW7oQ2MXbbVPyWyXM0n0rzzjBbw3bDpfVUr2/eyZvY=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCKkX-0003HG-45; Tue, 25 Jan 2022 13:16:39 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEU0LipDOjVLQzyP hnZlW1CEeWuqpZb////IoTa+AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YBGQwFD/hqcyoAAAGdSURB VDjLtZNNcoMwDIVlhgNYnnQPLj2BIOvEkXOBQC/gJvc/QmUZ8sOERRf1yrzPepIlA8YRM/su+Lxa xOriQ2g9YAHezcCeYgMOBezSE0DEG7cAYGaQUSF1Ym/lFLjuGbRYy74B4zIYp2khLe6Y+6MzBvxX ml7B949UiAroGcRbH1wrEZ/XiYb4AOdbz14K810faZgKkPvhOY0crJHkfKJhLEB0TCfi0AA45riA rFc90xisWEWOe1KQjbC+RqIgd/fM0z7dQU17MThatVpADjjTPgmAGUiDg4JdohvR2FQHBXQHtZQo CaE+ADKPl+GeW0qcOOcG00m99xT4SdK4owLf5a4XJ7RnmsYVUCfs4mUBzpc5FfDBNKwAzlY0RwBm rzmFQcqzaQpw+qhEBolIEuDljRQvv2SQNzJwa8E3c4gCMGjqPsjwqqDAoOo2byuZRP60JYsu3VoE iS+yxsx6Xu6hv66qea/DxnmoNnTwWwGHvzr9y5Kfytjcf7MC0iUrovy+j7MFGAG552YF9LQarsGb tJsAN0DVbgAd4S9w9G1nnHni8gAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMS0yNVQxMjowNTox NSswMDowMN6j0rsAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDEtMjVUMTI6MDU6MTUrMDA6MDCv /moHAAAAAElFTkSuQmCC X-Now-Playing: David Bowie's _Brilliant Adventure (9): Re:Call 5_: "Lucy Can't Dance" In-Reply-To: (Stefan Monnier's message of "Mon, 24 Jan 2022 17:52:32 -0500") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285360 Archived-At: Stefan Monnier writes: >>> (defvar mode-a-flk '(("a" 0 'font-lock-keyword-face))) >>> (define-derived-mode mode-a fundamental-mode "mode-a" >>> (setq-local font-lock-defaults '(mode-a-flk))) >>> (define-derived-mode mode-b mode-a "mode-b" >>> (font-lock-add-keywords nil `(("b" 0 'font-lock-builtin-face)))) >>> (defvar mode-c-flk '(("c" 0 'font-lock-keyword-face))) >>> (define-derived-mode mode-c mode-b "mode-c" >>> (setq-local font-lock-defaults '(mode-c-flk))) >> >> And font-lock-keywords should then be... >> (t (("c" 0 'font-lock-keyword-face)))? > > I think so, yes, or maybe b+c, but it definitely should not be a+b. Hm... do you see any obvious way to fix this? We could document that you have to set font-lock-set-defaults to nil if you're setting font-lock-defaults in a derived mode, but that's not very satisfactory... or we could store the value of font-lock-defaults and check whether it's changed (in font-lock-set-defaults)? Hm... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no