bug#52697: 29.0.50; pgtk: wrong initial frame parameter values

[Stephen Berman <stephen.berman@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On Tue, 08 Feb 2022 19:57:56 +0800 Po Lu <luangruo@yahoo.com> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> With Emacs built from master without pgtk, I start with -Q and evaluate
>> the following sexps, yielding the results shown:
>>
>> (alist-get 'left (frame-parameters))
>> 939
>>
>> (alist-get 'top (frame-parameters))
>> 371
>>
>> With Emacs built from master with pgtk, I start with -Q and evaluate
>> the same sexps, yielding the following results:
>>
>> (alist-get 'left (frame-parameters))
>> 0
>>
>> (alist-get 'top (frame-parameters))
>> 0
>>
>> The results in the non-pgtk build are correct: the frame is in the
>> middle of the screen, not in the upper left corner.  This is with Xfce
>> and the xfwm4 window manager.
>
> Thanks, should be fixed now on master.

Thanks very much, I confirm your patch essentially fixes the bug, except
for mistakenly switching the top and left parameters:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pgtkterm.c patch --]
[-- Type: text/x-patch, Size: 411 bytes --]

diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index e9fd5f83b7..8faffe94d4 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -5552,7 +5552,7 @@ configure_event (GtkWidget *widget,

       if (f->win_gravity == NorthWestGravity)
 	gtk_window_get_position (GTK_WINDOW (widget),
-				 &f->top_pos, &f->left_pos);
+				 &f->left_pos, &f->top_pos);
       else
 	{
 	  f->top_pos = event->configure.y;

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


Steve Berman