From: Andreas Schwab <schwab@linux-m68k.org>
To: "Andrew L. Moore" <slewsys@gmail.com>
Cc: 54218@debbugs.gnu.org
Subject: bug#54218: [PATCH] Magic number regexp shouldn't match beyond end-of-line.
Date: Wed, 02 Mar 2022 09:23:55 +0100 [thread overview]
Message-ID: <87a6e8sqxw.fsf@igel.home> (raw)
In-Reply-To: <1453034b-77c7-4c25-7f6e-0ba14090cf12@gmail.com> (Andrew L. Moore's message of "Tue, 1 Mar 2022 23:52:50 -0500")
On Mär 01 2022, Andrew L. Moore wrote:
> diff --git a/lisp/progmodes/executable.el b/lisp/progmodes/executable.el
> index d7c093444e..9116bdea9d 100644
> --- a/lisp/progmodes/executable.el
> +++ b/lisp/progmodes/executable.el
> @@ -232,7 +232,8 @@ executable-set-magic
> (save-excursion
> (goto-char (point-min))
> (add-hook 'after-save-hook 'executable-chmod nil t)
> - (if (looking-at "#![ \t]*\\(.*\\)$")
> + ;; Regexp shouldn't match beyond end-of-line.
> + (if (looking-at "#![ \t]*\\([^\n]*\\)$")
In Emacs regexps, `.' doesn't match newlines.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-03-02 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 4:52 bug#54218: [PATCH] Magic number regexp shouldn't match beyond end-of-line Andrew L. Moore
2022-03-02 8:23 ` Andreas Schwab [this message]
2022-03-03 14:42 ` Lars Ingebrigtsen
2022-03-03 19:57 ` Andrew L. Moore
2022-03-04 15:37 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6e8sqxw.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=54218@debbugs.gnu.org \
--cc=slewsys@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.