From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#54240: emacs/lisp/emacs-lisp/derived.el patch Date: Fri, 04 Mar 2022 01:36:44 +0100 Message-ID: <87a6e6pn8j.fsf@web.de> References: <87sfrzgdpp.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28938"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54240@debbugs.gnu.org, chenphy10@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 04 01:37:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPvwT-0007Of-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Mar 2022 01:37:09 +0100 Original-Received: from localhost ([::1]:44574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPvwS-0003J0-3c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Mar 2022 19:37:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPvwM-0003Ic-0t for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 19:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPvwL-0002NM-Og for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 19:37:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nPvwL-0003Pl-Ji for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 19:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Mar 2022 00:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54240 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54240-submit@debbugs.gnu.org id=B54240.164635421413111 (code B ref 54240); Fri, 04 Mar 2022 00:37:01 +0000 Original-Received: (at 54240) by debbugs.gnu.org; 4 Mar 2022 00:36:54 +0000 Original-Received: from localhost ([127.0.0.1]:44207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPvwD-0003PP-Ow for submit@debbugs.gnu.org; Thu, 03 Mar 2022 19:36:53 -0500 Original-Received: from mout.web.de ([212.227.15.4]:60207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPvwB-0003PA-S3 for 54240@debbugs.gnu.org; Thu, 03 Mar 2022 19:36:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1646354205; bh=dZvado1tEDlbIdFP/kBQv+MhJ3VO/W/zoOQNmByG0xw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=enoUI8Ja47oc6o0Ja6yO+nTjFpQlWgGbQiM1h6HX7MlzZUHOQGDgHx1uEV4zDckEM gdBwsmjEpcGimp14rSsRa1tOUVZRhu+pHQZzkQXy8e8/F/47yxuww778Yy/eXd5G40 l65CMGLOxQcUeDqHaok6HVU/yKDVPS5+7exoadQI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MmQYX-1nqEDF3mKX-00i4oK; Fri, 04 Mar 2022 01:36:44 +0100 In-Reply-To: <87sfrzgdpp.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 03 Mar 2022 18:14:58 +0100") X-Provags-ID: V03:K1:4sS3qnjTxVN0MbUTDXjuWno0JT4RIH2KnuieAPGC7q+dn7Md38a KuDYZO1pgrSqtaIxvqFcH8cteVQQHGTBUAf6E+Wzoby8aqPY/QtqNByDJEUUgjKfj/+f0eN IvRriDQk0dmTBSYiT9IfbDWgI6aigi5s26cAgY7Jn12RRj+iE2WANWh221If8IVM/fWJYs1 ch5zQZAbf0VozSTezEbsA== X-UI-Out-Filterresults: notjunk:1;V03:K0:vNCOqOGybso=:I9m6MlT1ABnd4GwqvjG1re FsXt/o/OlOuu7dbo2EyTnjsTJsg7A5/MZgBJYlFEU3OGKIJP3Z8CDnelS8lYI7IoWjUCgbglV MY+xdhOAj/HiaW07coMirkbJVV/2Nu/X2pgO6yVxWGsyr4lZ8u4bfoLEjdtNXIu1CMYlXStmm SP/j4aefNgiR9F4PUn3ZIlIAPQL8AhhFV+8x8hHbgo1Vo1lEwx2fPkPHe+xU2uHIKz4KNoWN0 GVQ9XsSACb0ylC3SA9FI7dzYCmoVheKCBYHa+Y+cUSOqpgivZk+ZlFLGc7vQ6qnQDFVDz4bWH zDd7+UbeJxEzdC/PbUXug7wLzu12Ub8mndN3ESg9OalZLMsQecofWBNHfDtJ1Idi+OnnXY6K3 4yF6i1/m/NRlhUYgtX3/Wyk56QM4/oGuAfcc/ss6h04hxIYriHQIgJ31VwpdTXwiFWpZA4LAT xbj58zP5y40sLZJIfiC50XzI+vUAK11yFUW8EKtY26vzwBv0SJsQ0i+oypzOzwmqnYyZ83pH3 vvxx852EC3W4tY/jOrYI0ork9+hrA6JK78+/2umeZgSUakNLEABJRSBtUVBBFm+QImI0lp6Gy /vneSLnVlnKX0t/+oJSN/Pi/kHotbcJIcLVqRPnHPuY+D49Z9uFolEzMQjDvBmc5F0bg+VIxt e879mLd2onsbPpPry8UQTDhJNMcp/tYcirh2t0M4ns97bp85TxD0jA3DopaRoi1CGOZFJ1Cnq USVgjPQefBKfpiThdeh9TB377nA2xNnu7w4SyiZrGNsNyMfxn7PdVG9wwhwkP9PpR8vfwm5F X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227982 Archived-At: Lars Ingebrigtsen writes: > > - (define-abbrev-table (derived-mode-abbrev-table-name mode) nil) > > + ,(define-abbrev-table (derived-mode-abbrev-table-name mode) nil) > > The code looks correct the way it is, I think? To me this looks like a regression introduced when converting to lexical binding. Look at the symbol 'mode': it's implicitly quoted so it can't refer to the lexical variable and you get the error reported. The patch unquotes too much however, looks like we want something like > > - (define-abbrev-table (derived-mode-abbrev-table-name mode) nil) > > + (define-abbrev-table (derived-mode-abbrev-table-name ',mode) nil) (does that work?) Michael.