From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Fri, 04 Mar 2022 14:25:37 +0100 Message-ID: <87a6e5lui6.fsf@elite.giraud> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> <83lexqi3z9.fsf@gnu.org> <87tuceuo4b.fsf@red-bean.com> <83czj2hrdv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1699"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: Karl Fogel , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 04 14:41:02 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ8B3-0000BE-Cz for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 14:41:01 +0100 Original-Received: from localhost ([::1]:57304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ8B1-0002qD-L0 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 08:40:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ7wM-0001nA-Tc for emacs-devel@gnu.org; Fri, 04 Mar 2022 08:25:51 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:9097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ7wK-0006q0-QF; Fri, 04 Mar 2022 08:25:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=dFwiQmmhhhfdSm1G hkiRsqpIsHBaPpudblaFZBh2+Ak=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=o6xoK4KawhhDPqTal+M6GvSoveMPvJO4OnqrNb Rac07xhGUW2/CVOV6qocEY2zI9syjHMAbrs4NKtLXfmxP8VU9ZYJJYW64eseeSjkpt/0ld Y+o/KuxCaR9nTPlWUxEf+ub4YZUuSPXHuQgChlvP+xIT762Agqz6UIIalMLBf1BTYzLK9E ygaBj6SlK38YbAYQhBLAtgO1PVqafpmP8eY3UER4nbAR8578wNc/mWBEReklFBEL+oHv4o lQbsmpvdlq/ZrZexkOFMmyux6hrcAMVWu476efR6QsZZiDhaA28UKv0wfYvgk33msSDQgH KOekg0JAfSmHgYkX+V/oI7Aw== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id d7d5682f (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 4 Mar 2022 14:25:44 +0100 (CET) In-Reply-To: <83czj2hrdv.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Mar 2022 13:46:36 +0200") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286819 Archived-At: Eli Zaretskii writes: [...] > And you didn't answer my second question (and neither did Manuel). > Knowing whether this is a recent regression or not is important for > the decision whether to fix it now or later. I cannot say if it is a regression but it seems that the patch 61e51fee9ca3 of october 17, 2020 rewrote bookmark-bmenu-mode to use tabulated-list-mode and set the tabulated-list-sort-key on the bookmark name. -- Manuel Giraud