From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 6eeab90632: Don't accept whitespace or hex floats in rgbi: colour specs Date: Sun, 06 Mar 2022 21:46:36 +0800 Message-ID: <87a6e3p51f.fsf@yahoo.com> References: <164657208058.1597.5057681041192670917@vcs2.savannah.gnu.org> <20220306130800.EE0F9C01681@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="539"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 06 14:48:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQrFB-000AUt-V8 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Mar 2022 14:48:17 +0100 Original-Received: from localhost ([::1]:56202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQrFA-0005U3-CP for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Mar 2022 08:48:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQrDm-0004jE-Fi for emacs-devel@gnu.org; Sun, 06 Mar 2022 08:46:50 -0500 Original-Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]:38306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQrDk-00040m-Ks for emacs-devel@gnu.org; Sun, 06 Mar 2022 08:46:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646574407; bh=7f6gY49mpMxtor3ZvC1GMIPAhm2JfRDvulMQgBG31G8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=c+9N5HtFkA0riwrrxfTqIydtWHI3ovyMLiG7j6YtDzYz+I/cfTCVRdSACGDhXNrzPrt+5le9LrmVj/8WS3pMdwBSNzV1pmnDAIQmK3phYzDD1z1ZjXUBq8Ef09SgYhIfB7jsq8VJWtP9LKBEESOXs8ylypvqzivxNk2PvD4/iPgGTy4KJlrsCk1EppmKChrWkzJEbaqJ6rAhOYS6CB1us4mIqk4uWpwOmAyuX7HXoSTT3/BTlvOhuvrhJ0pPNoyNDHYi/EiUhmgo/VGkiDXvHMwoYsTW77J6dY5xUahkwW4XZe+yajZwwnyEWoR5/sZBrLE8t1hCcanvnEhV9gqQGA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1646574407; bh=gw6+3xa4SSNYoh9ReplFFRv6eHsU0eVu5kw6EbQbdZw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=qorEFXdgr59YGQUTZE67vgJByyB1dBE+OEBEI460Loo3b4p2UqP9nBep69mlC9PAgAx0aXf0+ncpH4GS7EESKXbzIYwLHvfOWhv+6+YMsTRUCfgY/I1ZGnNWCDkxwz1+8zHQTrO/FI77zwa7tsZrg3dy5zDkRjmxEr7GBTuiKfYU9j88ing00B4KieJy+q1rrGrliLTJlAU5j5PELiQLk86zmSF2G/zh5IgQRFl4FfYychtCbQayBHgm5cWYU5VpPiOfsXxTCTuJX5xjNp563J8+VfoWoB/ZnUa9cfFSGc8y0TYPGNIDfDS/C15YS0ybRrChUKt0A5CGJwG5UDUjmQ== X-YMail-OSG: GAkN7XEVM1lr.9hPqHrS5YleBNfr0v0osPapc1pp1dbOEWMbrXfy7UOJJjiIbZn KUzAcbaPl3NqZVRWLUODD9aakWFov35UYbl6xQXbKo.hOEpSLkTpvyk9KvxW9tvN0mOrXa_SseaD 8Pjr6iBJ6nbz6XR6yA2nqBZcSn45vpL2Eks2R6HLQVB44Jr0ZUTX5b4yWsF_2.bMgA3nITbamSC4 SG8DIqAl.FT0bWZmEi..mHsxQMPUTTiuiKBVCfJ8lEfE_32DZS7qwIujzuMFSrDCu2me2j02V.P. A7KpJi9M9JxL56XMbYgB3l80r2wCNRIj9aqAO0hYeLjUGeibddjHktRYWziRoJk7Hzr_x31v87QN uv7rKU85ff1b7pqs8d9KRV0I6feuA8XcpttXCvuvvK_QqqfYaVVH1Kj0oWUCLfOV_._yHTyepjdr nMXWN5e3CTUVmCcAZ4hyfpyRw8Vj5hyWUTV9b4hrnYeszt8p.1WdhV6ayNaSpAGB7SnHVJv7GF21 XKEBDS8BN2DoV3yrmwPGrrNvBxsII6gAdUcxSRpA80Bpyx1A2z7uYAahCFfhC82kHIQqMaKhwGLq 9_VwSFRWH.gp79Z.gkpyrzcSvuqFS8t9XwbW8uxwCMg8fdPXAso7pDZdGQVSTl_Vj3hZ7PXWitEE wsBH9lBA60QK5VsIOsRRPBOvrOdwGFsHOoBH..CpDa7_YLH0B80sc33m5c7TYXmqfB2HHh7I.p3e tZAPUSEEQWdwE5HK5MtaBiCShuoc7zKnK0RDnJN_zayCNQ6yTZGb3TnmD5Xh7q8viyUHltVdnyfQ RTkJ7n3tlxbJPKE2UoIGe1PdnedYuLXBW_5pp2udbI X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sun, 6 Mar 2022 13:46:47 +0000 Original-Received: by kubenode515.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID a323f6212deca7e856089fc074078a5d; Sun, 06 Mar 2022 13:46:40 +0000 (UTC) In-Reply-To: <20220306130800.EE0F9C01681@vcs2.savannah.gnu.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 6 Mar 2022 08:08:00 -0500 (EST)") X-Mailer: WebService/1.1.19797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.146; envelope-from=luangruo@yahoo.com; helo=sonic316-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286853 Archived-At: Mattias Engdeg=C3=A5rd writes: > branch: master > commit 6eeab90632506348a58d264eb3304625756c8659 > Author: Mattias Engdeg=C3=A5rd > Commit: Mattias Engdeg=C3=A5rd > > Don't accept whitespace or hex floats in rgbi: colour specs >=20=20=20=20=20 > `color-values-from-color-spec` (new in Emacs 28) erroneously accepted > leading whitespace and hex floats in rgbi: components. >=20=20=20=20=20 > Reported by Philip Kaludercic. >=20=20=20=20=20 > * src/xfaces.c (parse_float_color_comp): Disallow leading whitespace > and hex floats. > * test/src/xfaces-tests.el > (xfaces-internal-color-values-from-color-spec): Add test cases. I don't see a corresponding bug report, so please forgive me if I missed something here. If the leading whitespace and hex floats don't cause problems, why not keep the ability to understand them? It could come in handy. Thanks.