From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55149: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux Date: Thu, 28 Apr 2022 12:23:04 +0200 Message-ID: <87a6c5pkvr.fsf@gnus.org> References: <87mtg5zt3a.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37366"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55161@debbugs.gnu.org, 55149@debbugs.gnu.org, Stefan Monnier To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 12:57:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk1qM-0009WA-Dx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 12:57:54 +0200 Original-Received: from localhost ([::1]:45394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk1qL-00021j-6T for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 06:57:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk1Ja-0004ny-Rj for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 06:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk1Ja-0006Nm-Id for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 06:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk1Ja-0005NI-CQ for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 06:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55149-submit@debbugs.gnu.org id=B55149.165114139620596 (code B ref 55149); Thu, 28 Apr 2022 10:24:02 +0000 Original-Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 10:23:16 +0000 Original-Received: from localhost ([127.0.0.1]:45440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk1Iq-0005M6-Ef for submit@debbugs.gnu.org; Thu, 28 Apr 2022 06:23:16 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk1Io-0005Lk-QH; Thu, 28 Apr 2022 06:23:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rbgaasEVWzW59XWZ8apXA0NLIfu8mdeofAhyjafbh+c=; b=JJWhT5qT1KliiWzW15zOskEzIs qMItswWiXl6Z1K1k4MV/cxy1LreYjSErnOy52TLFp3M2rVOdsk7XEFBtn6h/HGNBOM/D9R7cBfGIn beOzMgMZOuMzOLw3/AfBL2HMFsWo8RlLAA4QVRqwLED6HEIOSH+WybEfebEqd71Oa148=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk1If-00081G-DW; Thu, 28 Apr 2022 12:23:07 +0200 X-Now-Playing: Yukihiro Takahashi's _Blue Moon Blue_: "A Star Is Born" In-Reply-To: <87mtg5zt3a.fsf@dick> (dick's message of "Thu, 28 Apr 2022 01:15:37 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230851 Archived-At: dick writes: > - (:after (apply cdr r) (apply car r)) > + (:after (prog1 (apply cdr r) (apply car r))) I guess this is the same as bug#55149, so I've merged the reports. Apparently, returning the value of the :after function is what's documented to happen (and is what the trunk does now), but it didn't use to do that, so it's breaking advice that relies on the old behaviour, if I understand 55149 correctly. Stefan? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no