bug#55978: 29.0.50; shell-resync-dirs inf-loops if tty outputs CRNL

bug#55978: 29.0.50; shell-resync-dirs inf-loops if tty outputs CRNL

[miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 3183 bytes --]

In M-x shell, execute "stty -nl" to make the tty translate \n into \r\n
on output, and press "M-RET" (shell-resync-dir).

Best regards.

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.17.6)
 of 2022-06-14 built on
Repository revision: 175bc8e5a53740432c844b5aae1981d4f47c96f7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Arch Linux

Configured using:
 'configure --prefix=/usr --without-libsystemd'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11
XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix

Major mode: Shell

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media rmc puny
dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068 epg-config gnus-util text-property-search time-date seq gv
byte-opt bytecomp byte-compile cconv mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch multi-isearch
cl-loaddefs cl-lib files-x shell subr-x pcomplete comint ansi-color ring
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer nadvice
simple cl-generic indonesian philippine cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 52473 6550)
 (symbols 48 6313 0)
 (strings 32 18133 1800)
 (string-bytes 1 593124)
 (vectors 16 12322)
 (vector-slots 8 181065 7709)
 (floats 8 21 50)
 (intervals 56 845 0)
 (buffers 992 12))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

bug#55978: 29.0.50; shell-resync-dirs inf-loops if tty outputs CRNL

[Eli Zaretskii]

> Date: Tue, 14 Jun 2022 20:01:30 +0200
> From: miha--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> In M-x shell, execute "stty -nl" to make the tty translate \n into \r\n
> on output, and press "M-RET" (shell-resync-dir).

I guess this requires to set coding-system for reading the shell
output to -dos?

bug#55978: 29.0.50; shell-resync-dirs inf-loops if tty outputs CRNL

[miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Tue, 14 Jun 2022 20:01:30 +0200
>> From: miha--- via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> In M-x shell, execute "stty -nl" to make the tty translate \n into \r\n
>> on output, and press "M-RET" (shell-resync-dir).
>
> I guess this requires to set coding-system for reading the shell
> output to -dos?

That could be an option, though I was thinking of a bit less invasive
and more local fix by performing a simple replace-regexp at the end of
the function `shell-eval-command'.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

bug#55978: 29.0.50; shell-resync-dirs inf-loops if tty outputs CRNL

[Eli Zaretskii]

> From: <miha@kamnitnik.top>
> Cc: 55978@debbugs.gnu.org
> Date: Tue, 14 Jun 2022 21:20:15 +0200
> 
> 
> [1:text/plain Hide]
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Date: Tue, 14 Jun 2022 20:01:30 +0200
> >> From: miha--- via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >> 
> >> In M-x shell, execute "stty -nl" to make the tty translate \n into \r\n
> >> on output, and press "M-RET" (shell-resync-dir).
> >
> > I guess this requires to set coding-system for reading the shell
> > output to -dos?
> 
> That could be an option, though I was thinking of a bit less invasive
> and more local fix by performing a simple replace-regexp at the end of
> the function `shell-eval-command'.

Using the EOL decoding machinery is much more efficient.