all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 55984@debbugs.gnu.org, drew.adams@oracle.com
Subject: bug#55984: 26.3; Doc string of `chmod' / `set-file-modes'
Date: Wed, 15 Jun 2022 15:19:31 +0200	[thread overview]
Message-ID: <87a6aeysgs.fsf@gmail.com> (raw)
In-Reply-To: <837d5irs4p.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Jun 2022 16:08:38 +0300")

>>>>> On Wed, 15 Jun 2022 16:08:38 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> Cc: 55984@debbugs.gnu.org
    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Wed, 15 Jun 2022 11:03:32 +0200
    >> 
    >> Passive voice as well. How about the following for emacs-28
    >> 
    >> 
    >> diff --git a/src/fileio.c b/src/fileio.c
    >> index 7d392e0de7..a240216dea 100644
    >> --- a/src/fileio.c
    >> +++ b/src/fileio.c
    >> @@ -3510,8 +3510,9 @@ DEFUN ("set-file-modes", Fset_file_modes, Sset_file_modes, 2, 3,
    >> Only the 12 low bits of MODE are used.  If optional FLAG is `nofollow',
    >> do not follow FILENAME if it is a symbolic link.
    >> 
    >> -Interactively, mode bits are read by `read-file-modes', which accepts
    >> -symbolic notation, like the `chmod' command from GNU Coreutils.  */)
    >> +Interactively, prompts for FILENAME, and reads MODE with
    >> +`read-file-modes', which accepts symbolic notation, like the `chmod'
    >> +command from GNU Coreutils.  */)

    Eli> "prompt" and "read", please, to be consistent with our preferred
    Eli> style.

I said "prompts" because itʼs describing what it does, but OK, fixed.

Robert
-- 





      reply	other threads:[~2022-06-15 13:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 21:36 bug#55984: 26.3; Doc string of `chmod' / `set-file-modes' Drew Adams
2022-06-15  9:03 ` Robert Pluim
2022-06-15 12:19   ` Lars Ingebrigtsen
2022-06-15 12:32     ` Robert Pluim
2022-06-15 13:08   ` Eli Zaretskii
2022-06-15 13:19     ` Robert Pluim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6aeysgs.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=55984@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.