Re: master 0dc75daf11: Filter out NS non-key events from `where-is-internal'

Re: master 0dc75daf11: Filter out NS non-key events from `where-is-internal'

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> +	       (cons  1 (make-non-key-event 'ns-power-off))
> +;;;	       (cons  9 (make-non-key-event 'ns-insert-working-text))
> +;;;	       (cons 10 (make-non-key-event 'ns-delete-working-text))

These are actually keys and probably should not be filtered out.

> +	       (cons 14 (make-non-key-event 'ns-show-prefs))))))

This is reportedly sent in response to a key press (s-,) but I couldn't
verify that.

Re: master 0dc75daf11: Filter out NS non-key events from `where-is-internal'

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> +	       (cons  1 (make-non-key-event 'ns-power-off))
>> +;;;	       (cons  9 (make-non-key-event 'ns-insert-working-text))
>> +;;;	       (cons 10 (make-non-key-event 'ns-delete-working-text))
>
> These are actually keys and probably should not be filtered out.

power-off or all three?  (The other two are commented out.)

>> +	       (cons 14 (make-non-key-event 'ns-show-prefs))))))
>
> This is reportedly sent in response to a key press (s-,) but I couldn't
> verify that.

s-, is still bound on Macos.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 0dc75daf11: Filter out NS non-key events from `where-is-internal'

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> power-off or all three?  (The other two are commented out.)

All three.  power-off is sent when pressing the power button.

Re: master 0dc75daf11: Filter out NS non-key events from `where-is-internal'

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> > power-off or all three?  (The other two are commented out.)
>
> All three.  power-off is sent when pressing the power button.

When I press the power button on my macOS machine, emacs -Q doesn't
pick it up (tested with C-h k).  (The power button generally has to be
pressed for a few seconds before it has any effect, on my 2015 MacBook
Pro.)

Re: master 0dc75daf11: Filter out NS non-key events from `where-is-internal'

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> power-off or all three?  (The other two are commented out.)
>
> All three.  power-off is sent when pressing the power button.

That event isn't about picking up the user pressing the power button,
but rather:

@item ns-power-off
@cindex ns-power-off event
This event occurs when the user logs out and Emacs is still running, or when
``Quit Emacs'' is chosen from the application menu.
The default behavior is to save all file-visiting buffers.


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 0dc75daf11: Filter out NS non-key events from `where-is-internal'

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> That event isn't about picking up the user pressing the power button,
> but rather:

It's sent when the power button is pressed for me, at least.
I guess the default action is to log out and power off.