From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: andrei.elkin--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#44502: Date: Fri, 19 Aug 2022 19:10:50 +0300 Organization: Home sweet home Message-ID: <87a680dxit.fsf@quad> References: <5aa738a4-cfd8-6c4e-3174-4489a289cca9@gmail.com> <878rnwi60h.fsf@quad> <83mtccqetc.fsf@gnu.org> <87leruhcdh.fsf@quad> <83y1vuoc5s.fsf@gnu.org> <87edxmha0b.fsf@quad> <83mtcanfhy.fsf@gnu.org> <87y1vtg3ok.fsf@quad> <83zgg0ecka.fsf@gnu.org> Reply-To: andrei.elkin@pp.inet.fi Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2023"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 44502@debbugs.gnu.org, Eli Zaretskii To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 19 18:17:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oP4gk-0000KP-T7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Aug 2022 18:17:38 +0200 Original-Received: from localhost ([::1]:51058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP4gj-0006y5-Vo for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Aug 2022 12:17:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP4gD-0006wm-JP for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 12:17:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP4gA-0003iz-Hd for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 12:17:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oP4gA-0002if-DN for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 12:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: andrei.elkin@pp.inet.fi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Aug 2022 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44502 X-GNU-PR-Package: emacs Original-Received: via spool by 44502-submit@debbugs.gnu.org id=B44502.166092580810428 (code B ref 44502); Fri, 19 Aug 2022 16:17:02 +0000 Original-Received: (at 44502) by debbugs.gnu.org; 19 Aug 2022 16:16:48 +0000 Original-Received: from localhost ([127.0.0.1]:59187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oP4fw-0002i8-FV for submit@debbugs.gnu.org; Fri, 19 Aug 2022 12:16:48 -0400 Original-Received: from mta-out1.inet.fi ([62.71.2.226]:47618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oP4fu-0002hs-Et for 44502@debbugs.gnu.org; Fri, 19 Aug 2022 12:16:47 -0400 Original-Received: from johanna1.inet.fi (unknown [10.16.62.33]) by em201-smtpout82.rokki.sonera.fi (Postfix) with ESMTP id 7318F5388; Fri, 19 Aug 2022 19:16:40 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inet.fi; s=smtpgw-3485-2022-03-15; t=1660925800; bh=kNgtyh/5OB8ZXVZFmcwQ4zauquAYD8XLJ9BBKhYqg+4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=uqSNahoP4xk/k16Dyf9D6mxSKVY2qAnRDzyX+vHA3dduF7JTAd3ax3fGYq7QhZn1M TjNaeCrnXje65z8F+n2OdJyGpbnHmzmthcIVSj0qlrakFE9ftsWLYueIfUoHKkoZsh YNwSxDhu/k3CptVciqOfnsJXe5JjFs9rKl4GzuPQ= Original-Received: from quad (193.210.229.97) by johanna1.inet.fi (9.0.019.26-1) id 628F49760A979BBB; Fri, 19 Aug 2022 19:16:40 +0300 In-Reply-To: (Alan Mackenzie's message of "Fri, 19 Aug 2022 13:05:24 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240218 Archived-At: Salute, Alan, Eli. > Hello, Eli. > > On Fri, Aug 19, 2022 at 13:45:57 +0300, Eli Zaretskii wrote: >> Ping! Any progress with this bug? > > I haven't been able to reproduce the bug, but understand fairly well what > must have caused it. > > I also haven't heard back from the OP since sending him a proposed patch > last Sunday. If OP is myself :-), then I have not patched my emacs waiting first for the assert. Has not come back yet. Cheers, Andrei > > Since the patch is fairly simple and obvious, also non-dangerous, how > about just installing it on the release branch? > >> > I think the following fix to the assert should indeed be a "safe" fix, >> > suitable for Emacs-28. Could you possibly apply it, please, and try to >> > recreate the error. If you don't manage to recreate the error, the bug >> > is probably "fixed". > >> > diff --git a/src/window.c b/src/window.c >> > index 2576b66a18..35ec2a1f90 100644 >> > --- a/src/window.c >> > +++ b/src/window.c >> > @@ -554,7 +554,9 @@ select_window (Lisp_Object window, Lisp_Object norecord, >> > frame is active. */ >> > Fselect_frame (frame, norecord); >> > /* Fselect_frame called us back so we've done all the work already. */ >> > - eassert (EQ (window, selected_window)); >> > + eassert (EQ (window, selected_window) >> > + || (EQ (window, f->minibuffer_window) >> > + && NILP (Fminibufferp (XWINDOW (window)->contents, Qt)))); >> > return window; >> > } >> > else