all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: andrei.elkin--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 44502@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#44502:
Date: Fri, 19 Aug 2022 19:10:50 +0300	[thread overview]
Message-ID: <87a680dxit.fsf@quad> (raw)
In-Reply-To: <Yv+KlG4R/YBXmjY/@ACM> (Alan Mackenzie's message of "Fri, 19 Aug 2022 13:05:24 +0000")

Salute, Alan, Eli.

> Hello, Eli.
>
> On Fri, Aug 19, 2022 at 13:45:57 +0300, Eli Zaretskii wrote:
>> Ping!  Any progress with this bug?
>
> I haven't been able to reproduce the bug, but understand fairly well what
> must have caused it.
>
> I also haven't heard back from the OP since sending him a proposed patch
> last Sunday.

If OP is myself :-), then I have not patched my emacs waiting first for
the assert. Has not come back yet.


Cheers,

Andrei

>
> Since the patch is fairly simple and obvious, also non-dangerous, how
> about just installing it on the release branch?
>
>> > I think the following fix to the assert should indeed be a "safe" fix,
>> > suitable for Emacs-28.  Could you possibly apply it, please, and try to
>> > recreate the error.  If you don't manage to recreate the error, the bug
>> > is probably "fixed".
>
>> > diff --git a/src/window.c b/src/window.c
>> > index 2576b66a18..35ec2a1f90 100644
>> > --- a/src/window.c
>> > +++ b/src/window.c
>> > @@ -554,7 +554,9 @@ select_window (Lisp_Object window, Lisp_Object norecord,
>> >  	 frame is active.  */
>> >        Fselect_frame (frame, norecord);
>> >        /* Fselect_frame called us back so we've done all the work already.  */
>> > -      eassert (EQ (window, selected_window));
>> > +      eassert (EQ (window, selected_window)
>> > +	       || (EQ (window, f->minibuffer_window)
>> > +		   && NILP (Fminibufferp (XWINDOW (window)->contents, Qt))));
>> >        return window;
>> >      }
>> >    else





      parent reply	other threads:[~2022-08-19 16:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-07 13:27 bug#44502: 28.0.50; Emacs crash using new frame Andy Moreton
2020-11-07 13:51 ` Andy Moreton
2020-11-07 14:05 ` Eli Zaretskii
2020-11-08 13:37   ` Alan Mackenzie
2020-11-08 15:15     ` Eli Zaretskii
2020-11-08 15:36       ` Andy Moreton
2021-09-08  9:52         ` Lars Ingebrigtsen
2022-08-10 13:26 ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-10 15:49   ` bug#44502: Eli Zaretskii
2022-08-11 18:19     ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-11 18:41       ` bug#44502: Eli Zaretskii
2022-08-11 19:10         ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-12  6:27           ` bug#44502: Eli Zaretskii
2022-08-12  8:34             ` bug#44502: Alan Mackenzie
2022-08-12 10:24             ` bug#44502: andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-14 14:30               ` bug#44502: Alan Mackenzie
2022-08-19 10:45                 ` bug#44502: Eli Zaretskii
2022-08-19 13:05                   ` bug#44502: Alan Mackenzie
2022-08-19 13:20                     ` bug#44502: Eli Zaretskii
2022-08-19 15:12                       ` bug#44502: Alan Mackenzie
2022-08-19 16:10                     ` andrei.elkin--- via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a680dxit.fsf@quad \
    --to=bug-gnu-emacs@gnu.org \
    --cc=44502@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=andrei.elkin@pp.inet.fi \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.