bug#50758: 28.0.50; tramp-theme makes the default face's foreground red on emacs@28

bug#50758: 28.0.50; tramp-theme makes the default face's foreground red on emacs@28

[Rudi C]

[-- Attachment #1: Type: text/plain, Size: 2384 bytes --]

`tramp-theme' (https://elpa.gnu.org/packages/tramp-theme.html) makes the
default face's foreground red on emacs@28. (I.e., almost all black text
will become red.)

I have seen this problem on three machines where I used my config, two
fresh installs of non-native-comp emacs@28, and one where I previously was
using emacs@27 with no problems, and then installed emacs@28 with native
comp.

I use the following config for `tramp-theme':

```
(setq tramp-theme-face-remapping-alist '(;; (nil "^root$" (fringe (:inherit
fringe :inverse-video t)))
(nil "^root$" (default (:background "lavenderblush")))
(nil "^root$" (hl-line (:background "mistyrose") hl-line))
(".*" "eva" (default (:background "mintcream")))
(".*" "eva" (hl-line (:background "azure") hl-line))
(".*" "zii" (default (:background "honeydew")))
(".*" "zii" (hl-line (:background "azure") hl-line))
("^foo$" nil (dired-directory (:background "Red")))
("^foo$" nil (eshell-prompt (:foreground "White")))
("^bar$" nil (default (:background "Green")))
("^bar$" nil (dired-directory (:background "Green")))))
```

And enable the theme with:
```
(progn (load-theme 'tramp t t)
(enable-theme 'tramp))
```


In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.3.0, NS appkit-2022.30
Version 11.2.1 (Build 20D75))
 of 2021-09-21 built on Fereidoons-MacBook-Pro.local
System Description:  macOS 11.2.1

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs-plus@28/28.0.50/share/info/emacs
 --prefix=/usr/local/Cellar/emacs-plus@28/28.0.50 --with-xml2
 --with-gnutls --with-native-compilation --without-dbus
 --with-imagemagick --with-modules --with-rsvg --with-xwidgets --with-ns
 --disable-ns-self-contained 'CFLAGS=-I/usr/local/opt/gcc/include
 -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include
 -I/usr/local/opt/jpeg/include' 'LDFLAGS=-L/usr/local/lib/gcc/11
 -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include
 -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include''

Configured features:
ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES
NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF
TOOLKIT_SCROLL_BARS XIM XWIDGETS ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

[-- Attachment #2: Type: text/html, Size: 2959 bytes --]

bug#50758: 28.0.50; tramp-theme makes the default face's foreground red on emacs@28

[Rudi C]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

After further attempts to pinpoint the cause of this bug, I have found that
tramp-theme changes the current theme of emacs. (I had a testing variant of
my main theme that had red foreground, and this was the reason I did not
notice this before.) This behavior also happens with
https://github.com/vic/color-theme-buffer-local , so I guess something
about face remapping has gone awry in emacs@28.

[-- Attachment #2: Type: text/html, Size: 482 bytes --]

bug#50758: 28.0.50; tramp-theme makes the default face's foreground red on emacs@28

[Lars Ingebrigtsen]

Rudi C <rudiwillalwaysloveyou@gmail.com> writes:

> After further attempts to pinpoint the cause of this bug, I have found
> that tramp-theme changes the current theme of emacs. (I had a testing
> variant of my main theme that had red foreground, and this was the
> reason I did not notice this before.) This behavior also happens with
> https://github.com/vic/color-theme-buffer-local , so I guess something
> about face remapping has gone awry in emacs@28.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

Are you still seeing these issues in the current Emacs?  If so, do you
have a complete recipe, starting from "emacs -Q", that reproduces the
problem?

bug#50758: 28.0.50; tramp-theme makes the default face's foreground red on emacs@28

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Are you still seeing these issues in the current Emacs?  If so, do you
> have a complete recipe, starting from "emacs -Q", that reproduces the
> problem?

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.