From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 18:45:18 +0200 Message-ID: <87a67ladep.fsf@gnus.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <83v8q9u1q8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36006"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Dmitry Gutov , ams@gnu.org, juri@jurta.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 19:09:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT4kK-0009Au-Oc for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 19:09:52 +0200 Original-Received: from localhost ([::1]:33684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT4kJ-0005bg-Cj for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 13:09:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4Mj-0007xK-9x for emacs-devel@gnu.org; Tue, 30 Aug 2022 12:45:33 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:50294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4Mf-0006dk-O1; Tue, 30 Aug 2022 12:45:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nwC2bumqqnquR64jDW3C0DzG342LSxeN6n5VxHoBgZo=; b=gSCIqjlpYlD4ZdBI3C46k5Bi9g cBglAQ3msQcc1Kvx7Nqn8fnvkGyCRx5cQ2ffWFVY4FV+oQpKbxVVbTFVQgay94EPehXVZYkrgKGjr tWr5+VRsfnaS3YSrSiZx89+aF7p4i9ujGe1iVvQgTUgS31DRdU4RMK15L0BGm/KNFhsE=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT4MZ-00018N-Bb; Tue, 30 Aug 2022 18:45:21 +0200 In-Reply-To: <83v8q9u1q8.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Aug 2022 19:37:20 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEV9coBFLl4VFRWx raft7Ob////o4EvwAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YIHhAsCdC0SSgAAAGKSURBVDjLlZRb doQgDIZFXIDGWYBkugA1WYA27H9NDQG8TOtDMwcO5uNPwm0aN/xtzSfI343+7tabo3dFoR0igo4C DgDaJYUnonnFmwUDnjy1d4AGGj/DMdFdgC8fofENlTkJNEv2T0S+7wcHhyLHn2ZnpeHwAd7wK3ku 1XrAcf8A7zVld9rOHHOqKKwYOG5u6fYDkM4JOpZoJidYrdhYrQLdKpW8D/9FQbrE6QCXHKR7GA6Q AvsSKpEDaNxRqoJm7DS6vCzFSCcg0OzSviwFZ2B+3e5UkLYWUKeeCoIupxggaKh0KbxkSRc5igaB cFcQK8jL8yWHRHWrzCJtyZ8VxDafZi7L66hWFZkTtewtgqdogFmiWA4zlo4kA/VHEpa6J50UkCQc z/MYVWUgljXr4mysZZ7A0JZPRbVXYEdkpzKzVJCYtm90VX5RAMe127/kCmYIem8DY9zr0ed11As7 icOs3wyUZxYw9Bu+UqDFbgmfz2yC9ByGcn0Y/7AElicATwCfwMOfzL/BD8VDqPeEMP8PAAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIyLTA4LTMwVDE2OjQ0OjA5KzAwOjAwabdB8wAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMi0wOC0zMFQxNjo0NDowOSswMDowMBjq+U8AAAAASUVORK5CYII= X-Now-Playing: Brigitte Fontaine's _Comme =?utf-8?Q?=C3=A0?= la radio_: "audio_11.mp3" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GAPPY_SUBJECT=0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294364 Archived-At: Eli Zaretskii writes: > I think the "C-x v D" step should be part of the command's execution. > It makes little sense to me to ask the user to prepare the diffs in > advance, since conceptually the changes are already on disk. It's just an easy way to decide which changes are part of this commit. > I think a special numeric argument (like "C-u 0", perhaps?) is more > appropriate to signal the interactive selection of changes. And then it asks you for every hunk whether to include it in the commit or not? Or did you have something else in mind?