From: Philip Kaludercic <philipk@posteo.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 57639@debbugs.gnu.org
Subject: bug#57639: [PATCH] Add new command 'toggle-theme'
Date: Sun, 11 Sep 2022 11:42:33 +0000 [thread overview]
Message-ID: <87a676jfx2.fsf@posteo.net> (raw)
In-Reply-To: <87fsgygo7c.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 11 Sep 2022 13:11:51 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> So we are thinking about something like a symbol property
>> `theme-variants' that each theme symbol may have attached. This symbol
>> could point to a list representing a set of alternatives. Let's say the
>> set might contain the theme itself (for the sake of convenience), so it
>> is remq'ed before we check if the set has more than one alternative. If
>> it does we use a modified `load-theme'-like prompt, otherwise we toggle.
>> I think it would also make sense to silently remove non-existent themes
>> automatically, in case a variant theme is not part of the same package.
>
> I think that sounds correct, but I'm not 100% sure. 😀
Ok, I'll implement this then.
>>> And in addition, this tagging could be used for automatic dark/light OS
>>> changes, so it's at least three birds with one stone.
>>
>> OK, but that is a long-term plan, or do the means already exist for
>> detecting these kinds of changes?
>
> Code exists for both Windows and Macos in the bug tracker somewhere, but
> haven't been integrated yet because nobody has sat down to make a
> consistent interface across all the platforms.
What about GNU/Linux desktops?
>> Also, how to be distinguish between what is light and dark, and what do
>> we do when a theme has multiple variants?
>
> I'm not sure what you mean -- the proposal is to make the themes say
> whether they consider themselves to be light or dark. And I don't think
> a theme would have multiple dark variants.
Stefans Gruvbox example had multiple dark and light variants. E.g.
Would the new command toggle from `gruvbox-dark-soft' to
`gruvbox-dark-light' or prompt the user to select from all the gruvbox
themes?
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I'm not sure what you mean -- the proposal is to make the themes say
>> whether they consider themselves to be light or dark. And I don't think
>> a theme would have multiple dark variants.
>
> But now I see that you've pushed `toggle-theme'... *sigh*
I'm very sorry about that, I've reverted those commits, since they were
accidentally pushed!
next prev parent reply other threads:[~2022-09-11 11:42 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 7:19 bug#57639: [PATCH] Add new command 'toggle-theme' Philip Kaludercic
2022-09-07 8:06 ` Stefan Kangas
2022-09-07 8:33 ` Philip Kaludercic
2022-09-07 8:51 ` Stefan Kangas
2022-09-07 13:03 ` Lars Ingebrigtsen
2022-09-07 13:31 ` Philip Kaludercic
2022-09-08 11:46 ` Lars Ingebrigtsen
2022-09-11 8:26 ` Philip Kaludercic
2022-09-11 11:11 ` Lars Ingebrigtsen
2022-09-11 11:22 ` Lars Ingebrigtsen
2022-09-11 11:42 ` Philip Kaludercic [this message]
2022-09-11 11:54 ` Lars Ingebrigtsen
2022-09-11 18:47 ` Philip Kaludercic
2022-09-12 10:10 ` Lars Ingebrigtsen
2022-09-12 11:06 ` Philip Kaludercic
2022-09-12 11:12 ` Lars Ingebrigtsen
2022-09-12 13:11 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-12 14:51 ` Michael Albinus
2022-09-13 12:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-12 15:26 ` Philip Kaludercic
2022-09-13 2:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-13 11:10 ` Lars Ingebrigtsen
2022-09-14 11:38 ` Philip Kaludercic
2022-09-14 13:03 ` Lars Ingebrigtsen
2022-09-14 14:37 ` Philip Kaludercic
2022-09-14 15:21 ` Lars Ingebrigtsen
2022-09-17 18:13 ` Philip Kaludercic
2022-09-17 18:32 ` Eli Zaretskii
2022-09-17 21:33 ` Philip Kaludercic
2022-09-18 6:53 ` Eli Zaretskii
2022-09-18 9:38 ` Philip Kaludercic
2022-09-18 10:39 ` Lars Ingebrigtsen
2022-09-18 11:39 ` Philip Kaludercic
2022-09-19 7:58 ` Lars Ingebrigtsen
2022-09-19 8:05 ` Philip Kaludercic
2022-09-19 8:15 ` Lars Ingebrigtsen
2022-09-19 10:13 ` Philip Kaludercic
2022-09-20 21:08 ` Philip Kaludercic
2022-09-20 21:11 ` Lars Ingebrigtsen
2022-09-20 21:35 ` Philip Kaludercic
2022-09-21 11:02 ` Lars Ingebrigtsen
2022-09-21 11:30 ` Philip Kaludercic
2022-09-21 11:38 ` Lars Ingebrigtsen
2022-09-21 11:46 ` Philip Kaludercic
2022-09-21 12:06 ` Lars Ingebrigtsen
2022-09-21 12:26 ` Philip Kaludercic
2022-10-09 12:58 ` Philip Kaludercic
2022-10-09 14:26 ` Lars Ingebrigtsen
2022-10-09 15:13 ` Philip Kaludercic
2022-10-09 20:32 ` Stefan Kangas
2022-10-09 21:02 ` Philip Kaludercic
2022-10-09 21:43 ` Philip Kaludercic
2022-10-10 0:56 ` Stefan Kangas
2022-10-10 1:17 ` Protesilaos Stavrou
2022-10-10 8:16 ` Philip Kaludercic
2022-10-10 8:14 ` Lars Ingebrigtsen
2022-10-10 11:02 ` Philip Kaludercic
2022-10-11 0:25 ` Lars Ingebrigtsen
2022-10-11 9:06 ` Philip Kaludercic
2022-10-11 19:43 ` Lars Ingebrigtsen
2022-10-11 19:51 ` Philip Kaludercic
2022-10-11 20:04 ` Lars Ingebrigtsen
2022-10-11 20:09 ` Philip Kaludercic
2022-10-11 20:49 ` Lars Ingebrigtsen
2022-10-13 8:50 ` Philip Kaludercic
2022-10-13 9:10 ` Philip Kaludercic
2022-10-13 10:34 ` Eli Zaretskii
2022-10-13 10:35 ` Philip Kaludercic
2022-10-13 14:03 ` Stefan Kangas
2022-10-13 14:07 ` Philip Kaludercic
2022-10-19 2:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-19 7:16 ` Philip Kaludercic
2022-10-19 12:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87a65qla8d.fsf@posteo.net>
2022-10-20 17:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-20 17:42 ` Philip Kaludercic
2022-10-20 20:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-19 2:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-19 7:20 ` Philip Kaludercic
2022-10-19 10:59 ` Eli Zaretskii
2022-10-19 12:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-13 19:12 ` Lars Ingebrigtsen
2022-10-13 20:21 ` Philip Kaludercic
2022-09-21 13:08 ` Protesilaos Stavrou
2022-09-21 13:13 ` Philip Kaludercic
2022-09-21 13:21 ` Protesilaos Stavrou
2022-09-21 13:05 ` Protesilaos Stavrou
2022-09-18 12:52 ` Eli Zaretskii
2022-09-18 12:56 ` Philip Kaludercic
2022-09-20 3:40 ` bug#57639: Toggling, in general Richard Stallman
2022-09-20 8:07 ` Philip Kaludercic
2022-09-21 2:47 ` Richard Stallman
2022-09-21 9:22 ` Robert Pluim
2022-09-20 12:20 ` Visuwesh
2022-10-13 20:46 ` bug#57639: [PATCH] Add new command 'toggle-theme' Mauro Aranda
2022-10-13 22:19 ` Philip Kaludercic
2022-10-13 22:53 ` Mauro Aranda
2022-10-14 7:28 ` Philip Kaludercic
2022-10-14 11:22 ` Mauro Aranda
2022-10-14 15:21 ` Philip Kaludercic
2022-10-14 18:20 ` Philip Kaludercic
2022-10-15 15:24 ` Philip Kaludercic
2022-10-14 6:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a676jfx2.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=57639@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.