From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master b525f201ba: Allow specifying the color to use in image-elide Date: Fri, 16 Sep 2022 11:08:28 +0200 Message-ID: <87a66zznxv.fsf@gnus.org> References: <166317972871.8462.16344173364399917298@vcs2.savannah.gnu.org> <20220914182209.04F50C00872@vcs2.savannah.gnu.org> <838rml194r.fsf@gnu.org> <87illp15fd.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10384"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 16 11:20:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ7WM-0002TG-IT for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Sep 2022 11:20:26 +0200 Original-Received: from localhost ([::1]:45902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ7WL-0000HH-8n for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Sep 2022 05:20:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ7Kz-0006kV-8r for emacs-devel@gnu.org; Fri, 16 Sep 2022 05:08:41 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:33116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ7Kw-00034o-Pi; Fri, 16 Sep 2022 05:08:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/9iT8FbaFf49XXlqVJ3ntzvYWd9+1ZjGNJc6whQa9/A=; b=NEoKFyUpTlLgSnxRBmPbooCmhD K59T0QcExuLCbH725wUnZIzJ+x8tZb2mobz4ercB5AjjVZnm164qnfQxVIV/CWE8uIoB2oyjKd76F bLAxL9I6Q0LhER7NmXNvsL1mMaGs3Yb3hyENCGP3wNHUli6i86TAl4MsnmTFjd2lSoe8=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ7Kr-0002UD-Jw; Fri, 16 Sep 2022 11:08:35 +0200 In-Reply-To: (Stefan Kangas's message of "Thu, 15 Sep 2022 00:28:41 -0700") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEU2LCuzkVj////D FCTDAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0SU1FB+YJEAkFHUBgxMIA AACjSURBVCjPvdHBDoMwCABQmsi9S+R/2sPuLIH//xUBraXLtuNIPLyCBRSAGLDBFXw9HsVPd0ix ZZSvgAb/iDn1O5YB9gzhnMmvPHLZsg5+xNJPBcp9MxnkhpaegKIDT9UfoIGuygkCCTzRDHNQGyEh /eDqGI2q7YzqYWkqA74lGRqfa3j9ZhXR2t4PoOdI40MwdDt92QQGAb+tRwq1R696Lu8FB9XeINDC 9y8+AAAAWmVYSWZNTQAqAAAACAAFARIAAwAAAAEAAQAAARoABQAAAAEAAABKARsABQAAAAEAAABS ASgAAwAAAAEAAgAAAhMAAwAAAAEAAQAAAAAAAAAAAEgAAAABAAAASAAAAAEfUvc0AAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIyLTA5LTE2VDA5OjA1OjI5KzAwOjAwnrkTCgAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMi0wOS0xNlQwOTowNToyOSswMDowMO/kq7YAAAAXdEVYdGV4aWY6WUNiQ3JQb3NpdGlv bmluZwAxrA+AYwAAAABJRU5ErkJggg== X-Now-Playing: Sly Stone's _I'm Just Like You: Sly's Stone Flower 1969-1970_: "Life & Death in G & A (Parts 1 & 2)" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295463 Archived-At: Stefan Kangas writes: > I don't think the current Emacs theme will affect what I prefer to use > for eliding. IOW, I'd rather keep it simple and just stay with "black" > as the default (or, even better, adding a defcustom). Yes... the colour you're aiming for here in the final image is probably unrelated to what your Emacs frame looks like, so perhaps using the frame background is even worse than just defaulting to black. Jean suggested defaulting to transparent, but I don't think that's what people would want here, either. >> I think I'll follow Stefan's suggestion to make it prompt with a prefix, >> and then move the SQUARE stuff into the function itself -- i.e., hit a >> key while cropping to switch to square mode. > > Sounds good, thank you. Now done. >> OK, I'll go with `image-cut', and move the key binding to `x'. > > FWIW, I like "image-redact" best here. That also alludes to how I > imagine one would use this. The problem I see with "cut" is that it > leads you to then think about how to "paste". I went with `image-cut' here -- perhaps we'll implement pasting later, if somebody finds that useful.