all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
Subject: Re: master b525f201ba: Allow specifying the color to use in image-elide
Date: Fri, 16 Sep 2022 11:08:28 +0200	[thread overview]
Message-ID: <87a66zznxv.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmm1MSzJWKrrk+=ux09KysA=PEWAXbtx+-qkO-QY98XrGw@mail.gmail.com> (Stefan Kangas's message of "Thu, 15 Sep 2022 00:28:41 -0700")

Stefan Kangas <stefankangas@gmail.com> writes:

> I don't think the current Emacs theme will affect what I prefer to use
> for eliding.  IOW, I'd rather keep it simple and just stay with "black"
> as the default (or, even better, adding a defcustom).

Yes...  the colour you're aiming for here in the final image is probably
unrelated to what your Emacs frame looks like, so perhaps using the
frame background is even worse than just defaulting to black.

Jean suggested defaulting to transparent, but I don't think that's what
people would want here, either.

>> I think I'll follow Stefan's suggestion to make it prompt with a prefix,
>> and then move the SQUARE stuff into the function itself -- i.e., hit a
>> key while cropping to switch to square mode.
>
> Sounds good, thank you.

Now done.

>> OK, I'll go with `image-cut', and move the key binding to `x'.
>
> FWIW, I like "image-redact" best here.  That also alludes to how I
> imagine one would use this.  The problem I see with "cut" is that it
> leads you to then think about how to "paste".

I went with `image-cut' here -- perhaps we'll implement pasting later,
if somebody finds that useful.




  parent reply	other threads:[~2022-09-16  9:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166317972871.8462.16344173364399917298@vcs2.savannah.gnu.org>
     [not found] ` <20220914182209.04F50C00872@vcs2.savannah.gnu.org>
2022-09-14 23:52   ` master b525f201ba: Allow specifying the color to use in image-elide Stefan Kangas
2022-09-15  5:47     ` Eli Zaretskii
2022-09-15  7:07       ` Lars Ingebrigtsen
2022-09-15  7:21         ` Jean Louis
2022-09-15  7:28         ` Stefan Kangas
2022-09-15  7:34           ` Eli Zaretskii
2022-09-16  9:08           ` Lars Ingebrigtsen [this message]
2022-09-16 14:42             ` Jean Louis
2022-09-16 15:14             ` Stefan Monnier
2022-09-18 10:30               ` Lars Ingebrigtsen
2022-09-15  5:58     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a66zznxv.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.