From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line Date: Sat, 17 Sep 2022 12:56:44 +0200 Message-ID: <87a66yclqr.fsf@gmail.com> References: <87illme7fe.fsf@gmail.com> <83sfkq1gu0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14617"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: public@protesilaos.com, 57876@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 17 12:57:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZVVW-0003d3-Hl for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 12:57:10 +0200 Original-Received: from localhost ([::1]:34658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZVVV-0004HK-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 06:57:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZVVO-0004Fv-Q8 for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 06:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46161) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZVVO-0001Zb-Hv for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 06:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZVVO-00056Z-4T for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 06:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 10:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57876 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57876-submit@debbugs.gnu.org id=B57876.166341221619608 (code B ref 57876); Sat, 17 Sep 2022 10:57:02 +0000 Original-Received: (at 57876) by debbugs.gnu.org; 17 Sep 2022 10:56:56 +0000 Original-Received: from localhost ([127.0.0.1]:45239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVVI-00056B-6p for submit@debbugs.gnu.org; Sat, 17 Sep 2022 06:56:56 -0400 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:34340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVVE-00055u-1H for 57876@debbugs.gnu.org; Sat, 17 Sep 2022 06:56:55 -0400 Original-Received: by mail-ej1-f45.google.com with SMTP id y3so54678950ejc.1 for <57876@debbugs.gnu.org>; Sat, 17 Sep 2022 03:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=YL47q2py8LXttNH32VvK6w1tAvGPVceRM0FVDOAHGvs=; b=V9IsxTzrSb0CcUQ4YpEDDYVb6w9jfPG6ZueyUu/u3OBE4kvfPtQhhaaGm+M1FSaECH pYZJtQhgJIBggJQNNfg7kD9YrFTkbb89YIOTpXZBVOyZtoJ5U/UX6gHYl6wY7FnnvkrR DarDzTZE4ADA9HZm3YfuBJe63kc1wVWlqtVk0Cl3lA7sY/+PDiRO4LpPDsSdp3GLCyvJ NYl6wmhkQw6avecroyolhwVehnqO3rpRm61iq/dzJXqm65Qawd/ARHXPKqW02X3KWO+G NDLCFP2N1od6ab+nyHPCclD4Dd3ynUKeEQ5W5uLButL7Db+LWQ26X+k6tufws/NgQQLp td9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=YL47q2py8LXttNH32VvK6w1tAvGPVceRM0FVDOAHGvs=; b=LS4cF4b2bLOMNhbylgtzxzICLWls2wTeQi89ylRYIMrpPEzI0lEnO0Aw+mOrg0QZ6I nvbNJAHe80SKTxc/xpGmXhVhisWcm0i5v7uadNZpRw6qkU3m4TkSOX+05opqZL4uHa3q iiVl+rFhU22wn4swmLm2Zjw0ph5jehljBOGRB/Tlku43zFTWOO8bI/na0XhIovSOt3yY y5PWxUV7xPJh1bwaCIeJnUwtk02pfL713+9J2wDewx9mcWymkBt302pBYDo6gZQKCWtb oWUVvY22WBJmjJvHgWlQhUOJtJZ5B1Td73AkoAP1kNtGUuKiltUy4fPL9DbQD2jzEsDI 0jsQ== X-Gm-Message-State: ACrzQf0XV+prvGUql8MU0yN3wYRMm4gDNb+A0GHwiqUVcvKXjX1PrVql wE38QmYn8ZhPXPyEuA0xMtAPbdMsG/0= X-Google-Smtp-Source: AMsMyM4UtvBa7qOrqOTPm/sRX3WPQjkfD7o7Mc8uNThcTmZuQbBqB6nshUzx9F+9ISgyDiaFVQr6xg== X-Received: by 2002:a17:907:7241:b0:780:1475:63ef with SMTP id ds1-20020a170907724100b00780147563efmr6213278ejc.391.1663412205992; Sat, 17 Sep 2022 03:56:45 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id c26-20020a056402101a00b0044792480994sm15432131edu.68.2022.09.17.03.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 03:56:45 -0700 (PDT) In-Reply-To: <83sfkq1gu0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Sep 2022 12:38:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242858 Archived-At: On Sat, 17 Sep 2022 at 12:38, Eli Zaretskii wrote: >> Cc: Protesilaos Stavrou >> From: Augusto Stoffel >> Date: Sat, 17 Sep 2022 10:23:01 +0200 >>=20 >> Tags: patch >>=20 >> Currently, if point is say at the prompt of a comint buffer, >> pulse-momentary-highlight-one-line doesn't show do anything =E2=80=93 or= , more >> precisely, it pulses the zero-length region from prompt end to EOB. >>=20 >> Prot: I think you want to apply a similar change in pulsar.el. >>=20 >>=20 >> >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001 >> From: Augusto Stoffel >> Date: Sat, 17 Sep 2022 10:17:34 +0200 >> Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line >>=20 >> * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line): Act on >> entire visual line, ignoring fields etc. > > Why don't you use beginning/end-of-visual-line? Because it obeys fields, so if you try to highlight a prompt line in a comint buffer, only part of the line would be highlighted. The (only, AFAICT) purpose of pulse-momentary-highlight-one-line is to locate the cursor, so you want to pulse a little rectangle spanning the entire width of the window.