From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50834: Feature request: cl-remove-method (prototyped) and buttons for it Date: Tue, 04 Oct 2022 14:19:44 +0200 Message-ID: <87a66b93xb.fsf@gnus.org> References: <8735pqq0yb.fsf@gmail.com> <87wnn2nkn6.fsf@gmail.com> <8735daxcxm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: akater , 50834@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 04 14:20:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofguS-0006Sd-RM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 14:20:28 +0200 Original-Received: from localhost ([::1]:53416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofguR-00063N-U3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 08:20:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofgu3-0005V1-0a for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 08:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53730) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofgu2-0004CH-Lr for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 08:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ofgu2-0006e1-Gl for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 08:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2022 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50834 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 50834-submit@debbugs.gnu.org id=B50834.166488599525524 (code B ref 50834); Tue, 04 Oct 2022 12:20:02 +0000 Original-Received: (at 50834) by debbugs.gnu.org; 4 Oct 2022 12:19:55 +0000 Original-Received: from localhost ([127.0.0.1]:52808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofgtv-0006db-1d for submit@debbugs.gnu.org; Tue, 04 Oct 2022 08:19:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofgtt-0006dM-Vk for 50834@debbugs.gnu.org; Tue, 04 Oct 2022 08:19:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Xo+wAPcoIxKL6HYoMkRwhz5FoiBINK2feufQ2B2xLKw=; b=JwwnWhBUTGRBgV9Ag/7SenMPz/ FMESGzkbCnl+Yn6NB/m91NgUKVorkR3ElLr0QUASo+RpBnULWSmrMQTPV5RAiv8EXE28WcLGQTqOV kDgCwHWCmUynStOM3rniTAHfVj1QVSQCGBqRZ2vyeHY3RI7yWY9lGi21uAd8iK4HzkyU=; Original-Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofgtk-0003gQ-TY; Tue, 04 Oct 2022 14:19:47 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 02 Sep 2022 09:29:16 -0400") X-Now-Playing: Peter Principle's _Sedimental Journey_: "The Anvil Chorus" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244418 Archived-At: Stefan Monnier writes: > Not much to say, except: > >> + (cl-loop for k being hash-key in cl--generic-combined-method-memoization >> + when (and (eq generic-function (car k)) >> + (memq method (cdr k))) >> + do (remhash k cl--generic-combined-method-memoization)) > > I don't see why we'd need this. > > This is a cache that tries to speed up the construction of combined > methods, whereas in `cl-remove-method` we should only need to flush the > cache that maps tags to their corresponding combined methods and this is > done implicitly by `cl--generic-make-function` (which returns a new > function with a branch new fresh cache). Akater, do you have any comments (or an amended patch)?