From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible. Date: Fri, 14 Oct 2022 20:10:02 +0800 Message-ID: <87a65y7git.fsf@yahoo.com> References: <166574864429.19305.16697125442242926452@vcs2.savannah.gnu.org> <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15502"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Vibhav Pant To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 14 14:14:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojJZx-0003qK-9f for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Oct 2022 14:14:17 +0200 Original-Received: from localhost ([::1]:56036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojJZw-0001QD-7K for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Oct 2022 08:14:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojJW5-0007Kb-97 for emacs-devel@gnu.org; Fri, 14 Oct 2022 08:10:17 -0400 Original-Received: from sonic317-34.consmr.mail.ne1.yahoo.com ([66.163.184.45]:46769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojJW3-0008UR-Gy for emacs-devel@gnu.org; Fri, 14 Oct 2022 08:10:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665749413; bh=SFwGnVeao4qyYzBAcrkZoatMDWR/t/BdRtzVhXlFX0g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Rv/HjPt4HIViFln+JzKXo3Swr8zdPYvooRUMC4HpqqoNJ1ny3D+Pxxuqgy1BwxXrLVmKBdhyHQhK40bvIJ5OObhkO0XZkKyXp1XjQs6J93J4S6z6MiDyGDZOdPzrBNt4me+UQWWBZQbNfQf8esD9m/c7lx7B8ngTo2kCX50GJYLSnvzTDMUJ0vM4j+zqkLL5WJxFLSXTYhGaPf1Fk+TaaVMyOGUbu0ZzcYuSuR6C7BeuKTGHEpySR9gSMKk09xlnzir2MDJdjUAR7LxUbp3VBGPytP6OmPu+ZrAHSKEwOS0u9POrfJ6eb+4NauIvDp1IFYGMBkAG2IDcohBO9g2/eA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665749413; bh=3vstBChJ8ccpaG5l00CYQJOlaN3/BHmEMiNNojTB8xC=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=QtxHjqTVZHH5ZwVqX842rbGQzOaiXDQmPKnY0P6abBvh21mjrn8rR2dGYXkayEgmbQFGWwZT1Doejbld0v363fk26KwnRASGZjm1GFqmi6i0Uj2pWNedKL7rCje5YIY8Zew30SRj4eJQZpIXBvicyQw6N0ArOOLBr2/zytPKN3fSbMLiWKZXi3BSNxfmWAl3DYINiwaMTclcVk49sD0rYwOVhdUaT4by0EaPl3tL2KTerT8v8iPEm/24cwgfVGqGxNakd8SIStNkVzEGDL0GYMygtI3a8dqHfOAxAEpYhsb7e2c8JcZ62g8RJkWeIrtpIfl7bOZSpVP7iJK90TpE7g== X-YMail-OSG: YsjdEfUVM1mtiF66tFRFrSnaFFnvTBCHl_uEapOAbIuzhaeXTjSd9pAmnff.vFF .mk4UtSJv_UMvzCJ7t8JV2sdJnTXHMMuXCi6ASGzyBb_rt28HPF_NZDYEGScsaIbjKScRmggBV6b V8pFfU7H4w0xXVLDSJchyXMKtNoTH.GOi_e_GUPcAtAyl6OywxC5QOfwhx3dGL0ViEHWtwv_aHcU KQ5yEAdohGtwEzTOGwZPa7ouyziyBiKMNxp2u0oqroLAI6B5.qAs0vt6TTHpnMp1bqEPr6rnfr5Z WJbjeuVtHAVZn91NS5JyUtoF7ciB0ip5scPLpz0kfFeQ9aCFsihVlYqA89dkkHiln1rePm3by1i7 3ucUoqAvbJFs2UACIn5GTG.IKy6So7J7QajaSCB37jIaXq86pncHXyEAjPlV1hRzrE7jx0UN3HFY gI2p._EHXnIRJH38KbiWYrGnjv4XelD1jrdYEoN0U_1r_wwvf.75xfpot7lAh5TrEK4pDD5isjE8 ooLo_7YdL9pZuJvbadfKVU9Jnr1L_eR5FbMGolN1KO.SPqbeUoMigG1L2IC277yqnsRJD5DypZkn S7XEs9YxpM78KNxQsqVL.WN6KMdcUc3.IrgkKJTWKZqxxmsSx1QgUSDKGX6Ep9yzyiP.GR4AWw7C QVZ1Ds3mjyzoL5oFPPndHS08sdDGQCvUAi96y8AZy9QSK4WRds0fAOMd3ks9XBAwTfHd.yd73rT6 HQP74Y51AY1jqsWKLbQLL1J3TPXLhbQUn_xAncryGE3q2cuhYUfmTVaJ33wRRwbYTt_LPpYn7UJV j4er27JVtm4Ei3OuWvoClJUN2lYHjFNOoAN7U.jM3U X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Fri, 14 Oct 2022 12:10:13 +0000 Original-Received: by hermes--production-sg3-785466d859-nwhwd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 15494d0c47f9e2b2dd5dbaddc12659e8; Fri, 14 Oct 2022 12:10:08 +0000 (UTC) In-Reply-To: <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Fri, 14 Oct 2022 07:57:24 -0400 (EDT)") X-Mailer: WebService/1.1.20754 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.45; envelope-from=luangruo@yahoo.com; helo=sonic317-34.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297719 Archived-At: Vibhav Pant writes: > branch: feature/comp-use-ctors > commit 1b48e8dde5bfee65c036fbfdc32b68c9093c2e06 > Author: Vibhav Pant > Commit: Vibhav Pant > > src/comp.c: Use constructor expressions when possible. > > * src/comp.c: > - Add declarations for creating constructor/initializer expressions > when supported. > - (emit_coerce): Use a struct constructor expression to create a > Lisp_Object value instead of creating a new local variable. > - emit_limple_call_ref: Emit a single constructor expression for > initializing tmp_arr. This is not how we write commit messages; it should be: * src/comp.c: Add declarations for creating constructor/initializer expressions when supported. (emit_coerce): Use a struct constructor expression to create a Lisp_Object value instead of creating a new local variable. (emit_limple_call_ref): Emit a single constructor expression for initializing tmp_arr. Keep in mind that the commit message must also be filled to 64 columns.