From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Wed, 19 Oct 2022 12:29:11 +0000 Message-ID: <87a65s3sko.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87bkqmqpvb.fsf@posteo.net> <871qris3xb.fsf@gnus.org> <877d1aqoc1.fsf@posteo.net> <87edvhqdrb.fsf@gnus.org> <871qrh2hh6.fsf@posteo.net> <87mta5oyec.fsf@gnus.org> <87sfjx10x1.fsf@posteo.net> <875ygsp0ng.fsf@gnus.org> <87h70c9bu4.fsf@posteo.net> <874jw73cjy.fsf@posteo.net> <87edv72z11.fsf@posteo.net> <87czaq1i3k.fsf@posteo.net> <87fsfkhnhm.fsf@posteo.net> <87mt9s47f1.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31128"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 19 14:35:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ol8I5-0007nM-GP for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 14:35:21 +0200 Original-Received: from localhost ([::1]:49634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ol8I4-0003JI-6N for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Oct 2022 08:35:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol8CL-00007X-QO for emacs-devel@gnu.org; Wed, 19 Oct 2022 08:29:26 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:48641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol8CJ-00069p-MU for emacs-devel@gnu.org; Wed, 19 Oct 2022 08:29:25 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4C110240026 for ; Wed, 19 Oct 2022 14:29:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666182560; bh=GMpESxfLPWuMJ09rTR5jPfNRhsPSv2F/lyjoyC0+F54=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=RRnwfoNMBj3I3aHBZe1N9K7GOAImgeTbwTVkrwf7G5F5YNpySmnX2bSelmekJ8Zce uECBBfRkTSPAcYQjqHRZiSxPdaXiY5Mc5+mxsvT+raneXhj6egv6BRGVrAZc5cmlrT fosvb7SVinW/hkBLk+xrzhuVt9nIAeONB3kuM7HVG2Y0X1o5SAetYQira3aDoXTR2U uNVQ1c7Xvb34/mFGSNhNL4lwHfwRK5cP/kIfo25u80v6vfxpi3dOsu7tcjH8FDk5Rr BCsmrX+YqTiBl8v71V28yxtnRB6VPCIwirV39GP25UayfBvDp/va76r0LOTfO31fSL aKmtorJmzXPCA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MsqmH2zpFz9rxk; Wed, 19 Oct 2022 14:29:19 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Wed, 19 Oct 2022 08:19:32 -0400") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298114 Archived-At: Stefan Monnier writes: > Philip Kaludercic [2022-10-19 07:08:34] wrote: >> Stefan Monnier writes: >>>> I have pushed a first draft and it appears to work. It doesn't yet >>>> handle all attribute (such as :doc), but that should be doable when I >>>> find the time. >>> Side note: installing packages from Git (like what you're implementing >>> in the `package+vc` branch) is already one of the functionalities >>> supported by `elpa-admin.el` so it would be good to try and share/reuse >>> that code as much as possible. >> That is only possible insofar I don't have to rely on Git features, >> since package-vc intends to be VC-generic. > > I'm thinking of things like the code that handles `:doc` or `:make`. > These don't care about Git. > > I don't think that the code in `elpa-admin.el` can be used as-is, but it > would be good to try and change them in tandem (maybe by extracting the > common code into some new file?). The only thing is that we will probably need to prompt the user if they are OK with executing some command or using Makefile, right? I can try to re-use elpa-admin.el but the code will then have to be wrapped for "regular" use by some safety precautions. >>> Actually part of `elpa-admin.el` might also be helpful for the >>> ELPA-bundling feature. >>> So we should move more of `elpa-admin.el` into Emacs's own code. >> As part of `package-vc' or as a new module? > > I think either way is fine. The whole `elpa-admin.el` contains things > that are irrelevant to Emacs itself, so we'll likely keep a separate > file like that, but the code that's useful for other uses > (i.e. package-vc and/or bundled-ELPA) should be moved out (tho > elpa-admin.el has to be backward compatible to some extent, so we'll > have to keep a "local" copy of whatever is moved to a common file > hosted in emacs.git, at least for a few years). Sounds good. I'll first try and see if the code can be added to package-vc.