From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58799: Make winner key sequences repeatable in repeat-mode Date: Mon, 31 Oct 2022 15:25:02 +0100 Message-ID: <87a65coytd.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> <871qqss31s.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18357"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 31 15:26:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opVkK-0004ax-0z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Oct 2022 15:26:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opVjp-0003gO-QZ; Mon, 31 Oct 2022 10:26:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opVjo-0003dm-Da for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 10:26:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opVjn-00047D-UH for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 10:26:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opVjm-0003hj-CW for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 10:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58799-submit@debbugs.gnu.org id=B58799.166722631314181 (code B ref 58799); Mon, 31 Oct 2022 14:26:02 +0000 Original-Received: (at 58799) by debbugs.gnu.org; 31 Oct 2022 14:25:13 +0000 Original-Received: from localhost ([127.0.0.1]:41456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opViy-0003gf-S4 for submit@debbugs.gnu.org; Mon, 31 Oct 2022 10:25:13 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:43679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opViw-0003gP-Km for 58799@debbugs.gnu.org; Mon, 31 Oct 2022 10:25:11 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id g12so16198579wrs.10 for <58799@debbugs.gnu.org>; Mon, 31 Oct 2022 07:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YhgJhgOYndEfRgZyGgNmm13URXT+qyR+fx21bJPv9e4=; b=LXKRKcTa9ymPz9F1jOBgoIhZf19gIVmM7xb2AuBRQqX3MpNGK5afZSuimdpDf8/H9d UsagiVU4d/r1PdOkN0+qoKTGYYvwtnh94imff57jmxd0mBmv3USV9xqu6Wb7xK1gGJow DY5QbJg21o2xmbKTSTZ3bhzQfJmegFrAJd/VpY93LLy6yifX4JIyKZD5JeEg2u8MTCv3 8apN4xAWwJfYOfLi9V6WNUdvsSzQQXazg3LS3LwTzpHcBYUz1OvkdQJvyEey6AsaT+Cv Ne727j9TilwcZfCYDxt2gmaGUHeQzmU8bgilkJmqdfmO1BK7W7O+3vVx99+mfzQthG/X r16w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YhgJhgOYndEfRgZyGgNmm13URXT+qyR+fx21bJPv9e4=; b=kC8gUmYdzTAqQdjC+xV+S/SVlZDUM3xiU7KpRZshw2O0I1SFZcsD3oZGEXNshj0d4r XKytGdVkgiaTZ/AlX9D5Ip4KTQOkKQS7ffuuhgcuGHRsCzjA9pFBjUFQHJC3CMeXiGQ6 9ERQC4s6FdDMf27MsRfH+r5cuqqhWoRf0iwSWh3RZmop1LGt9TpiNHgVASmwIl6alv6b fM20gduAcYyXEwYVuQiTClvndI7P8YK1mB/Z68Z1kC/NDczR4S6EHZpv3OkYNxtbK4gt qIda0vdfJGZ2zL8RmtzfNgEikzaoPm82pODHxyYQYOQs2u2BNNohW838J52TGmaNNY/6 Gxdw== X-Gm-Message-State: ACrzQf3GBK9nQNvPrfZ6NVr9+QMfR+X2UPVlShxKNmEtKCXAHd14aLGS NetiaJhcqetK/n0ThhiwcAoFYE+/uRg= X-Google-Smtp-Source: AMsMyM6/O5+aT8vSqrHiDgdohy6i8Z55VPGL+9xW/Ynzy1XrT1/HI4tQ+0nd1HuTYPgSlNa5RNK0RQ== X-Received: by 2002:adf:8bc4:0:b0:236:73b7:84a with SMTP id w4-20020adf8bc4000000b0023673b7084amr8157415wra.8.1667226304334; Mon, 31 Oct 2022 07:25:04 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id j3-20020a05600c1c0300b003b4ff30e566sm26051439wms.3.2022.10.31.07.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 07:25:03 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Fri, 28 Oct 2022 08:41:37 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246691 Archived-At: >>>>> On Fri, 28 Oct 2022 08:41:37 -0700, Stefan Kangas said: Stefan> Robert Pluim writes: >> (defvar-keymap footnote-minor-mode-map >> :doc "Keymap used for binding footnote minor mode." >> (key-description footnote-prefix) footnote-mode-map) >>=20 >> That=CA=BCs perfectly valid, but fails with the above patch unless we >>=20 >> 1. Check (key-valid-p (eval key)) >> 2. Add an autoload cookie for footnote-minor-mode-map >>=20 >> That seems too high a price to pay for avoiding the original problem. Stefan> Hmm, that's a too high price to pay. Stefan> Could we check for some common mistakes without having to say `= (eval Stefan> key)' though? For example by requiring KEY to be Stefan> (or (stringp key) (listp key)) People also do things like this: (defcustom pong-left-key "4" "Alternate key to press for bat 1 to go up (primary one is [left])." :type '(restricted-sexp :match-alternatives (stringp vectorp))) . (defvar-keymap pong-mode-map :doc "Modemap for pong-mode." :name 'pong-mode-map pong-left-key #'pong-move-left so I=CA=BCm inclined to either fix it in `define-keymap' only, or just let the existing compiler macro for keymaps handle it. In any case, I think we can close this particular bug. Robert --=20