From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer fails when Eglot is running Date: Wed, 02 Nov 2022 07:34:51 +0000 Message-ID: <87a659u7vo.fsf@gmail.com> References: <87sfj8umwb.fsf@posteo.net> <87a65f3j40.fsf@posteo.net> <213f3549-de4e-25a7-5e27-d13893e557bc@yandex.ru> <87zgdfwkle.fsf@gmail.com> <8e31a89d-e35e-6dd0-a8e3-f0b9684c8bfa@yandex.ru> <87v8o3wgq1.fsf@gmail.com> <87ilk2x1si.fsf@gmail.com> <871qqq7l9p.fsf@posteo.net> <87eduqwekz.fsf@gmail.com> <87wn8invbx.fsf@posteo.net> <877d0iw8iq.fsf@gmail.com> <837d0hhlke.fsf@gnu.org> <46ff0065-5645-ef1e-2621-242fb6a73f98@yandex.ru> <87v8o0uxn5.fsf@gmail.com> <787a4362-7ff5-7dbb-9118-16e4bee5f328@yandex.ru> <87edunvhf2.fsf@gmail.com> <6d4d9e72-1bae-4d64-b7c1-c2b9c11e396f@yandex.ru> <6c9811d7-ad05-2d2d-0c34-9b4c1fa09305@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15667"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: philipk@posteo.net, Eli Zaretskii , manuel.uberti@inventati.org, 58839@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 08:34:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oq8GI-0003u3-FK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 08:34:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oq8GC-000473-2o; Wed, 02 Nov 2022 03:34:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq8GA-00046w-Eu for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 03:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oq8GA-0004lK-7e for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 03:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oq8G9-00018R-Uv for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 03:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 07:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58839 X-GNU-PR-Package: emacs Original-Received: via spool by 58839-submit@debbugs.gnu.org id=B58839.16673744284343 (code B ref 58839); Wed, 02 Nov 2022 07:34:01 +0000 Original-Received: (at 58839) by debbugs.gnu.org; 2 Nov 2022 07:33:48 +0000 Original-Received: from localhost ([127.0.0.1]:44827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq8Fv-00017y-GI for submit@debbugs.gnu.org; Wed, 02 Nov 2022 03:33:47 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:42809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq8Ft-00017j-KL for 58839@debbugs.gnu.org; Wed, 02 Nov 2022 03:33:46 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id cl5so11556813wrb.9 for <58839@debbugs.gnu.org>; Wed, 02 Nov 2022 00:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hkBlhjHAmwcH5wsKSvAtTfPSwxRvtlbHQBFpwqGDRRk=; b=iu2xOOC1sTx5aSZCjDrRq+GCjSZ9dJ7iJZnWivAbRgG+oxlh+706uxJEw2mvC6ZumI BNh0YaJqAxSOBdfR0gfqJyVNDPaKCt6h2CgAR7o5wkQa7SnlJR6iYCSq++TFtocy36MJ q1tjUU247Cps2WNiyMziTGq7XwV7sfZZl3NhW/mDZ0extVLr4I8I8320zm8+YQl+P8DH SBMqGT7hWehnPCxWHCiveulEB7bM1aDxWc+2qv0+e0vcUygd9VwRObXOKDO9pw/e4ReY i2C2UkKthIpXPTTHQXeJRo+qXrcCUKWy+Gqelgd4k4w9RjbR9Qzhix/kGJM58HaNYpND d2Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hkBlhjHAmwcH5wsKSvAtTfPSwxRvtlbHQBFpwqGDRRk=; b=P8jxXJygCflGpTy8fYTtiQbk7Gjwvu7AizKANnk/3grXEly0ypR3HLSlvUg9skINwy EaHgjmHw1GdpW9FI4Zf6ummbs66mEasSsqvUF2RXO3LSap4hfXZkRnv1gN2P0L7Y54t9 e6a1oaF8zIsb0+L5hfskP/m89U33sfWwwq1xv2GHzol6mIKKndeGq9lxZ2f8ybtjFnQ8 BHWhArfI9cLJ8Ce39ufXUJqS9NfvE1OxhoHcoDwKRrHR3R/Vfn84G8/KPGKhUXz7HfiY gbwPLqFeJtQI51xYHm0oJkpq2DHMp/TuuuWefS2o7NFrrtfI4IWHLwxx2usXZztI1j0q IL/Q== X-Gm-Message-State: ACrzQf0jBoN9r/vljvzgVPm8VVYog1dbbH4RxlxcPP3/8hnHHboYLas2 0jaRF7OeXYClm1xicxPw66k= X-Google-Smtp-Source: AMsMyM4ei06dbaNaak3aHBKTTrk4fTWansaRpe3L8xFCz6mrvBJTqfT3t49B5wn6IxPiWxLIJUYAaw== X-Received: by 2002:adf:ab1d:0:b0:236:6301:c77 with SMTP id q29-20020adfab1d000000b0023663010c77mr13765297wrc.119.1667374419806; Wed, 02 Nov 2022 00:33:39 -0700 (PDT) Original-Received: from krug ([87.196.81.36]) by smtp.gmail.com with ESMTPSA id r17-20020a05600c459100b003c7087f6c9asm1304919wmo.32.2022.11.02.00.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 00:33:39 -0700 (PDT) In-Reply-To: <6c9811d7-ad05-2d2d-0c34-9b4c1fa09305@yandex.ru> (Dmitry Gutov's message of "Wed, 2 Nov 2022 00:23:11 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246844 Archived-At: Dmitry Gutov writes: >> I've explained to Philip objective reasons why I think evaluated >> mini-languages are almost always inferior to a decent Lisp such as Elisp. >> You could perfectly reasonably deprecate these two variables. > Not where this discussion is going, is it? Not sure. This started has a report of hidden buffer being incorrectly killed by project.el. After much insistence, you've agreed to plug the hole in that library. During tests I also discovered that project.el is killing other buffers nonsensically, like Gnus buffers, *ibuffer*, and many other global. It was actually easier to find false-positives of your heuristic than true ones. Again, after some insistence, you seem to have come around that these things represent bugs. Three people here have suggested an opt-in approach for the true positives. Now your strategy seems to be "OK: let all these false positives remain nonsensically associated with a project in project-buffers but let's have global databases of exceptions for specific operations, using a (largely redundant) mini-language for buffer-matching". If that doesn't sound like a bad idea in the face of much better other ideas, I don't know what else to tell you. >> > I'm fairly sure that the solution I offered would be easy enough >> > implement, to actually protect the vulnerable buffer. >> > I suppose we are not doing that, however. >> You sketched an untested code-less idea and I explained how flawed >> it was. > > Back atcha. Modulo "code-less". Not only did I provide code, I also verified that it works. Anyone can see my messages to verify that. Jo=C3=A3o