From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: CC Mode -> Tree sitter challenge Date: Sat, 05 Nov 2022 17:38:00 +0100 Message-ID: <87a655xspj.fsf@thornhill.no> References: <87v8nu1mt1.fsf@thornhill.no> <83eduh4vcf.fsf@gnu.org> <87mt951r69.fsf@thornhill.no> <83tu3d34u7.fsf@gnu.org> <87eduhxy9l.fsf@thornhill.no> <83pme130xs.fsf@gnu.org> <717833B0-285B-460F-B37B-F0B215BD1185@thornhill.no> <3A13DCFD-3306-492B-8022-DCE95EC340A3@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, monnier@iro.umontreal.ca To: emacs-devel@gnu.org, Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 05 17:38:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orMC7-000AVt-Qd for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Nov 2022 17:38:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orMBQ-0002Bp-Ea; Sat, 05 Nov 2022 12:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orMBO-0002BH-Ax for emacs-devel@gnu.org; Sat, 05 Nov 2022 12:38:10 -0400 Original-Received: from out0.migadu.com ([2001:41d0:2:267::]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orMBL-0001wV-LH; Sat, 05 Nov 2022 12:38:10 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1667666282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VqFvwC+eaV0K9dhooUE5sK9A8W5tMUyi4M0sm2MH570=; b=a1U2ocF4PuZZrpzVUaiKOwlwQh14Xtx9sLUAvXvAFnsh76rwyAeDIr2wuPr8IX9JWgBvW4 ByN7RaaA4L8b2mBzYJu1IYt5FxgFdloioAvVDNseai+P9n7izfPbFkdQB4xJMjxqCsOL6N r/OY47R47VSMwpvws629LMhoGaijHaWsz5Oa1C0bh9dh98GX7TYX951vNe+XE9ZJPKGKOE P3tJ/M5u6ZM/MqpkuWhzalH/iTWZcpmIBGZECDsNq0MF+5ZQDCpK3kdNaFFHo+T7Vtx7c+ FMX1N1FmQZI5MQKGH7BW4qwcInR3auBsxVtmYN2pckFNUjDz40lYljkFMLLHGQ== In-Reply-To: <3A13DCFD-3306-492B-8022-DCE95EC340A3@thornhill.no> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299215 Archived-At: Hi again, Eli! >> >>Interesting. My guess is that there are still some improvement possible in the indent-region code, considering that part of treesit.el is quite new. >> >>What do you think, Yuan? Any thoughts? >> >>Anyways, I'll keep working on this and see how far I get next coming weeks. At least in performance it seems I have a good thing going here :-) >> > > Thinking of it, some of the indentation questions isn't compiled. I'll run it again later when they are compiled as well :-) > Yes, that was the issue. Now the scores are as follows: ;; C-MODE ;; scroll-up-benchmark ;; 1: GCs: 402 Elapsed time: 17.499269 seconds ;; 2: GCs: 415 Elapsed time: 17.789382 seconds ;; scroll-up-by-40-benchmark ;; 1: GCs: 420 Elapsed time: 19.183639 seconds ;; 2: GCs: 420 Elapsed time: 19.377480 seconds ;; xdisp-eob-benchmark 100 ;; 1: (40.992420494 1708 16.708356162) ;; 2: (40.630712261 1711 16.361947911999998) ;; xdisp-eob-benchmark 1 ;; 1: (0.482883063 21 0.19676500600000002) ;; 2: (0.478595514 21 0.19573110300000002) ;; scroll-up-insert-quote-benchmark ;; 1: GCs: 558 Elapsed time: 41.747822 seconds ;; 2: GCs: 557 Elapsed time: 41.976805 seconds ;; xdisp-indent-benchmark ;; 1: (14.323358754000001 898 7.6331590500000015) ;; 2: (14.027956779 900 7.438876509) ;; 3: (13.631917978 904 7.006082581) ;; C-TS-MODE ;; scroll-up-benchmark ;; 1: GCs: 21 Elapsed time: 6.997570 seconds ;; 2: GCs: 27 Elapsed time: 7.239952 seconds ;; scroll-up-by-40-benchmark ;; 1: GCs: 30 Elapsed time: 8.869021 seconds ;; 2: GCs: 29 Elapsed time: 9.076617 seconds ;; xdisp-eob-benchmark 100 ;; 1: (15.083917789 20 1.1350005760000001) ;; 2: (15.213992551999999 21 1.121564519) ;; xdisp-eob-benchmark 1 ;; 1: (0.19189711499999998 1 0.011011572999999997) ;; 2: (0.185749092 1 0.011173242) ;; scroll-up-insert-quote-benchmark ;; 1: GCs: 29 Elapsed time: 15.450495 seconds ;; 2: GCs: 29 Elapsed time: 12.168593 seconds ;; xdisp-indent-benchmark ;; 1: (1.253069432 12 0.4284672389999997) ;; 2: (1.35523601 12 0.47415286799999734) ;; 3: (1.416845475 12 0.49072914899999986) > >>Theo >> -- Theo