all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Juri Linkov <juri@linkov.net>
Cc: 59141@debbugs.gnu.org, "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Subject: bug#59141: 28.1.90; Face :extend when all the line but trailing \n is invisible
Date: Thu, 10 Nov 2022 01:36:14 +0000	[thread overview]
Message-ID: <87a64zlhf5.fsf@localhost> (raw)
In-Reply-To: <865yfovz6f.fsf@mail.linkov.net>

Juri Linkov <juri@linkov.net> writes:

> Here is an experimental patch for outline.el
> that demonstrates a possible way to fix this:
>
> diff --git a/lisp/outline.el b/lisp/outline.el
> index a646f71db8..73ae707821 100644
> --- a/lisp/outline.el
> +++ b/lisp/outline.el
> @@ -930,7 +930,8 @@ outline-flag-region
>      ;; We use `front-advance' here because the invisible text begins at the
>      ;; very end of the heading, before the newline, so text inserted at FROM
>      ;; belongs to the heading rather than to the entry.
> -    (let ((o (make-overlay from to nil 'front-advance)))
> +    (let ((o (make-overlay from (1+ to))))
> +      (overlay-put o 'display "\n")

Note that 'font-advance is there for a reason.

Also, what will happen with ellipsis when there is 'display property?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>





  reply	other threads:[~2022-11-10  1:36 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09  2:24 bug#59141: 28.1.90; Face :extend when all the line but trailing \n is invisible Ihor Radchenko
2022-11-09  7:49 ` Kévin Le Gouguec
2022-11-09 12:36   ` Eli Zaretskii
2022-11-09 17:12   ` Juri Linkov
2022-11-10  1:36     ` Ihor Radchenko [this message]
2022-11-10  7:45       ` Juri Linkov
2022-11-11  1:58         ` Ihor Radchenko
2022-11-11  7:46           ` Eli Zaretskii
2022-11-12 12:44             ` Ihor Radchenko
2022-11-11  8:13           ` Juri Linkov
2022-11-13  4:31             ` Ihor Radchenko
2022-11-11 12:30           ` Al Haji-Ali
2022-11-11 12:42             ` Eli Zaretskii
2022-11-11 16:00               ` Al Haji-Ali
2022-11-11 17:34                 ` Eli Zaretskii
2022-11-11 19:47                   ` Abdul-Lateef Haji-Ali
2022-11-11 20:09                     ` Eli Zaretskii
2022-11-11 20:17                       ` Abdul-Lateef Haji-Ali
2022-11-11 20:25                         ` Eli Zaretskii
2022-11-12 11:18                           ` Kévin Le Gouguec
2022-11-12 17:46                             ` Juri Linkov
2022-11-13 10:50                               ` Kévin Le Gouguec
2022-11-13 17:53                                 ` Juri Linkov
2022-11-13 22:22                                   ` Kévin Le Gouguec
2022-11-14  7:43                                     ` Juri Linkov
2022-11-14 11:02                                       ` Kévin Le Gouguec
2022-11-14 17:32                                         ` Juri Linkov
2022-11-14 17:44                                           ` Eli Zaretskii
2022-11-15  8:02                                             ` Juri Linkov
2022-11-15 14:42                                               ` Eli Zaretskii
2022-11-15 15:01                                                 ` Ihor Radchenko
2022-11-15 15:05                                                   ` Eli Zaretskii
2022-11-16  1:38                                                     ` Ihor Radchenko
2022-11-16 13:01                                                       ` Eli Zaretskii
2022-11-20 18:42                                                       ` Juri Linkov
2022-11-14 22:22                                           ` Kévin Le Gouguec
2022-11-20 18:38                                             ` Juri Linkov
2022-11-22  7:52                                               ` Juri Linkov
2022-11-22 15:02                                                 ` Eli Zaretskii
2022-11-22 17:35                                                   ` Juri Linkov
2022-11-22 18:42                                                     ` Eli Zaretskii
2022-11-22 19:16                                                       ` Juri Linkov
2022-11-22 19:36                                                         ` Eli Zaretskii
2022-11-12 17:52                           ` Juri Linkov
2022-11-12 18:31                             ` Eli Zaretskii
2024-01-25 22:53   ` Ihor Radchenko
2024-01-26  7:08     ` Eli Zaretskii
2024-01-26  7:08       ` bug#52587: " Eli Zaretskii
2022-11-09 12:29 ` Eli Zaretskii
2022-11-09 22:19   ` Kévin Le Gouguec
2022-11-10  7:10     ` Eli Zaretskii
2022-11-10 23:41       ` Kévin Le Gouguec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a64zlhf5.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=59141@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=kevin.legouguec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.