From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#58985: 29.0.50; Have auth-source-pass behave more like other back ends Date: Mon, 14 Nov 2022 19:32:37 -0800 Message-ID: <87a64s99ka.fsf__16445.8675588079$1668483201$gmane$org@neverwas.me> References: <87wn8cb0ym.fsf@neverwas.me> <874jvdardn.fsf__3771.40490324877$1667692584$gmane$org@neverwas.me> <87pme09vis.fsf@gmx.de> <87a653z7dl.fsf@neverwas.me> <878rkjl1vd.fsf@disroot.org> <877d026uym.fsf@neverwas.me> <87tu35eehq.fsf@disroot.org> <87bkpcu74w.fsf@neverwas.me> <875yfkdwlm.fsf@disroot.org> <874jv3nwmc.fsf@disroot.org> <875yfiq3d8.fsf@neverwas.me> <87mt8uvxkp.fsf@disroot.org> <877czxlgd4.fsf@neverwas.me> <87edu5toi6.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21406"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Damien Cassou , =?UTF-8?Q?Bj=C3=B6rn?= Bidar , emacs-erc@gnu.org, Michael Albinus , 58985@debbugs.gnu.org To: Akib Azmain Turja Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 04:33:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oumhF-0005Kf-A2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 04:33:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oumh5-0002u3-Q2; Mon, 14 Nov 2022 22:33:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oumh5-0002sc-2B for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 22:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oumh4-0006JH-Q7 for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 22:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oumh4-0007BR-MQ for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 22:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2022 03:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58985-submit@debbugs.gnu.org id=B58985.166848317027593 (code B ref 58985); Tue, 15 Nov 2022 03:33:02 +0000 Original-Received: (at 58985) by debbugs.gnu.org; 15 Nov 2022 03:32:50 +0000 Original-Received: from localhost ([127.0.0.1]:52442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oumgr-0007Ay-I5 for submit@debbugs.gnu.org; Mon, 14 Nov 2022 22:32:49 -0500 Original-Received: from mail-108-mta186.mxroute.com ([136.175.108.186]:39675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oumgq-0007Al-Jw for 58985@debbugs.gnu.org; Mon, 14 Nov 2022 22:32:49 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta186.mxroute.com (ZoneMTA) with ESMTPSA id 184795899c10006e99.002 for <58985@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 15 Nov 2022 03:32:40 +0000 X-Zone-Loop: 9700a4dabcedb94725e15624755049abedd137a8b411 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uCbAlc1mP23bwHoCmNctt7oaoBPkilqTeBejXwfZnVA=; b=VUoaR91bPJ+RpkM1qQn0H1bY6D nUC5N3tVpoPHOSzeTvoSFUO/lEjxY/DuK0o7KHTf8ha27VHhw8RGQhisrJGoePt4ug1qWuQR4l0f4 O5OB0DCMdhjWeLFkrGD+hoDRDFNTjhSd8NoRM7F1MzcNquQeyWw09UpXVUzaCYMln7Yhc4HnVUMUl yvR/+MpOQwBXz7X1JVGWwYsY+yRKoakezTdGn6zcAaFzCs/JcIt+lceFQOf8KGqdahIp8PlFIdrqt Q91wPVloRHbjJPdbeZNMmT0tCFTamXFdiGf74kiWTF8TFadG2NDcAXRjQH/bXMBLZshuCFjQhdupW n2hrzOsA==; In-Reply-To: <87edu5toi6.fsf@disroot.org> (Akib Azmain Turja's message of "Mon, 14 Nov 2022 23:49:37 +0600") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247906 Archived-At: Akib Azmain Turja writes: >>> I suggest to prefer the "@" syntax over "/user" syntax. >> >> I have tried tweaking things in that direction. But as far as >> deprecating the /user form officially: that seems more like a group >> decision. And then there's the question of how to express such a policy. >> Should we emit a warning? At the very least, it would need to be >> documented somewhere. > > No, I didn't say to deprecate that syntax, the syntax makes much sense. Oh, well then pardon my inferring that. But without deprecation, we'd need to somehow "encode" the @-wins behavior into the interface with documentation and tests, which is usually more complex than it first appears. Otherwise, we can just treat @ favoritism as an implementation detail not subject to preservation come some future rewrite or major overhaul. As things stand, this patch mostly takes the latter approach (tests aside). > I'm suggesting to return "USER@HOST" if both "USER@HOST" and "HOST/USER" > are present, because the former makes more sense. Right, I guess you didn't bother trying out the latest changes attached to my previous email, which is fine. The thing I'd like to stress here (mainly for posterity) is that the degree to which we demote/defer candidates of the / form is deliberate. The way I have things now gives search order primacy over @-vs-/ contention, meaning a search tree like h g / @ / @ 1 2 1 2 1 2 1 2 and params like :host '("h" "g") :port 2 :max 5 gives @h:2, h:2/, @g:2, g:2/ whereas full demotion (not implemented) would yield @h:2, @g:2, h:2/, g:2/ IOW, if you omit the :port 2 part, you currently get @h:1, @h:2, h:1/, h:2/, @g:1 which is likewise expected. Basically, the current search strategy adheres more closely to how the other back ends operate and is thus preferred. >> Anyway, this is useful analysis. Thanks again for all your help. > > When are you going to install this? It's definitely an improvement over > the one in master, and doesn't have any problems to block it. > Installing it will also expose it to more users to the change, so this > will get even more testing. I am willing to install this but am not really comfortable enabling it by default unless the maintainers of the downstream packages (Cc. Bj=C3=B6r= n) can promise to report any problems while Emacs 29.1 is still unreleased. Without such a pledge, I'm inclined to just leave it disabled. Thanks.