From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] 11 new packages! Date: Mon, 28 Nov 2022 19:42:14 +0000 Message-ID: <87a64aeui1.fsf@posteo.net> References: <87r0y6ug9z.fsf@disroot.org> <87y1sct2hp.fsf@posteo.net> <87k03vf5m8.fsf@disroot.org> <87edu2narn.fsf@posteo.net> <8735aieqtr.fsf@disroot.org> <87cz9mlq3o.fsf@posteo.net> <875yfdd5ad.fsf@disroot.org> <87wn7hh438.fsf@posteo.net> <87sfi5h3ne.fsf@posteo.net> <874julpgi4.fsf@disroot.org> <87v8n04o4b.fsf@posteo.net> <87cz98nxah.fsf@disroot.org> <87sfi2vqxe.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29635"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Developer List To: Akib Azmain Turja Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 28 20:42:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozk1o-0007Y4-6J for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Nov 2022 20:42:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozk1E-0000OI-CH; Mon, 28 Nov 2022 14:42:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozk1C-0000MG-Qm for emacs-devel@gnu.org; Mon, 28 Nov 2022 14:42:18 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozk1A-000370-Pt for emacs-devel@gnu.org; Mon, 28 Nov 2022 14:42:18 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 503EA240104 for ; Mon, 28 Nov 2022 20:42:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669664534; bh=iJ/NQEZ8tGswlY4u3AeqL1RyY4B9SonZirm5eJRDVok=; h=From:To:Cc:Subject:Date:From; b=HP/M4ftP/bn/Aq/g9jK2xvoP3oI1vWRQzBFmOjxCNEUqXwhlY9J72/KEbpy6oKTX2 8UPVmvoT6DyS/oiD9MRo895D99XtbPZRRcoSQZY6Jm6KzKCmCgXjs1gT22i6Oqnf32 3hQOIg6Nsq9hiJHl5pIB38/8g6FyvuzTx9OJmp6T1cw+7E3SZrW8IjH/BR2fZsn+BS +Vx4UGbAYssAZzp/yHU0Qo7JDtyzI6O/TOk91sAjSQhvSqSV9nb+jg/Z+netGgpHiZ UjvnxUkl/D7Zaofj2wJdsSaRS1JjfDR19aZa732toXu2lAI6I5t5Dqe40E9nKXWTpn TeHjTXvu99S4g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NLbTK3gBYz6tnx; Mon, 28 Nov 2022 20:42:12 +0100 (CET) In-Reply-To: <87sfi2vqxe.fsf@disroot.org> (Akib Azmain Turja's message of "Tue, 29 Nov 2022 01:07:25 +0600") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300683 Archived-At: Akib Azmain Turja writes: >>> @@ -3788,17 +3802,15 @@ DATA is the selection data encoded in base64." >>> (rx ?\\)) >>> output index))) >>> (if (not match) >>> - (progn >>> - ;; Not found, store the text to process it later when >>> - ;; we get the end of string. >>> - (setf (eat--t-term-parser-state eat--t-term) >>> - `(,state ,(concat buf (substring output >>> - index)))) >>> - (setq index (length output))) >>> + ;; Not found, store the text to process it later when >>> + ;; we get the end of string. >>> + (setf (eat--t-term-parser-state eat--t-term) >>> + `(,state ,(concat buf (substring output >>> + index))) >>> + index (length output)) >>> ;; Matched! Get the string from the output and previous >>> ;; runs. >>> - (let ((str (concat buf (substring output index >>> - match)))) >>> + (let ((str (concat buf (substring output index match)))) >>> (setq index (match-end 0)) >>> ;; Is it really the end of string? >>> (if (and (= (aref output match) ?\\) >> >> Somehow I prefer to use one setq for each variable. Is setting multiple >> at once faster? Benchmarking with "benchmark"... Yes, about 1.5 times. >> TODO. >> > > Done, but I didn't combine setf and setq, only two setq's or two setf's. Any reason why not?