From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Sun, 01 Jan 2023 19:41:33 +0100 Message-ID: <87a6329jxe.fsf@thornhill.no> References: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> <167e7ba3-ecb3-9e91-9a12-6020b4c1ec2b@secure.kjonigsen.net> <8538939b-5639-b8c0-82cc-113930a95ab1@secure.kjonigsen.net> <32bfc790-73fa-27b1-5fd8-50181e66015d@secure.kjonigsen.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38488"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60376@debbugs.gnu.org, Eli Zaretskii To: jostein@kjonigsen.net, Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 19:42:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC3Hn-0009m5-5S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 19:42:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC3HY-0002IX-Tx; Sun, 01 Jan 2023 13:42:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC3HX-0002IG-1w for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC3HW-0003S6-43 for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC3HV-0005zm-RZ for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167259849923014 (code B ref 60376); Sun, 01 Jan 2023 18:42:01 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 1 Jan 2023 18:41:39 +0000 Original-Received: from localhost ([127.0.0.1]:41755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC3H8-0005z8-KN for submit@debbugs.gnu.org; Sun, 01 Jan 2023 13:41:38 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:24353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC3H6-0005z0-Qj for 60376@debbugs.gnu.org; Sun, 01 Jan 2023 13:41:37 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1672598495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IEsFkPOFIe5eHdw9SGrMCxQdqO3P7luwhgq+aUTcdyM=; b=cQnnTFqlYb0ZqNd0TNW0WoPLs4bytXudzDeKsNtF6JusLd194fCex2SGVBc7i9HXwjPqpZ t3OgqhJJKiLqBuw+FoU+RGtmGsaJWOQhj9liOK/xXbq12P3NxcHNOU9R4MM+C/37Pm7bEA bbHpuZk4ecDXVA2zCzLjaORzzbq+F0bBntRMlwWW9jgYm113am8mvyFOA3Vqk4RsZ2y7Ct m1PBeAftUJ84KTw6+e/YugXaTdYyP2Urate7EwxJ+xHO364HaH9axjJ2zgtUPH5AkDZxVJ roeyfZluwzGRboenBZ2tqaAk8BBQoODof9LMedpZOs1G7Pdc52W4Em7DPixTUA== In-Reply-To: <32bfc790-73fa-27b1-5fd8-50181e66015d@secure.kjonigsen.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252275 Archived-At: Jostein Kj=C3=B8nigsen writes: > On 01.01.2023 18:24, Jostein Kj=C3=B8nigsen wrote: >> Disregard previous patch. >> >> Consider instead please the patch attached to this email. >> >> It does 3 things all in one: >> >> * moves function-call fontification to level 4 only (in its own feature) >> >> * cleans up long-standing issues with "messy" rules for=20 >> function-invocations. Removes the needs for "overrides". >> >> * also fixes issue with fonctification of self/this-method invocations. >> >> Theo: Can you try this patch and see what you think? >> >> --=20 >> >> Jostein > > Disregard again (and sorry for the noise!) > > I've now gone through several files, done quite a bit of testing myself,= =20 > and found another few issues needing to be solved: > > * Inconsistent variable-name fontification (sometimes when used, > sometimes when declared, sometimes not when used, sometimes not when > declared) > * Variable declaration with explicit generic types > * new() expression fontification for generic types. > * Bleeding type-face into brackets for generic return-types in method > definitions > * Types when casting through as-expressions are not fontified at all. > * And more? > > I've solved those and combined all this into this latest patch, which=20 > also moves function-invocation into its own (level 4) feature. > > This patch should be well beyond the "85%" which Eli has requested for=20 > Emacs-29 :) > > *Theo:* Could you give this a test-spin, and I promise to call it a day? = :) > Hi! No worries at all, I'm just glad you found some inspiration :-) This looks good to me. I think we are are all set - there are at least no more features needed. I guess we can still add some tweaks to the highlighting itself before the release? Yuan - you're next ;) Theo