From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package xeft.el Date: Wed, 04 Jan 2023 13:38:19 -0600 Message-ID: <87a62yxf84.fsf@red-bean.com> References: <64A01ADD-E757-40F5-A5C3-518BB8BE9A41@gmail.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18169"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Yuan Fu , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 04 20:39:03 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pD9bJ-0004VN-QF for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Jan 2023 20:39:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD9ap-0006Py-6V; Wed, 04 Jan 2023 14:38:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD9aj-0006Nq-QG for emacs-devel@gnu.org; Wed, 04 Jan 2023 14:38:26 -0500 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD9ah-0001Ky-Py for emacs-devel@gnu.org; Wed, 04 Jan 2023 14:38:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Reply-To:References:In-Reply-To:Subject:Cc:To: From:Sender:Content-ID:Content-Description; bh=YXr5JrglDi1MjHa/YNlM+r+ZS1zeicvT0sMvq1U4Ovs=; t=1672861101; x=1674070701; b=Ljn6ueojyDqSqe2Nv66czr2GwdSTVZF35YcNs15nWtZCgnjT3cB7OanJuwFHeaPds3iQDYGQII+ X9hs0xZ/upJV/6hMuO+cKg31rIuGBtiHXxt8NjZjgvXhayTBijA7rRp5FMmIz+GchWGWeAmXEm80f hbVNFZ/u7GToU82RwSVSjniayvyizHCK9On0B67pZMMdW3v4MRqPjBxcUuE3vXT2t2oSsESmxvQAp AU5d6mhv9Mr7VSQJjvg8aELQTpLWVfeYYQuIqbpEaSM9zjDVKVwK+N4IY34vmtUiXsXFXkc3OkiH8 E+noVi0y4Z5gJF7gzX2Dzj5/ia+6QL/XNMoQ==; Original-Received: from [12.106.183.66] (port=42699 helo=hummy) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pD9ae-009YCD-DF; Wed, 04 Jan 2023 19:38:20 +0000 In-Reply-To: (Stefan Monnier's message of "Wed, 04 Jan 2023 14:24:58 -0500") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302232 Archived-At: On 04 Jan 2023, Stefan Monnier wrote: >Yuan Fu [2023-01-02 20:11:50] wrote: >> I wrote xeft.el awhile ago, it allows you to search text notes=20 >> really fast >> by using a dynamic module. My initial plan is to somehow plug=20 >> the dynamic >> module into Deft some day and I=E2=80=99ll keep xeft to myself. Turns=20 >> out it=E2=80=99s not >> very feasible to make Deft use the dynamic module, so now I=20 >> thought I might >> as well publish xeft. After all I think it is really cool and I=20 >> want more >> people to use it :-) >> >> You can find xeft here: https://git.sr.ht/~casouri/xeft > >I'm a bit uncomfortable with the way this is set up: >it's unusable without downloading further code first. FWIW, I also was uncomfortable with this. I started to try out=20 xeft, but then I stopped when it asked me if I wanted to download=20 a binary package whose provenance wasn't clear to me. Actually, I tried choosing the 'c' option to 'c'ompile, but that=20 got a generic error, "Wrong type argument" or something like that.=20 I couldn't tell what was wrong. I thought that having certain=20 Debian packages (xapian-tools, python3-xapian, libxapian30,=20 libxapian-dev) installed already might mean that xeft would Just=20 Work, but that wasn't the case. Best regards, -Karl >Why not do it like the `pq` package, which includes the C source=20 >code in >the GNU ELPA package? IOW merge your `xapian-lite` repository=20 >into the >`xeft` repository. Or make a GNU ELPA package for `xapian-lite`=20 >if you >think the two should not be so closely tied to one another? > >Other details I saw along the way: >- You claim you have precompiled packages for GNU/Linux but=20 >that's only > true for amd64, which is only a particular subset of GNU/Linux > (most of my GNU/Linux machines (i386, armhf, arm64) are outside=20 > of > that subset, for example). > >- Your source code includes `emacs-module.h` which should not be > necessary because that file is distributed with Emacs (the way=20 > `pq` > finds it is not ideal, but this might be a good opportunity to=20 > look > at improving the situation and providing a standardized way for > ELisp packages to find that file). > >- `xapian-lite.cc` lacks a license blurb.