all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Karl Fogel <kfogel@red-bean.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Yuan Fu <casouri@gmail.com>,  emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ELPA] New package xeft.el
Date: Wed, 04 Jan 2023 13:38:19 -0600	[thread overview]
Message-ID: <87a62yxf84.fsf@red-bean.com> (raw)
In-Reply-To: <jwvwn62xgim.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 04 Jan 2023 14:24:58 -0500")

On 04 Jan 2023, Stefan Monnier wrote:
>Yuan Fu [2023-01-02 20:11:50] wrote:
>> I wrote xeft.el awhile ago, it allows you to search text notes 
>> really fast
>> by using a dynamic module. My initial plan is to somehow plug 
>> the dynamic
>> module into Deft some day and I’ll keep xeft to myself. Turns 
>> out it’s not
>> very feasible to make Deft use the dynamic module, so now I 
>> thought I might
>> as well publish xeft. After all I think it is really cool and I 
>> want more
>> people to use it :-)
>>
>> You can find xeft here: https://git.sr.ht/~casouri/xeft
>
>I'm a bit uncomfortable with the way this is set up:
>it's unusable without downloading further code first.

FWIW, I also was uncomfortable with this.  I started to try out 
xeft, but then I stopped when it asked me if I wanted to download 
a binary package whose provenance wasn't clear to me.

Actually, I tried choosing the 'c' option to 'c'ompile, but that 
got a generic error, "Wrong type argument" or something like that. 
I couldn't tell what was wrong.  I thought that having certain 
Debian packages (xapian-tools, python3-xapian, libxapian30, 
libxapian-dev) installed already might mean that xeft would Just 
Work, but that wasn't the case.

Best regards,
-Karl

>Why not do it like the `pq` package, which includes the C source 
>code in
>the GNU ELPA package?  IOW merge your `xapian-lite` repository 
>into the
>`xeft` repository.  Or make a GNU ELPA package for `xapian-lite` 
>if you
>think the two should not be so closely tied to one another?
>
>Other details I saw along the way:
>- You claim you have precompiled packages for GNU/Linux but 
>that's only
>  true for amd64, which is only a particular subset of GNU/Linux
>  (most of my GNU/Linux machines (i386, armhf, arm64) are outside 
>  of
>  that subset, for example).
>
>- Your source code includes `emacs-module.h` which should not be
>  necessary because that file is distributed with Emacs (the way 
>  `pq`
>  finds it is not ideal, but this might be a good opportunity to 
>  look
>  at improving the situation and providing a standardized way for
>  ELisp packages to find that file).
>
>- `xapian-lite.cc` lacks a license blurb.



  reply	other threads:[~2023-01-04 19:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03  4:11 [ELPA] New package xeft.el Yuan Fu
2023-01-04  8:08 ` Jean Louis
2023-01-04 16:46   ` Fu Yuan
2023-01-06 17:34     ` Jean Louis
2023-01-10 10:48       ` Yuan Fu
2023-01-04 19:24 ` Stefan Monnier
2023-01-04 19:38   ` Karl Fogel [this message]
2023-01-06  5:48     ` Yuan Fu
2023-01-06  5:46   ` Yuan Fu
2023-01-06 16:21     ` Stefan Monnier
2023-01-10 10:57       ` Yuan Fu
2023-01-13  4:51         ` Richard Stallman
2023-01-13  9:54           ` Dr. Arne Babenhauserheide
2023-01-15  5:14             ` Richard Stallman
2023-01-16  7:48               ` Dr. Arne Babenhauserheide
2023-01-17  4:57                 ` Richard Stallman
2023-01-17 11:53                   ` Eli Zaretskii
2023-01-23  4:23                     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a62yxf84.fsf@red-bean.com \
    --to=kfogel@red-bean.com \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.