From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61155: 29.0.60; build failures tree sitter Date: Mon, 30 Jan 2023 15:32:32 +0100 Message-ID: <87a62014an.fsf@thornhill.no> References: <7581-Sun29Jan2023210007+0000-jpff@codemist.co.uk> <877cx4z7lz.fsf@gmail.com> <87cz6w1c93.fsf@thornhill.no> <834js85fhe.fsf@gnu.org> <83wn543xzd.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4798"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 61155@debbugs.gnu.org, jpff@codemist.co.uk To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 15:33:48 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMVEB-0000xs-F5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 15:33:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMVDm-0003RP-1d; Mon, 30 Jan 2023 09:33:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMVDU-0003L6-M0 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:33:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMVDU-0004M6-CT for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:33:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMVDU-0002ZF-9M for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:33:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 14:33:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61155 X-GNU-PR-Package: emacs Original-Received: via spool by 61155-submit@debbugs.gnu.org id=B61155.16750891639807 (code B ref 61155); Mon, 30 Jan 2023 14:33:04 +0000 Original-Received: (at 61155) by debbugs.gnu.org; 30 Jan 2023 14:32:43 +0000 Original-Received: from localhost ([127.0.0.1]:46786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMVD8-0002Y2-FQ for submit@debbugs.gnu.org; Mon, 30 Jan 2023 09:32:42 -0500 Original-Received: from out-104.mta0.migadu.com ([91.218.175.104]:32722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMVD1-0002XC-H2 for 61155@debbugs.gnu.org; Mon, 30 Jan 2023 09:32:36 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1675089153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SojQoLvdtOqy2U3scUUFmGZMYZDBfkyClCFxVLq+1/Q=; b=JOPNhrE7KmsgtzTxqF7EWGx8Nr1DR5D6QMGNvA6HaLzroPqOR80vxdK5lg6mSwPRQ4U4GZ KLT6IAC2e84Hc3KP4faPqJ/xLnAwsJpW7Qy+zlFdQ8Dd9ayMdsa+19BzqppE8uI7BuG1M4 LzKkrmBEKa+cOUVZwRkcVG2pLnwTgsJtaNHGyrLk2j8y9DB+/vCFBUsx238mZzO5cQSxNS RCj6S4peTGp1Dlpm69xvulufocJDxpySA2+WkacJqvSo2vneBd8Ji7DdbQRK1LCEMssGGO kyeET0Q/dzcxT3kJpjvtFcR5sRRhPrFSYbHXGZRpD0YdqJfGfTtCP5w+tlk+xw== In-Reply-To: <83wn543xzd.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254431 Archived-At: Eli Zaretskii writes: >> Date: Mon, 30 Jan 2023 14:22:10 +0100 >> From: Theodor Thornhill >> CC: rpluim@gmail.com, jpff@codemist.co.uk, 61155@debbugs.gnu.org >> >> >> >> On 30 January 2023 14:17:17 CET, Eli Zaretskii wrote: >> >> Cc: 61155@debbugs.gnu.org >> >> Date: Mon, 30 Jan 2023 12:40:40 +0100 >> >> From: Theodor Thornhill via "Bug reports for GNU Emacs, >> >> the Swiss army knife of text editors" >> >> >> >> Can you try this and see if the error goes away? >> >> >> >> thanks, >> >> Theo >> >> >> >> diff --git a/lisp/treesit.el b/lisp/treesit.el >> >> index 92833fb007..d7e702bfb8 100644 >> >> --- a/lisp/treesit.el >> >> +++ b/lisp/treesit.el >> >> @@ -568,7 +568,7 @@ treesit--font-lock-level-setter >> >> res) >> >> (let ((buffer (car buffers))) >> >> (with-current-buffer buffer >> >> - (if (treesit-parser-list) >> >> + (if (and (treesit-available-p) (treesit-parser-list)) >> >> (loop (append res (list buffer)) (cdr buffers)) >> >> (loop res (cdr buffers)))))))) >> > >> >I fixed this differently, please see the latest emacs-29 branch: I >> >disabled the loop altogether. >> > >> >Why would we need to loop over buffers if tree-sitter is not >> >available? >> >> No need, your fix it fine, i just whipped up something quick in a break here :) > > OK, thanks. > > Btw, it was a bitch finding which code caused the error message. It > is easy to forget that the :set functions of defcustom's are called > during startup, and the line number shown with the message didn't > identify the defcustom, just the file name. I eventually found this > was the culprit by running the byte-compilation command under GDB... Yeah - thanks for fixing :) Theo