From: Fernando de Morais <fernandodemorais.jf@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 61308@debbugs.gnu.org
Subject: bug#61308: 28.2; icomplete --- Error in post-command-hook: wrong-type-argument
Date: Wed, 08 Feb 2023 19:09:09 -0300 [thread overview]
Message-ID: <87a61n6c8q.fsf@gmail.com> (raw)
In-Reply-To: <86cz6k1v3a.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 08 Feb 2023 09:20:57 +0200")
Hello Juri,
Juri Linkov <juri@linkov.net> writes:
> Interesting bug report. I guess we need to double-check
> if we are still in the right buffer after help-window-select
> selects another window and thus confuses icomplete-mode:
>
> diff --git a/lisp/icomplete.el b/lisp/icomplete.el
> index 014f38b2024..97457832e2c 100644
> --- a/lisp/icomplete.el
> +++ b/lisp/icomplete.el
> @@ -686,6 +686,8 @@ icomplete-exhibit
> Should be run via minibuffer `post-command-hook'.
> See `icomplete-mode' and `minibuffer-setup-hook'."
> (when (and icomplete-mode
> + ;; Check if still in the right buffer (bug#61308)
> + (or (window-minibuffer-p) completion-in-region--data)
> (icomplete-simple-completing-p)) ;Shouldn't be necessary.
> (let ((saved-point (point)))
> (save-excursion
This solved the problem, thank you! 🤝
I hope this path gets merged upstream.
--
Regards,
Fernando de Morais.
next prev parent reply other threads:[~2023-02-08 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 2:32 bug#61308: 28.2; icomplete --- Error in post-command-hook: wrong-type-argument Fernando de Morais
2023-02-08 7:20 ` Juri Linkov
2023-02-08 22:09 ` Fernando de Morais [this message]
2023-02-09 18:09 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a61n6c8q.fsf@gmail.com \
--to=fernandodemorais.jf@gmail.com \
--cc=61308@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.