From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Date: Wed, 08 Mar 2023 12:47:19 +0100 Message-ID: <87a60npirc.fsf@gmail.com> References: <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org> <20230307172816.2D56BC13915@vcs2.savannah.gnu.org> <877cvsozn5.fsf@yahoo.com> <87zg8onfob.fsf@yahoo.com> <87r0tzoeam.fsf@yahoo.com> <87a60no7su.fsf@yahoo.com> <87edpzplom.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22331"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 08 12:47:38 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZsGf-0005hC-SY for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Mar 2023 12:47:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZsGU-0006vp-Sa; Wed, 08 Mar 2023 06:47:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZsGT-0006vb-7B for emacs-devel@gnu.org; Wed, 08 Mar 2023 06:47:25 -0500 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZsGQ-0002j7-JT for emacs-devel@gnu.org; Wed, 08 Mar 2023 06:47:24 -0500 Original-Received: by mail-wm1-x32a.google.com with SMTP id l7-20020a05600c1d0700b003eb5e6d906bso957890wms.5 for ; Wed, 08 Mar 2023 03:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678276040; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=U2h8Tu2FX4n+Sdgea1V4Z4n5E4a/3D/AcQOmtpgt178=; b=h/tO0B3jJOV4mKSCCX+Smo59sUxKBxOM2IL6f0A45C0eD4Ly7PiPr+O5TeLKUqvoF5 3L6oaF/BGBs/tCXSVUi6qNTs4CJI4n4EItuF6VMNkxLgqunF/tCCI0a2dUGViKF1+rEi 2gtWzpqdBgY2huTPwEeBhHDIn4sxo3PmhPoicdgF9AFHFjLKhApg42ZZyDZS7nRFg13w s1GdiWqHlu+7FcDzscCiK1qWRTakOf5roOOxtdz8NM11GiZ26xUBK6u7EKpjx+QwdkGJ 29VZ4WB0MTKLtYxIC+YLvSulux4Amd5jQKVyb3+ZvCutWCJ0SGbm9lHzleWn9hp13rB0 Az6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678276040; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U2h8Tu2FX4n+Sdgea1V4Z4n5E4a/3D/AcQOmtpgt178=; b=IyvnWnsmqaMxTEw/JFivG5ZPBr0NsFEMCuRwqbYK2XRo0Z+fevUbg8LPv4w9I84RIE 3bNDedU5OfK5tJpJlaQHXwYoKmyOTeBob3S0CapHRHiQBk1J9tKuzLdt/sadOSaXahxL Aat4ZYNTtgMcMIIwfl0YI5YMSPodWLPYEjeNOmBdhhoCkGFBNmg7IRMuujGO4G6soHcU N2JzhkGJoK+EyWi9s6ifn/dg6ihVmR7gr1mtV4E64H7HouDq552cUmHoVjeXQbUgBWPv DfXIPc+UKiI5peR4sfi4YUBLfoCBZN94ICA4s1756Q40QrI6jnCdhoo60MAGzU9D4bl8 taUQ== X-Gm-Message-State: AO0yUKURReeKKOJizxSI3rMBj+hjD4pgOEYYLl4xkIEmPHLEy9yo1nO6 T0iHxlapOxxOY/sOgDrZzJzq2RnSRb8= X-Google-Smtp-Source: AK7set+N4EUgvXTMn+NbJ47cBpZt9MlvE8Lnsgc16bCCWpACg+XoOEEazTqTurQM+PRdXETFLHt5LA== X-Received: by 2002:a05:600c:3b9b:b0:3eb:3998:36f1 with SMTP id n27-20020a05600c3b9b00b003eb399836f1mr16531725wms.41.1678276040641; Wed, 08 Mar 2023 03:47:20 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v28-20020a5d591c000000b002c6e8af1037sm14998966wrd.104.2023.03.08.03.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 03:47:20 -0800 (PST) In-Reply-To: (Ulrich Mueller's message of "Wed, 08 Mar 2023 12:29:13 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304123 Archived-At: >>>>> On Wed, 08 Mar 2023 12:29:13 +0100, Ulrich Mueller s= aid: >>>>> On Wed, 08 Mar 2023, Ulrich Mueller wrote: >> Sure, something like this (not yet tested): >> -Exec=3Dbash -c "u=3D\\${1//\\\\\\\\/\\\\\\\\\\\\\\\\}; u=3D\\${u//\= \\\\\"/\\\\\\\\\\\\\\"}; exec emacsclient --alternate-editor=3D --display= =3D\\"\\$DISPLAY\\" --eval \\"(message-mailto \\\\\\"\\$u\\\\\\")\\"" bash = %u >> +Exec=3Dsh -c "u=3D\\$\\(echo \\"\\$1\\" | sed \\'s/[\\\\\\"]/\\\\\\= \\\\&/g\\'\\); exec emacsclient --alternate-editor=3D --display=3D\\"\\$DIS= PLAY\\" --eval \\"(message-mailto \\\\\\"\\$u\\\\\\")\\"" sh %u >> Sorry, but it doesn't get less ugly. :) Also, it will now call _two_ >> external programs. Is this acceptable, and is it guaranteed that sed >> will be available on users' systems? `sed' is POSIX mandatory, and `bash' is not. And `echo' is mandatory as well, since you=CA=BCre also using that :-) Ulrich> In fact, only '"', '$', and '\' need to be backslash-escaped. Ulrich> Patch included below, works fine here. That looks better. We can then add `--funcall' to emacs-30, and revisit this there. Thanks Robert --=20